From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 589F3C3ABC3 for ; Tue, 13 May 2025 16:16:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yDS9tO3ad7hmn2izTyW+Vt2trGV6W8nXY+0cUczUfFk=; b=w9pscZByx2incUIxTHhQ8HfIuh OLIMYF9y8UGOuvdyrnm34IxLSsA1G+/UKWw128UZT+i9MdjA3p/EmOhpM+U3lhWtOG99J9L2A67ms m9jdqLBDCykh6Hxfddx73/z1zwrjbVP0a4pNYtnWx2WDnu2deIOBQcsxs14l7abZoXBtulwkl54Tv /vnApBakFzKcJ65ahUrmDGshdiq4HxM1DEfpucqpoQ2vjhJ92f9aDys5+tBZJiDA+bGbpA4YJcDEg LKJHHVA9rQkYNyMNAVO1jGSchriwDZO1XU3Kwoq0UppKB7w6dhQG/0Dp8N0L1VJuChSlNPC1JTkps 6n2G6cHw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uEsIi-0000000Ctkv-2j84; Tue, 13 May 2025 16:16:16 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uEsFR-0000000CtL7-4C6R; Tue, 13 May 2025 16:12:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Type:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID; bh=yDS9tO3ad7hmn2izTyW+Vt2trGV6W8nXY+0cUczUfFk=; b=CDUZIWTZ8iV9z1vn5NZhf+dsJZ AbKY0wgyt8Oj4xHVMmjBVaH06DIx9JvBRRbWGiZc9BYwkuYOpawrp799rRkal1rqEJyIwGAyfXzg9 RmHWCTQtJM31w51y111FTNoYVkd5aCaM6ra7mSIKL06993wDw/OIglQSGfEKoVc7Ou1pRKIvR/l8V D6W5vz5mv22m5PH4UVwMNtd8msAg3ioQrsIea8Lonwok8btQ4sjAP3toMWs5xWLLTub1Y8N6awwxu npSWtVaCVmwlaxPNqM+xeZmVCdYWMbDO3e/mutonXgdzyCDPPlIAtEjimP8ZdhgUoZssx/XLNqoLi qC7Ist8Q==; Received: from i53875a50.versanet.de ([83.135.90.80] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uEsFM-0001AW-Td; Tue, 13 May 2025 18:12:48 +0200 From: Heiko =?UTF-8?B?U3TDvGJuZXI=?= To: Matthias Kaehlcke , Greg Kroah-Hartman , Benjamin Bara , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Klaus Goger , Lukasz Czechowski Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Lukasz Czechowski , stable@vger.kernel.org Subject: Re: [PATCH v2 1/5] usb: misc: onboard_usb_dev: fix support for Cypress HX3 hubs Date: Tue, 13 May 2025 18:12:47 +0200 Message-ID: <2058366.PIDvDuAF1L@diego> In-Reply-To: <20250425-onboard_usb_dev-v2-1-4a76a474a010@thaumatec.com> References: <20250425-onboard_usb_dev-v2-0-4a76a474a010@thaumatec.com> <20250425-onboard_usb_dev-v2-1-4a76a474a010@thaumatec.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250513_091254_058589_61874980 X-CRM114-Status: GOOD ( 24.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Freitag, 25. April 2025, 17:18:06 Mitteleurop=C3=A4ische Sommerzeit schr= ieb Lukasz Czechowski: > The Cypress HX3 USB3.0 hubs use different PID values depending > on the product variant. The comment in compatibles table is > misleading, as the currently used PIDs (0x6504 and 0x6506 for > USB 3.0 and USB 2.0, respectively) are defaults for the CYUSB331x, > while CYUSB330x and CYUSB332x variants use different values. > Based on the datasheet [1], update the compatible usb devices table > to handle different types of the hub. > The change also includes vendor mode PIDs, which are used by the > hub in I2C Master boot mode, if connected EEPROM contains invalid > signature or is blank. This allows to correctly boot the hub even > if the EEPROM will have broken content. > Number of vcc supplies and timing requirements are the same for all > HX variants, so the platform driver's match table does not have to > be extended. >=20 > [1] https://www.infineon.com/dgdl/Infineon-HX3_USB_3_0_Hub_Consumer_Indus= trial-DataSheet-v22_00-EN.pdf?fileId=3D8ac78c8c7d0d8da4017d0ecb53f644b8 > Table 9. PID Values >=20 > Fixes: b43cd82a1a40 ("usb: misc: onboard-hub: add support for Cypress HX3= USB 3.0 family") > Cc: stable@vger.kernel.org > Signed-off-by: Lukasz Czechowski Reviewed-by: Heiko Stuebner @GregKH: I'd assume you pick patches 1+2 (dt-binding + driver) and I pick t= he Rockchip arm64-dts patches afterwards, after the first two look good to you? Thanks a lot Heiko > --- > drivers/usb/misc/onboard_usb_dev.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/usb/misc/onboard_usb_dev.c b/drivers/usb/misc/onboar= d_usb_dev.c > index 75ac3c6aa92d0d925bb9488d1e6295548446bf98..f5372dfa241a9cee09fea95fd= 14b72727a149b2e 100644 > --- a/drivers/usb/misc/onboard_usb_dev.c > +++ b/drivers/usb/misc/onboard_usb_dev.c > @@ -569,8 +569,14 @@ static void onboard_dev_usbdev_disconnect(struct usb= _device *udev) > } > =20 > static const struct usb_device_id onboard_dev_id_table[] =3D { > - { USB_DEVICE(VENDOR_ID_CYPRESS, 0x6504) }, /* CYUSB33{0,1,2}x/CYUSB230x= 3.0 HUB */ > - { USB_DEVICE(VENDOR_ID_CYPRESS, 0x6506) }, /* CYUSB33{0,1,2}x/CYUSB230x= 2.0 HUB */ > + { USB_DEVICE(VENDOR_ID_CYPRESS, 0x6500) }, /* CYUSB330x 3.0 HUB */ > + { USB_DEVICE(VENDOR_ID_CYPRESS, 0x6502) }, /* CYUSB330x 2.0 HUB */ > + { USB_DEVICE(VENDOR_ID_CYPRESS, 0x6503) }, /* CYUSB33{0,1}x 2.0 HUB, Ve= ndor Mode */ > + { USB_DEVICE(VENDOR_ID_CYPRESS, 0x6504) }, /* CYUSB331x 3.0 HUB */ > + { USB_DEVICE(VENDOR_ID_CYPRESS, 0x6506) }, /* CYUSB331x 2.0 HUB */ > + { USB_DEVICE(VENDOR_ID_CYPRESS, 0x6507) }, /* CYUSB332x 2.0 HUB, Vendor= Mode */ > + { USB_DEVICE(VENDOR_ID_CYPRESS, 0x6508) }, /* CYUSB332x 3.0 HUB */ > + { USB_DEVICE(VENDOR_ID_CYPRESS, 0x650a) }, /* CYUSB332x 2.0 HUB */ > { USB_DEVICE(VENDOR_ID_CYPRESS, 0x6570) }, /* CY7C6563x 2.0 HUB */ > { USB_DEVICE(VENDOR_ID_GENESYS, 0x0608) }, /* Genesys Logic GL850G USB = 2.0 HUB */ > { USB_DEVICE(VENDOR_ID_GENESYS, 0x0610) }, /* Genesys Logic GL852G USB = 2.0 HUB */ >=20 >=20