From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A020FC77B60 for ; Fri, 31 Mar 2023 21:50:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FnlQUMjRYl47UbP8eIXHxYLb3+jB/2f5hMRt5IRkaww=; b=Aj8YGGCmDbpFUA oTSUPPJqCdb27h7CvfJXKyWQ85VW8xgp8N/4qzZ2eQy0TCXvh7lSFRGs1wN9ckBvZPx+3wxVG5hEO LFcDKCz7muxU4cN+dSZ51BU6oNQmM1XSTew4zuKPxxhCWlr0kINqSPxr0vHhsgq5ctfzKecw1VXAu eLccS6aVXZP/TVgT2DRYSYUnXCKDB0t7/Hm5w9OP+k2T66YUpDihzD1iDNsLzcVBrOaXwcaaE/7kD W2mweSiCZBzai0HxmRynAJc4+UBaw8ml+kwnYFYAY0TigkFdxUa+2AuE9U5IUdgrPCbR97pmv91IE P1K6yz62F+qj0HJiQHow==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1piMcl-008yhQ-1l; Fri, 31 Mar 2023 21:49:31 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1piMcj-008yfF-0q; Fri, 31 Mar 2023 21:49:30 +0000 Received: from ip4d1634d3.dynamic.kabel-deutschland.de ([77.22.52.211] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1piMcK-0006Di-Gz; Fri, 31 Mar 2023 23:49:04 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Joerg Roedel , Jason Gunthorpe , Steven Price Cc: Steven Price , Will Deacon , Robin Murphy , iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, John Keeping Subject: Re: [PATCH v4] iommu/rockchip: Add missing set_platform_dma_ops callback Date: Fri, 31 Mar 2023 23:49:03 +0200 Message-ID: <2077066.bB369e8A3T@diego> In-Reply-To: <20230331095154.2671129-1-steven.price@arm.com> References: <20230331095154.2671129-1-steven.price@arm.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230331_144929_312003_3A5E84E9 X-CRM114-Status: GOOD ( 11.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Freitag, 31. M=E4rz 2023, 11:51:54 CEST schrieb Steven Price: > Similar to exynos, we need a set_platform_dma_ops() callback for proper > operation on ARM 32 bit after recent changes in the IOMMU framework > (detach ops removal). But also the use of a NULL domain is confusing. > = > Rework the code to add support for IOMMU_DOMAIN_IDENTITY and a singleton > rk_identity_domain which is assigned to domain when using an identity > mapping rather than "detaching". This makes the code easier to reason abo= ut. > = > Signed-off-by: Steven Price My knowledge of IOMMU magic is not that deep. Nevertheless I do believe to mostly understand the change and the splats on my rk3288-pinky are gone now with this patch: Acked-by: Heiko Stuebner Tested-by: Heiko Stuebner _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel