From: tomasz.figa@gmail.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: Do we have people interested in device tree janitoring / cleanup?
Date: Thu, 25 Jul 2013 01:22:44 +0200 [thread overview]
Message-ID: <2077078.hRKZxaEG2D@flatron> (raw)
In-Reply-To: <CAOesGMj5eyRdE++hJgFV3AJKUGWZEoE7P9_pr_5QBHpJWFCzmQ@mail.gmail.com>
On Wednesday 24 of July 2013 16:20:02 Olof Johansson wrote:
> Hi,
>
> On Wed, Jul 24, 2013 at 4:15 PM, Tomasz Figa <tomasz.figa@gmail.com>
wrote:
> > Hi Olof,
> >
> > On Wednesday 24 of July 2013 08:27:13 Olof Johansson wrote:
> >> Every now and then I come across a binding that's just done
> >> Wrong(tm),
> >> merged through a submaintainer tree and hasn't seen proper review --
> >> if it had, it wouldn't look the way it does. It's something we're
> >> starting to address now since there's more people stepping up to be
> >> maintainers, but there's a backlog of bad bindings already merged.
> >>
> >> Often they are produced by translating the platform_data structures
> >> directly over into device-tree properties without consideration to
> >> describing the hardware or usual conventions, using key/value pairs
> >> instead of boolean properties, etc.
> >>
> >> Getting involved in cleaning up these kind of bindings is a great way
> >> to learn "the ways of device tree" for someone that has interest in
> >> that.
> >>
> >> Latest find in this area is the Maxim 8925 bindings, that I came
> >> across since they caused a compile warning on some defconfig. I'll
> >> post a patch to address the warning but if someone else feels like
> >> fixing the bindings on top of it that would be appreciated!
> >
> > Care to explain your doubts about max8952 bindings? As far as I
> > remember it's just a standard single voltage regulator (= generic
> > regulator bindings) + some device specific properties.
> >
> > Looking at Documentation/devicetree/bindings/regulator/max8952.txt I
> > don't really see anything worrying...
>
> Documentation/devicetree/bindings/video/backlight/max8925-backlight.txt
>
> But yes, the regulator one looks normal.
Oh gosh, it's time to sleep. I confused 8925 with 8952... Sorry for the
noise and thanks for quick reply. (I'm writing separate reply about
janitoring/cleanup itself.)
Best regards,
Tomasz
next prev parent reply other threads:[~2013-07-24 23:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-24 15:27 Do we have people interested in device tree janitoring / cleanup? Olof Johansson
2013-07-24 18:31 ` Rob Herring
2013-07-24 19:03 ` Jason Cooper
2013-07-24 23:29 ` Tomasz Figa
2013-07-24 23:52 ` Jason Cooper
2013-07-24 23:15 ` Tomasz Figa
2013-07-24 23:20 ` Olof Johansson
2013-07-24 23:22 ` Tomasz Figa [this message]
2013-07-24 23:17 ` Domenico Andreoli
2013-07-24 23:20 ` Olof Johansson
2013-07-25 0:36 ` Domenico Andreoli
2013-07-25 0:57 ` Kyle Spaans (CSC)
2013-07-25 11:06 ` Dave Martin
2013-07-25 11:25 ` Russell King - ARM Linux
2013-07-25 13:31 ` Mark Brown
2013-07-25 13:56 ` Domenico Andreoli
2013-07-25 14:27 ` Russell King - ARM Linux
2013-07-25 14:38 ` Catalin Marinas
2013-07-28 4:47 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2077078.hRKZxaEG2D@flatron \
--to=tomasz.figa@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).