[PATCH 11/14] ARM: mvebu: Relocate Armada 370/XP DeviceBus device tree nodes

Arnd Bergmann
2013-06-07T19:18:16Z

On Friday 07 June 2013, Ezequiel Garcia wrote:
> --- a/arch/arm/boot/dts/armada-370-xp.dtsi
> +++ b/arch/arm/boot/dts/armada-370-xp.dtsi
> @@ -34,6 +34,51 @@
> compatible = "simple-bus";
> interrupt-parent = <&mpic>;
>
> + devbus-bootcs {
> + compatible = "marvell,mvebu-devbus";
> + reg = <0 0x10400 0x8>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + clocks = <&coreclk 0>;
> + status = "disabled";
> + };
> +
...
> internal-regs {
> compatible = "simple-bus";
> #address-cells = <1>;

I think you are missing a couple of things here:

* The mbus node needs #address-cells and #size-cells, and is no longer
compatible="simple-bus"m since it's actually complex.

* The devbus-bootcs node and all other ones need "ranges" properties.

* The "reg" property of the devbus-bootcs device needs to be in
mbus translated address space, so I assume the first cell would
be something other than '0'.

* With the proposal I made for patch 3, you would actually
need a ranges property for the mbus node as well.

Arnd