public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
* [PATCH 1/1] arm64: dts: rockchip: remove RTC for Radxa E52C
@ 2026-01-08 10:00 Chukun Pan
  2026-01-08 10:17 ` FUKAUMI Naoki
  0 siblings, 1 reply; 4+ messages in thread
From: Chukun Pan @ 2026-01-08 10:00 UTC (permalink / raw)
  To: Heiko Stuebner
  Cc: Rob Herring, Chukun Pan, FUKAUMI Naoki, Conor Dooley,
	Krzysztof Kozlowski, linux-arm-kernel, linux-rockchip,
	linux-kernel, devicetree

According to the Radxa E52C Schematic [1], both the i2c5 bus and the
hym8563 chip are marked as NC. Remove them to avoid the following log:

rtc-hym8563 5-0051: could not init device, -110
rtc-hym8563 5-0051: probe with driver rtc-hym8563 failed with error -110

[1] https://dl.radxa.com/e/e52c/hw/radxa_e52c_v1.2_schematic.pdf

Fixes: 9be4171219b6 ("arm64: dts: rockchip: Add Radxa E52C")
Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
---
 .../boot/dts/rockchip/rk3582-radxa-e52c.dts   | 24 -------------------
 1 file changed, 24 deletions(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts b/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
index 854c118418eb..c24ff264cae2 100644
--- a/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
@@ -266,24 +266,6 @@ regulator-state-mem {
 	};
 };
 
-&i2c5 {
-	pinctrl-names = "default";
-	pinctrl-0 = <&i2c5m2_xfer>;
-	status = "okay";
-
-	rtc@51 {
-		compatible = "haoyu,hym8563";
-		reg = <0x51>;
-		#clock-cells = <0>;
-		clock-output-names = "rtcic_32kout";
-		interrupt-parent = <&gpio0>;
-		interrupts = <RK_PB0 IRQ_TYPE_LEVEL_LOW>;
-		pinctrl-names = "default";
-		pinctrl-0 = <&rtc_int_l>;
-		wakeup-source;
-	};
-};
-
 &pcie2x1l1 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pcie20x1_1_perstn_m1>;
@@ -329,12 +311,6 @@ vcc_5v0_pwren_h: vcc-5v0-pwren-h {
 		};
 	};
 
-	rtc {
-		rtc_int_l: rtc-int-l {
-			rockchip,pins = <0 RK_PB0 RK_FUNC_GPIO &pcfg_pull_none>;
-		};
-	};
-
 	usb {
 		usb_otg_pwren_h: usb-otg-pwren-h {
 			rockchip,pins = <0 RK_PD4 RK_FUNC_GPIO &pcfg_pull_none>;
-- 
2.25.1



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/1] arm64: dts: rockchip: remove RTC for Radxa E52C
  2026-01-08 10:00 [PATCH 1/1] arm64: dts: rockchip: remove RTC for Radxa E52C Chukun Pan
@ 2026-01-08 10:17 ` FUKAUMI Naoki
  2026-01-08 12:30   ` Chukun Pan
  0 siblings, 1 reply; 4+ messages in thread
From: FUKAUMI Naoki @ 2026-01-08 10:17 UTC (permalink / raw)
  To: Chukun Pan, Heiko Stuebner
  Cc: Rob Herring, Conor Dooley, Krzysztof Kozlowski, linux-arm-kernel,
	linux-rockchip, linux-kernel, devicetree

Hi Chukun,

On 1/8/26 19:00, Chukun Pan wrote:
> According to the Radxa E52C Schematic [1], both the i2c5 bus and the
> hym8563 chip are marked as NC. Remove them to avoid the following log:
> 
> rtc-hym8563 5-0051: could not init device, -110
> rtc-hym8563 5-0051: probe with driver rtc-hym8563 failed with error -110
> 
> [1] https://dl.radxa.com/e/e52c/hw/radxa_e52c_v1.2_schematic.pdf

V1.209 and later should have RTC. What version do you have?

Best regards,

--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.

> Fixes: 9be4171219b6 ("arm64: dts: rockchip: Add Radxa E52C")
> Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
> ---
>   .../boot/dts/rockchip/rk3582-radxa-e52c.dts   | 24 -------------------
>   1 file changed, 24 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts b/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
> index 854c118418eb..c24ff264cae2 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
> @@ -266,24 +266,6 @@ regulator-state-mem {
>   	};
>   };
>   
> -&i2c5 {
> -	pinctrl-names = "default";
> -	pinctrl-0 = <&i2c5m2_xfer>;
> -	status = "okay";
> -
> -	rtc@51 {
> -		compatible = "haoyu,hym8563";
> -		reg = <0x51>;
> -		#clock-cells = <0>;
> -		clock-output-names = "rtcic_32kout";
> -		interrupt-parent = <&gpio0>;
> -		interrupts = <RK_PB0 IRQ_TYPE_LEVEL_LOW>;
> -		pinctrl-names = "default";
> -		pinctrl-0 = <&rtc_int_l>;
> -		wakeup-source;
> -	};
> -};
> -
>   &pcie2x1l1 {
>   	pinctrl-names = "default";
>   	pinctrl-0 = <&pcie20x1_1_perstn_m1>;
> @@ -329,12 +311,6 @@ vcc_5v0_pwren_h: vcc-5v0-pwren-h {
>   		};
>   	};
>   
> -	rtc {
> -		rtc_int_l: rtc-int-l {
> -			rockchip,pins = <0 RK_PB0 RK_FUNC_GPIO &pcfg_pull_none>;
> -		};
> -	};
> -
>   	usb {
>   		usb_otg_pwren_h: usb-otg-pwren-h {
>   			rockchip,pins = <0 RK_PD4 RK_FUNC_GPIO &pcfg_pull_none>;



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/1] arm64: dts: rockchip: remove RTC for Radxa E52C
  2026-01-08 10:17 ` FUKAUMI Naoki
@ 2026-01-08 12:30   ` Chukun Pan
  2026-01-08 13:54     ` Heiko Stübner
  0 siblings, 1 reply; 4+ messages in thread
From: Chukun Pan @ 2026-01-08 12:30 UTC (permalink / raw)
  To: naoki
  Cc: amadeus, conor+dt, devicetree, heiko, krzk+dt, linux-arm-kernel,
	linux-kernel, linux-rockchip

Hi,

> V1.209 and later should have RTC. What version do you have?

# hexdump -C /sys/bus/i2c/devices/0-0050/eeprom
00000070  0c 00 00 00 01 00 56 31  2e 32 30 38 00 00 89 0b  |......V1.208....|

How should we handle the older versions?

Thanks,
Chukun


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/1] arm64: dts: rockchip: remove RTC for Radxa E52C
  2026-01-08 12:30   ` Chukun Pan
@ 2026-01-08 13:54     ` Heiko Stübner
  0 siblings, 0 replies; 4+ messages in thread
From: Heiko Stübner @ 2026-01-08 13:54 UTC (permalink / raw)
  To: naoki, Chukun Pan
  Cc: amadeus, conor+dt, devicetree, krzk+dt, linux-arm-kernel,
	linux-kernel, linux-rockchip

Am Donnerstag, 8. Januar 2026, 13:30:08 Mitteleuropäische Normalzeit schrieb Chukun Pan:
> > V1.209 and later should have RTC. What version do you have?
> 
> # hexdump -C /sys/bus/i2c/devices/0-0050/eeprom
> 00000070  0c 00 00 00 01 00 56 31  2e 32 30 38 00 00 89 0b  |......V1.208....|
> 
> How should we handle the older versions?

I think we might want an dt-overlay for this.

As the value can be read from the eeprom, you could even add code to the
board in u-boot to set the "fdtoverlay" variable automatically for extlinux.


Heiko




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-01-08 13:55 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-08 10:00 [PATCH 1/1] arm64: dts: rockchip: remove RTC for Radxa E52C Chukun Pan
2026-01-08 10:17 ` FUKAUMI Naoki
2026-01-08 12:30   ` Chukun Pan
2026-01-08 13:54     ` Heiko Stübner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox