From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 776FEEB64D7 for ; Fri, 23 Jun 2023 06:02:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=m19beVe2sSRZofjZ9jbB7Fs9MVoK8KZJmsMsJymFr4c=; b=WsidlccVr2YUIk u7CsMH8agoHvO22UDMz2dcmCGtjxbipDV0aOFIw9xuSv3Df2ns22aFMb2wGGF2aHcct9jKRpcjiDP Ta9LCWv1e/49RuAaQAadhI4XC/nMcDhm7LEFirjzWGghm2FVMHjMrQoLmrl1YEPgrfvUAk7wIGpDo Cp2gYMli5Sk4SVPEKkdLHVt0cZBaUxQl5qqsaGcBrhCeh0dk9jgEkN8rtzR76rZo976hWzt9K9COa vNdef9i7R6cgZsLmYECPJzfbyC2jhOJwRwcj5yx+ySnySgHlb4hZlcVURxZi2EDCTLc7BD3MAEwE9 TgQ1po9kDaFPTeMjeFEA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qCZsE-002elJ-1m; Fri, 23 Jun 2023 06:02:22 +0000 Received: from mga01.intel.com ([192.55.52.88]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qCZsB-002eku-2M for linux-arm-kernel@lists.infradead.org; Fri, 23 Jun 2023 06:02:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687500139; x=1719036139; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=Vodh8wAG7sJf3qs+Aw5XI9b3gtoEQcZ37TMv9wZhJAw=; b=IqM+zcJFVp8xZ91p74L4XTdCccCnLhdRaa2TYYwNE2TSLCkn8oJFmqts nYgIlK3JOnO72GwZ19On6Yh5/+josU/pVDidt4P31dLQlFvwbuBEfmbpQ oxGuOnHeiRxodsluBP9uFawVUwFg1XiOlcR7I32q7wRPFZp6bmSpdXEbM K8UbueXeG1bIDGC+QIaU1PT36Ny7yj/zgjWs9hL/UbmoIlvPNWlT0DneY 2MmkeaNlrZvQj0SNwBPzEaWyJ1HAMUOfw/L4sJtyJMKHE9mjkVUfLc09P 2ufRjEYkViC28jevmE63Bo3BhAdi5qzPLLkytCFV0nEqpqpCIAmy2gocZ A==; X-IronPort-AV: E=McAfee;i="6600,9927,10749"; a="390612535" X-IronPort-AV: E=Sophos;i="6.01,151,1684825200"; d="scan'208";a="390612535" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jun 2023 23:02:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10749"; a="828253855" X-IronPort-AV: E=Sophos;i="6.01,151,1684825200"; d="scan'208";a="828253855" Received: from choongyo-mobl.gar.corp.intel.com (HELO [10.215.253.116]) ([10.215.253.116]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jun 2023 23:02:06 -0700 Message-ID: <20b1302a-a437-bd66-e7a4-0224875488f2@linux.intel.com> Date: Fri, 23 Jun 2023 14:02:04 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH net-next 3/6] net: phy: update in-band AN mode when changing interface by PHY driver Content-Language: en-US To: "Russell King (Oracle)" , Simon Horman Cc: Rajneesh Bhardwaj , David E Box , Hans de Goede , Mark Gross , Jose Abreu , Andrew Lunn , Heiner Kallweit , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , =?UTF-8?Q?Marek_Beh=c3=ban?= , Jean Delvare , Guenter Roeck , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Richard Cochran , Philipp Zabel , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Wong Vee Khee , Jon Hunter , Jesse Brandeburg , Revanth Kumar Uppala , Shenwei Wang , Andrey Konovalov , Jochen Henneberg , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, platform-driver-x86@vger.kernel.org, linux-hwmon@vger.kernel.org, bpf@vger.kernel.org, Voon Wei Feng , "Tan, Tee Min" , Michael Sit Wei Hong , Lai Peter Jun Ann References: <20230622041905.629430-1-yong.liang.choong@linux.intel.com> <20230622041905.629430-4-yong.liang.choong@linux.intel.com> From: Choong Yong Liang In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230622_230219_818953_22140847 X-CRM114-Status: GOOD ( 24.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Russell, Thank you for pointing that out. I will fix it and send out version 2. On 22/6/2023 11:06 pm, Russell King (Oracle) wrote: > On Thu, Jun 22, 2023 at 04:43:51PM +0200, Simon Horman wrote: >> On Thu, Jun 22, 2023 at 12:19:02PM +0800, Choong Yong Liang wrote: >>> From: "Tan, Tee Min" >>> >>> Add cur_link_an_mode into phy_device struct for PHY drivers to >>> communicate the in-band AN mode setting with phylink framework. >>> >>> As there is a mechanism in PHY drivers to switch the PHY interface >>> between SGMII and 2500BaseX according to link speed. In this case, >>> the in-band AN mode should be switching based on the PHY interface >>> as well, if the PHY interface has been changed/updated by PHY driver. >>> >>> For e.g., disable in-band AN in 2500BaseX mode, or enable in-band AN >>> back for SGMII mode (10/100/1000Mbps). >>> >>> Signed-off-by: Tan, Tee Min >>> Signed-off-by: Choong Yong Liang >> >> ... >> >>> diff --git a/include/linux/phy.h b/include/linux/phy.h >>> index 11c1e91563d4..c685b526e307 100644 >>> --- a/include/linux/phy.h >>> +++ b/include/linux/phy.h >>> @@ -756,6 +756,8 @@ struct phy_device { >>> /* MACsec management functions */ >>> const struct macsec_ops *macsec_ops; >>> #endif >>> + /* For communicate the AN mode setting with phylink framework. */ >>> + u8 cur_link_an_mode; >>> }; >> >> Hi Choong Yong Liang, >> >> Please consider adding cur_link_an_mode to the kernel doc >> for struct phy_device - which is above the definition of struct phy_device. > > This looks like it's grabbing something from phylink and stuffing it > into phylib. However, I have no idea, because I don't seem to have > received the original patches. I'm guessing the reason is: > > 2023-06-22 05:21:24 1qCBoy-0003ji-G9 H=mga03.intel.com > [134.134.136.65]:57703 I=[78.32.30.218]:25 > X=TLS1.2:ECDHE_SECP521R1__RSA_SHA512__AES_256_GCM:256 > F= rejected after DATA: unqualified > address not permitted: failing address in "Cc:" header is: Tan > > Which I suspect came from: > > Tan, Tee Min > > and someone doesn't realise that a "," in the display-name part of > an address *must* be quoted, otherwise "," is taken to be a separator > in the address list. > > Consequently, it has now become: > > Tan@web.codeaurora.org, Tee Min , > > It should have been: > > "Tan, Tee Min" > > with the double-quotes. > > Please do not review this series further, but instead, please can the > author repost it forthwith with correct conformant headers so that a > proper review can be undertaken by all? > > Thanks. > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel