From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 37C79C87FD1 for ; Tue, 5 Aug 2025 17:29:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ClanLuNyxHe0IoDRTYOhLN0nJpmbUXKeLzkGzTF5yy0=; b=pvmfW1oGUJYAlPM/p5kwBmzkgT xS7C08tGdwvqoVyDp55KJLHiwsfhylXy+mqXGQ/7midCsrh3g3j5dNSheNNsJIw/4q7r7zw0zvdc5 rFkD/RAn1dmggSQ0Ihprj4kwrXmntKAP2+DpzQ84AdE9Uo8BX5c6u66GIrljmtdA4KsNFQ2CZXvab 8eV5QR06yArQEj3VGYc5XpxGBOsl1zdQmnC4DaRX0P1ir1h79SNLDtHjsEuYQzzhYC0GNAptvU+Hq ieo2foFf+tlFaQHb73608SUNpzWQ33q93snVt9auZ6+6rM5fwIka/sb1Ob+PEhdHcICZbzoBHW1PD MjstGAJg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1ujLTh-0000000DR26-29Ho; Tue, 05 Aug 2025 17:29:33 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1ujL7y-0000000DNaS-2OVv for linux-arm-kernel@lists.infradead.org; Tue, 05 Aug 2025 17:07:07 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1B98F150C; Tue, 5 Aug 2025 10:06:58 -0700 (PDT) Received: from [10.1.197.43] (eglon.cambridge.arm.com [10.1.197.43]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D2A433F673; Tue, 5 Aug 2025 10:06:57 -0700 (PDT) Message-ID: <20b39d32-b50e-4ab7-a060-6d7221e9d893@arm.com> Date: Tue, 5 Aug 2025 18:06:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 08/36] ACPI / PPTT: Add a helper to fill a cpumask from a cache_id To: Jonathan Cameron Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Rob Herring , Ben Horgan , Rohit Mathew , Shanker Donthineni , Zeng Heng , Lecopzer Chen , Carl Worth , shameerali.kolothum.thodi@huawei.com, D Scott Phillips OS , lcherian@marvell.com, bobo.shaobowang@huawei.com, tan.shaopeng@fujitsu.com, baolin.wang@linux.alibaba.com, Jamie Iles , Xin Hao , peternewman@google.com, dfustini@baylibre.com, amitsinght@marvell.com, David Hildenbrand , Rex Nie , Dave Martin , Koba Ko , Sudeep Holla References: <20250711183648.30766-1-james.morse@arm.com> <20250711183648.30766-9-james.morse@arm.com> <20250716172442.000001d6@huawei.com> Content-Language: en-GB From: James Morse In-Reply-To: <20250716172442.000001d6@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250805_100706_755894_BC66111B X-CRM114-Status: GOOD ( 16.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Jonathan, On 16/07/2025 17:24, Jonathan Cameron wrote: > On Fri, 11 Jul 2025 18:36:20 +0000 > James Morse wrote: > >> MPAM identifies CPUs by the cache_id in the PPTT cache structure. >> >> The driver needs to know which CPUs are associated with the cache, >> the CPUs may not all be online, so cacheinfo does not have the >> information. >> >> Add a helper to pull this information out of the PPTT. >> diff --git a/drivers/acpi/pptt.c b/drivers/acpi/pptt.c >> index f53748a5df19..81f7ac18c023 100644 >> --- a/drivers/acpi/pptt.c >> +++ b/drivers/acpi/pptt.c >> @@ -985,3 +985,73 @@ int find_acpi_cache_level_from_id(u32 cache_id) >> +int acpi_pptt_get_cpumask_from_cache_id(u32 cache_id, cpumask_t *cpus) >> +{ >> + u32 acpi_cpu_id; >> + acpi_status status; >> + int level, cpu, num_levels; >> + struct acpi_pptt_cache *cache; >> + struct acpi_table_header *table; >> + struct acpi_pptt_cache_v1 *cache_v1; >> + struct acpi_pptt_processor *cpu_node; >> + >> + cpumask_clear(cpus); >> + >> + status = acpi_get_table(ACPI_SIG_PPTT, 0, &table); > Similar suggestions to previous patch apply here as well. Done! > >> + if (ACPI_FAILURE(status)) { >> + acpi_pptt_warn_missing(); >> + return -ENOENT; >> + } >> + >> + if (table->revision < 3) { >> + acpi_put_table(table); >> + return -ENOENT; >> + } >> + >> + /* >> + * If we found the cache first, we'd still need to walk from each cpu. >> + */ >> + for_each_possible_cpu(cpu) { >> + acpi_cpu_id = get_acpi_id_for_cpu(cpu); >> + cpu_node = acpi_find_processor_node(table, acpi_cpu_id); >> + if (!cpu_node) >> + break; >> + acpi_count_levels(table, cpu_node, &num_levels, NULL); >> + >> + /* Start at 1 for L1 */ >> + for (level = 1; level <= num_levels; level++) { >> + cache = acpi_find_cache_node(table, acpi_cpu_id, >> + ACPI_PPTT_CACHE_TYPE_UNIFIED, >> + level, &cpu_node); >> + if (!cache) >> + continue; >> + >> + cache_v1 = ACPI_ADD_PTR(struct acpi_pptt_cache_v1, >> + cache, >> + sizeof(struct acpi_pptt_cache)); >> + >> + if (cache->flags & ACPI_PPTT_CACHE_ID_VALID && >> + cache_v1->cache_id == cache_id) { >> + cpumask_set_cpu(cpu, cpus); >> + } > Unnecessary {} Fine to keep them if you add something else here later. The condition being broken over multiple lines de-rails my C parsing abilities... 'Fixed'. Thanks, James