From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 91242D0EE12 for ; Fri, 11 Oct 2024 16:59:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=iI7N4OmAYOmWK0C4nRDXxycd+i6Iyyi0uWNjLeMWscM=; b=ROv/hLzcsSQGgZZL1QnTMi8lYu 2eSgpAs5QHP+EXYxbjIQq1eNesOfUR3xE11m7E3yENMCZEhzbYVJOafO7wMLJKFaDpylVN5fj/rVV httqPUZntimGdWKOiaHdNV+XbvhF9EBCSC51RcSOmYrI7hlLt2pdDuMKr2LpocuWLMDO8pY9tjwWf y3D73XJnMM7Wpgb8Y7o0dhQW1LsQQKbYCcGfpteyuVTH2B1NljVfX5edWZ09ntbQKt9Oo0BdYsb99 C76vZFBTJqG7hTYc1ARu7lPb0isuTd0kvbayuAsZGVCBhstGfPt5VXK3AG6rKB9LgDzPzF/sErmNh 7cFXpiAg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1szIzN-0000000H26f-10xH; Fri, 11 Oct 2024 16:59:41 +0000 Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1szIxt-0000000H1rn-2v2W for linux-arm-kernel@lists.infradead.org; Fri, 11 Oct 2024 16:58:11 +0000 Received: by mail-pl1-x629.google.com with SMTP id d9443c01a7336-20bb610be6aso23537565ad.1 for ; Fri, 11 Oct 2024 09:58:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1728665888; x=1729270688; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=iI7N4OmAYOmWK0C4nRDXxycd+i6Iyyi0uWNjLeMWscM=; b=F5Oizav81tpnxPivyB3tGT5DBd29WgL7AOA8cr8/p33VJ9XvqJpu4ocaBtPd9Jg64S 2qTZ7PJHSTQZ8MobMgEhrPxePR36qgpUvLZrZRWih4icdfJSjVyKhJMoPmk1D5mTYXbQ cnuCJnhalatA+tZy9U0h2lya4q+5upw664ez0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728665888; x=1729270688; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=iI7N4OmAYOmWK0C4nRDXxycd+i6Iyyi0uWNjLeMWscM=; b=FHcGHWJTU31VL+T95P9lNmQmi5wpGhBjr8azIsWgF/pUGzrl8Y4ps0u3fjLwp4rwff vmTVCUnRiIIBSjbi54dsZhSODE5eOfPM2Db6unm0ekq5pasbJMZTKZ0rn+r3w3Qi75w6 od4uFUW4pZK13698omHGRZkeZyOP9rZPISQEoy4TcX+debYVOjetr288RajjJxLy9s/q oFBzMYWBaKJp4m2ALbXx1Ih/u9kZ7GWERbRSGmCWwXu+Pc/lwMYal+OAbHiDRhnXspoR ImT7owdfIS3H8esTllF4lA2CxIbPf7hRuaEjT/pRPOo0CHT/d3KI+Q0HZ9pL5so4GTi6 EQzw== X-Forwarded-Encrypted: i=1; AJvYcCWx8MrKkRi+WYfRtO7wugZ8SlUCrNFG57wfRUaQV9EFvMP2qSAbtDfDoNyBeP6ZG4UbZRytYRSbFq5osoYnrOgV@lists.infradead.org X-Gm-Message-State: AOJu0YwG5H1MzIGiZunKHNvoUDsdSUgWc8Nzwx97CkZYMPvppussPmHA t8aFgBzKO4KEd5AY+wv5UPtK9BHDP+3GTv+o/sfmNSip9fN5Izma1yjzyprZfA== X-Google-Smtp-Source: AGHT+IGHpGb9qnExHSXE7Ai0AnGih96kwF4dzI85pSkdicKXW+NsNxJ6qrjE0frtXPOoPLFdNokcuQ== X-Received: by 2002:a17:902:ec83:b0:20c:5404:ed69 with SMTP id d9443c01a7336-20ca167bbbbmr39073895ad.31.1728665888463; Fri, 11 Oct 2024 09:58:08 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20c8c345e46sm25233655ad.271.2024.10.11.09.58.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Oct 2024 09:58:07 -0700 (PDT) Message-ID: <20b6d922-439c-4280-8376-6e1d2397a30e@broadcom.com> Date: Fri, 11 Oct 2024 09:58:06 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] firmware: arm_scmi: Queue in scmi layer for mailbox implementation To: Cristian Marussi , Justin Chen Cc: arm-scmi@vger.kernel.org, sudeep.holla@arm.com, linux-arm-kernel@lists.infradead.org, peng.fan@nxp.com, bcm-kernel-feedback-list@broadcom.com References: <20241009192637.1090238-1-justin.chen@broadcom.com> Content-Language: en-US From: Florian Fainelli Autocrypt: addr=florian.fainelli@broadcom.com; keydata= xsBNBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAHNMEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tPsLB IQQQAQgAywUCZWl41AUJI+Jo+hcKAAG/SMv+fS3xUQWa0NryPuoRGjsA3SAUAAAAAAAWAAFr ZXktdXNhZ2UtbWFza0BwZ3AuY29tjDAUgAAAAAAgAAdwcmVmZXJyZWQtZW1haWwtZW5jb2Rp bmdAcGdwLmNvbXBncG1pbWUICwkIBwMCAQoFF4AAAAAZGGxkYXA6Ly9rZXlzLmJyb2FkY29t Lm5ldAUbAwAAAAMWAgEFHgEAAAAEFQgJChYhBNXZKpfnkVze1+R8aIExtcQpvGagAAoJEIEx tcQpvGagWPEH/2l0DNr9QkTwJUxOoP9wgHfmVhqc0ZlDsBFv91I3BbhGKI5UATbipKNqG13Z TsBrJHcrnCqnTRS+8n9/myOF0ng2A4YT0EJnayzHugXm+hrkO5O9UEPJ8a+0553VqyoFhHqA zjxj8fUu1px5cbb4R9G4UAySqyeLLeqnYLCKb4+GklGSBGsLMYvLmIDNYlkhMdnnzsSUAS61 WJYW6jjnzMwuKJ0ZHv7xZvSHyhIsFRiYiEs44kiYjbUUMcXor/uLEuTIazGrE3MahuGdjpT2 IOjoMiTsbMc0yfhHp6G/2E769oDXMVxCCbMVpA+LUtVIQEA+8Zr6mX0Yk4nDS7OiBlvOwE0E U8AbwQEIAKxr71oqe+0+MYCc7WafWEcpQHFUwvYLcdBoOnmJPxDwDRpvU5LhqSPvk/yJdh9k 4xUDQu3rm1qIW2I9Puk5n/Jz/lZsqGw8T13DKyu8eMcvaA/irm9lX9El27DPHy/0qsxmxVmU pu9y9S+BmaMb2CM9IuyxMWEl9ruWFS2jAWh/R8CrdnL6+zLk60R7XGzmSJqF09vYNlJ6Bdbs MWDXkYWWP5Ub1ZJGNJQ4qT7g8IN0qXxzLQsmz6tbgLMEHYBGx80bBF8AkdThd6SLhreCN7Uh IR/5NXGqotAZao2xlDpJLuOMQtoH9WVNuuxQQZHVd8if+yp6yRJ5DAmIUt5CCPcAEQEAAcLB gQQYAQIBKwUCU8AbwgUbDAAAAMBdIAQZAQgABgUCU8AbwQAKCRCTYAaomC8PVQ0VCACWk3n+ obFABEp5Rg6Qvspi9kWXcwCcfZV41OIYWhXMoc57ssjCand5noZi8bKg0bxw4qsg+9cNgZ3P N/DFWcNKcAT3Z2/4fTnJqdJS//YcEhlr8uGs+ZWFcqAPbteFCM4dGDRruo69IrHfyyQGx16s CcFlrN8vD066RKevFepb/ml7eYEdN5SRALyEdQMKeCSf3mectdoECEqdF/MWpfWIYQ1hEfdm C2Kztm+h3Nkt9ZQLqc3wsPJZmbD9T0c9Rphfypgw/SfTf2/CHoYVkKqwUIzI59itl5Lze+R5 wDByhWHx2Ud2R7SudmT9XK1e0x7W7a5z11Q6vrzuED5nQvkhAAoJEIExtcQpvGagugcIAJd5 EYe6KM6Y6RvI6TvHp+QgbU5dxvjqSiSvam0Ms3QrLidCtantcGT2Wz/2PlbZqkoJxMQc40rb fXa4xQSvJYj0GWpadrDJUvUu3LEsunDCxdWrmbmwGRKqZraV2oG7YEddmDqOe0Xm/NxeSobc MIlnaE6V0U8f5zNHB7Y46yJjjYT/Ds1TJo3pvwevDWPvv6rdBeV07D9s43frUS6xYd1uFxHC 7dZYWJjZmyUf5evr1W1gCgwLXG0PEi9n3qmz1lelQ8lSocmvxBKtMbX/OKhAfuP/iIwnTsww 95A2SaPiQZA51NywV8OFgsN0ITl2PlZ4Tp9hHERDe6nQCsNI/Us= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241011_095809_934268_936D4517 X-CRM114-Status: GOOD ( 12.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/11/24 06:43, Cristian Marussi wrote: > On Wed, Oct 09, 2024 at 12:26:37PM -0700, Justin Chen wrote: >> send_message() does not block in the MBOX implementation. This is >> because the mailbox layer has its own queue. However, this confuses >> the per xfer timeouts as they all start their timeout ticks in >> parallel. >> >> Consider a case where the xfer timeout is 30ms and a SCMI transaction >> takes 25ms. >> >> 0ms: Message #0 is queued in mailbox layer and sent out, then sits >> at scmi_wait_for_message_response() with a timeout of 30ms >> 1ms: Message #1 is queued in mailbox layer but not sent out yet. >> Since send_message() doesn't block, it also sits at >> scmi_wait_for_message_response() with a timeout of 30ms >> ... >> 25ms: Message #0 is completed, txdone is called and Message #1 is >> sent out >> 31ms: Message #1 times out since the count started at 1ms. Even >> though it has only been inflight for 6ms. >> >> Fixes: b53515fa177c ("firmware: arm_scmi: Make MBOX transport a standalone driver") >> Signed-off-by: Justin Chen >> --- >> >> Changes in v2: > > Hi Justin, > > thanks. > > A few nitpicks and one remark down below. Since there will likely be a v3, the Fixes tag should IMHO go way back to when this problem has been in existence, maybe: Fixes: 5c8a47a5a91d ("firmware: arm_scmi: Make scmi core independent of the transport type") -- Florian