From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 24A88C77B71 for ; Sat, 15 Apr 2023 04:11:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pzce6yFDy2mWvRqzNIwS8nC2sAI1kTtBGoRI9UA4dJs=; b=QNwtQwTm0bQYli tMhjM2ifLjaH9GsY6JVUSsY2Z4N1b0KN2/Dwej00DcI0R/v0jtGZFx7nqtUXPltuSTdgFOE22t1gX iM1lbwUo6j4n6Q4bMbrhYd1QkGAgnyzpGxEtiwGcr0W8baOq6j/IRg40l6CEO6cZSofEH22P9r0Yg Rxce8XLbIdFkkP6zK1qb3PF9+vJS7u39FvSIe/LpwRJziaHBa2pyXIqQfeBnDPYFK7tlpuX8pKnIv MgyO/JtY29hzXJySfspJkp2zpOgy61P0ArKlEHpuEfAXh0omRQSYB048zTa+vQb7kuKIBqJQVrMlm s0dDDSZ9eHO/kNlK3kWQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pnXF8-00BF2M-1H; Sat, 15 Apr 2023 04:10:30 +0000 Received: from lelv0142.ext.ti.com ([198.47.23.249]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pnXF5-00BF1Y-01 for linux-arm-kernel@lists.infradead.org; Sat, 15 Apr 2023 04:10:28 +0000 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 33F4AFo9100286; Fri, 14 Apr 2023 23:10:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1681531815; bh=dslg9uFniCIR+qxHa2T1VzYHiExAU99uAOFzP7FzTnY=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=DTfGExgzdYZHW6hety/9DkYd+Xmm4Wrmlj9eepWxPirxg1ZaDETJ0bF5ZfM7rUCl3 Ux2evJgXbdoOwVoHC3gAFojcPFD3+he1xZo9Eb2mZ6CQiRvtP1IF2/uodfVPOQEBhY UBYnrOIYZVdbOuc+jeC+ZgKcpk6D793d0eEtzNKQ= Received: from DLEE105.ent.ti.com (dlee105.ent.ti.com [157.170.170.35]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 33F4AFN9017891 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 14 Apr 2023 23:10:15 -0500 Received: from DLEE109.ent.ti.com (157.170.170.41) by DLEE105.ent.ti.com (157.170.170.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Fri, 14 Apr 2023 23:10:14 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE109.ent.ti.com (157.170.170.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Fri, 14 Apr 2023 23:10:14 -0500 Received: from [10.249.130.34] (ileaxei01-snat.itg.ti.com [10.180.69.5]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 33F4AAvL014091; Fri, 14 Apr 2023 23:10:11 -0500 Message-ID: <20bbb3f0-ac79-9d98-9c99-7062581b163f@ti.com> Date: Sat, 15 Apr 2023 09:40:10 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 1/2] arm64: dts: ti: k3-j7200: Fix physical address of pin Content-Language: en-US To: Nishanth Menon CC: , , , , , , , , , , , J Keerthi References: <20230414181434.2046049-1-u-kumar1@ti.com> <20230414181434.2046049-2-u-kumar1@ti.com> <20230414182638.watc555ihi2hgkuv@slinging> From: "Kumar, Udit" In-Reply-To: <20230414182638.watc555ihi2hgkuv@slinging> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230414_211027_128089_A4F1A5B2 X-CRM114-Status: GOOD ( 13.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Nishanth On 4/14/2023 11:56 PM, Nishanth Menon wrote: > On 23:44-20230414, Udit Kumar wrote: >> Fixes: 9ae21ac445e9 ("arm64: dts: ti: k3-j7200: Fix wakeup pinmux range") > In the wrong place. will address in v2 >> wkup_pmx splits into multiple regions. Like >> >> wkup_pmx0 -> 13 pins (WKUP_PADCONFIG 0 - 12) >> wkup_pmx1 -> 2 pins (WKUP_PADCONFIG 14 - 15) >> wkup_pmx2 -> 59 pins (WKUP_PADCONFIG 26 - 84) >> wkup_pmx3 -> 8 pins (WKUP_PADCONFIG 93 - 100) >> >> With this split, pin offset needs to be adjusted to >> match with new pmx for all pins above wkup_pmx0. >> >> Example a pin under wkup_pmx1 should start from 0 instead of >> old offset(0x38 WKUP_PADCONFIG 14 offset) >> >> J7200 Datasheet (Table 6-106, Section 6.4 Pin Multiplexing) : >> https://www.ti.com/lit/ds/symlink/dra821u.pdf > Drop the preceding whitespace. ok >> Signed-off-by: J Keerthi > Spell check name please, I think he usually goes with: > > Signed-off-by: Keerthy > > If this patch is from Keerthy, the patch should have a "From:" ok. git apply on original patch didn't worked , so i applied and committed. will fix in patch itself before posting, Keerthi as author >> Signed-off-by: Udit Kumar >> --- >> .../dts/ti/k3-j7200-common-proc-board.dts | 28 +++++++++---------- >> 1 file changed, 14 insertions(+), 14 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts >> index 0d39d6b8cc0c..63633e4f6c59 100644 >> --- a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts >> +++ b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts >> @@ -83,25 +83,25 @@ vdd_sd_dv: gpio-regulator-TLV71033 { >> &wkup_pmx2 { >> mcu_cpsw_pins_default: mcu-cpsw-pins-default { >> pinctrl-single,pins = < >> - J721E_WKUP_IOPAD(0x0068, PIN_OUTPUT, 0) /* MCU_RGMII1_TX_CTL */ >> - J721E_WKUP_IOPAD(0x006c, PIN_INPUT, 0) /* MCU_RGMII1_RX_CTL */ >> - J721E_WKUP_IOPAD(0x0070, PIN_OUTPUT, 0) /* MCU_RGMII1_TD3 */ >> - J721E_WKUP_IOPAD(0x0074, PIN_OUTPUT, 0) /* MCU_RGMII1_TD2 */ >> - J721E_WKUP_IOPAD(0x0078, PIN_OUTPUT, 0) /* MCU_RGMII1_TD1 */ >> - J721E_WKUP_IOPAD(0x007c, PIN_OUTPUT, 0) /* MCU_RGMII1_TD0 */ >> - J721E_WKUP_IOPAD(0x0088, PIN_INPUT, 0) /* MCU_RGMII1_RD3 */ >> - J721E_WKUP_IOPAD(0x008c, PIN_INPUT, 0) /* MCU_RGMII1_RD2 */ >> - J721E_WKUP_IOPAD(0x0090, PIN_INPUT, 0) /* MCU_RGMII1_RD1 */ >> - J721E_WKUP_IOPAD(0x0094, PIN_INPUT, 0) /* MCU_RGMII1_RD0 */ >> - J721E_WKUP_IOPAD(0x0080, PIN_OUTPUT, 0) /* MCU_RGMII1_TXC */ >> - J721E_WKUP_IOPAD(0x0084, PIN_INPUT, 0) /* MCU_RGMII1_RXC */ >> + J721E_WKUP_IOPAD(0x0000, PIN_OUTPUT, 0) /* MCU_RGMII1_TX_CTL */ >> + J721E_WKUP_IOPAD(0x0004, PIN_INPUT, 0) /* MCU_RGMII1_RX_CTL */ >> + J721E_WKUP_IOPAD(0x0008, PIN_OUTPUT, 0) /* MCU_RGMII1_TD3 */ >> + J721E_WKUP_IOPAD(0x000c, PIN_OUTPUT, 0) /* MCU_RGMII1_TD2 */ >> + J721E_WKUP_IOPAD(0x0010, PIN_OUTPUT, 0) /* MCU_RGMII1_TD1 */ >> + J721E_WKUP_IOPAD(0x0014, PIN_OUTPUT, 0) /* MCU_RGMII1_TD0 */ >> + J721E_WKUP_IOPAD(0x0020, PIN_INPUT, 0) /* MCU_RGMII1_RD3 */ >> + J721E_WKUP_IOPAD(0x0024, PIN_INPUT, 0) /* MCU_RGMII1_RD2 */ >> + J721E_WKUP_IOPAD(0x0028, PIN_INPUT, 0) /* MCU_RGMII1_RD1 */ >> + J721E_WKUP_IOPAD(0x002c, PIN_INPUT, 0) /* MCU_RGMII1_RD0 */ >> + J721E_WKUP_IOPAD(0x0018, PIN_OUTPUT, 0) /* MCU_RGMII1_TXC */ >> + J721E_WKUP_IOPAD(0x001c, PIN_INPUT, 0) /* MCU_RGMII1_RXC */ > nice catch. > >> >; >> }; >> >> mcu_mdio_pins_default: mcu-mdio1-pins-default { >> pinctrl-single,pins = < >> - J721E_WKUP_IOPAD(0x009c, PIN_OUTPUT, 0) /* (L1) MCU_MDIO0_MDC */ >> - J721E_WKUP_IOPAD(0x0098, PIN_INPUT, 0) /* (L4) MCU_MDIO0_MDIO */ >> + J721E_WKUP_IOPAD(0x0034, PIN_OUTPUT, 0) /* (L1) MCU_MDIO0_MDC */ >> + J721E_WKUP_IOPAD(0x0030, PIN_INPUT, 0) /* (L4) MCU_MDIO0_MDIO */ >> >; >> }; >> }; >> -- >> 2.34.1 >> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel