From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78FCDC4CECE for ; Mon, 14 Oct 2019 14:23:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4B8322067B for ; Mon, 14 Oct 2019 14:23:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XdExLYmK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4B8322067B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QjL/UQ9xw6WfaaibsegdySN8MJQAiT46yg1+4ELyCjk=; b=XdExLYmKPU9330rd9dIkAxjUX t7bQlEfkwSUOiazXJHT5wCBm0IohJYtndYfcg8vVHGRqp4luqR0NHFySIchwb84nleQfqKqhGuyAn 3hNrgzcT4n9gL51ubyhaFZ25MRRGtu1+XfoC/lB8WqhjL8TC5sgwK2CrEnwUwiHEsFc4Ps1YhGvpG GVC4WXIeTmwOEybN2m671fFPIR9tHWucZFgTF2ot825N/eqWRSlV2BpmZLGGwQNsXHqjwN5Nr7oXo f0+OPxHPjLdd1TaV+QncPoWZEFJTKrcGlyeZSrpVe6vgQ/kNhcVghUB76vzCgf2q64HAPpQSw7rKz AZ+IcZ7Kg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iK1FR-00061G-45; Mon, 14 Oct 2019 14:22:57 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iK1FN-00060R-B5; Mon, 14 Oct 2019 14:22:54 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A6A90337; Mon, 14 Oct 2019 07:22:52 -0700 (PDT) Received: from [10.1.197.57] (e110467-lin.cambridge.arm.com [10.1.197.57]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7DAA23F68E; Mon, 14 Oct 2019 07:22:50 -0700 (PDT) Subject: Re: [PATCH v3 4/7] iommu/mediatek: Delete the leaf in the tlb flush To: Yong Wu , Matthias Brugger , Joerg Roedel , Will Deacon References: <1571035101-4213-1-git-send-email-yong.wu@mediatek.com> <1571035101-4213-5-git-send-email-yong.wu@mediatek.com> From: Robin Murphy Message-ID: <20c74c20-864e-88af-3c58-ad3bb7600bcc@arm.com> Date: Mon, 14 Oct 2019 15:22:48 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <1571035101-4213-5-git-send-email-yong.wu@mediatek.com> Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191014_072253_427665_11FB3136 X-CRM114-Status: GOOD ( 17.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: youlin.pei@mediatek.com, anan.sun@mediatek.com, Nicolas Boichat , cui.zhang@mediatek.com, srv_heupstream@mediatek.com, chao.hao@mediatek.com, edison.hsieh@mediatek.com, linux-kernel@vger.kernel.org, Evan Green , Tomasz Figa , iommu@lists.linux-foundation.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 14/10/2019 07:38, Yong Wu wrote: > In our tlb range flush, we don't care the "leaf". Remove it to simplify > the code. no functional change. Presumably you don't care about the granule either? Robin. > Signed-off-by: Yong Wu > --- > drivers/iommu/mtk_iommu.c | 16 ++++------------ > 1 file changed, 4 insertions(+), 12 deletions(-) > > diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c > index 8712afc..19f936c 100644 > --- a/drivers/iommu/mtk_iommu.c > +++ b/drivers/iommu/mtk_iommu.c > @@ -174,8 +174,7 @@ static void mtk_iommu_tlb_flush_all(void *cookie) > } > > static void mtk_iommu_tlb_add_flush_nosync(unsigned long iova, size_t size, > - size_t granule, bool leaf, > - void *cookie) > + size_t granule, void *cookie) > { > struct mtk_iommu_data *data = cookie; > > @@ -219,14 +218,7 @@ static void mtk_iommu_tlb_sync(void *cookie) > static void mtk_iommu_tlb_flush_walk(unsigned long iova, size_t size, > size_t granule, void *cookie) > { > - mtk_iommu_tlb_add_flush_nosync(iova, size, granule, false, cookie); > - mtk_iommu_tlb_sync(cookie); > -} > - > -static void mtk_iommu_tlb_flush_leaf(unsigned long iova, size_t size, > - size_t granule, void *cookie) > -{ > - mtk_iommu_tlb_add_flush_nosync(iova, size, granule, true, cookie); > + mtk_iommu_tlb_add_flush_nosync(iova, size, granule, cookie); > mtk_iommu_tlb_sync(cookie); > } > > @@ -245,7 +237,7 @@ static void mtk_iommu_tlb_flush_page_nosync(struct iommu_iotlb_gather *gather, > static const struct iommu_flush_ops mtk_iommu_flush_ops = { > .tlb_flush_all = mtk_iommu_tlb_flush_all, > .tlb_flush_walk = mtk_iommu_tlb_flush_walk, > - .tlb_flush_leaf = mtk_iommu_tlb_flush_leaf, > + .tlb_flush_leaf = mtk_iommu_tlb_flush_walk, > .tlb_add_page = mtk_iommu_tlb_flush_page_nosync, > }; > > @@ -475,7 +467,7 @@ static void mtk_iommu_iotlb_sync(struct iommu_domain *domain, > spin_lock_irqsave(&dom->pgtlock, flags); > > mtk_iommu_tlb_add_flush_nosync(gather->start, length, gather->pgsize, > - false, data); > + data); > mtk_iommu_tlb_sync(data); > > if (!is_in_gather) > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel