From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_PASS,UNPARSEABLE_RELAY autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58D8FC43381 for ; Mon, 18 Mar 2019 15:03:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2AED520850 for ; Mon, 18 Mar 2019 15:03:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gOp9/3W4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2AED520850 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=K1cN9uD9tJyR365gbg2d7bq/pl50Kc1bJQrHYmqW/cs=; b=gOp9/3W4xRok9IedmuSsoa4Zz ndEBtSDyis+fqXLwVmpG0Rod7P87abHgS/wLpSSYIviLQEMOCHvbuiniaTVybjCTYR5np2nLSE3KD 7JQp6L/ML9rPfVi/hKf4cFscWRdFDGbRPtjzO998zF0hAPn+wWNkJ4u7Ryu7Ed0iSVkEjSv5bzxQv 1pN1GxKkVRkW5SE5BmjTIkFoSHxErTTqPu26gZLUckPbnR5zr5FTYE1G7wKeNTdxWMuAkaTwhiGjm UtP1fatY4TI9W+DaM/WnKLGODSAtYv6VunJ/vnYQiqeJPifSCpV4euq3EG2oQHrzU/zdpBV96Rfb6 HV5pAVmcw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h5tn4-0002hx-L3; Mon, 18 Mar 2019 15:03:02 +0000 Received: from bhuna.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e3e3]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h5tn0-0002h2-1G; Mon, 18 Mar 2019 15:03:00 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: gportay) with ESMTPSA id 1A77627C5A0 Subject: Re: [Bug] Rockchip crypto driver sometimes produces wrong ciphertext To: Ezequiel Garcia , Eric Biggers References: <875-5c8d7980-7-55088a00@27384378> From: Gael PORTAY Message-ID: <20c7a1d9-bc68-c5e5-d666-6db2d10b1f87@collabora.com> Date: Mon, 18 Mar 2019 11:03:04 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.3 MIME-Version: 1.0 In-Reply-To: <875-5c8d7980-7-55088a00@27384378> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190318_080258_366364_FC1AF140 X-CRM114-Status: GOOD ( 17.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tao Huang , Zain Wang , Heiko Stuebner , Arnd Bergmann , Ard Biesheuvel , Zhang Zhijie , linux-rockchip@lists.infradead.org, "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , Olof Johansson , linux-arm-kernel Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello, On 3/16/19 6:31 PM, Ezequiel Garcia wrote: > Adding my colleague Gael, who has been working on fixing this driver. > I have a couple of pending commits that may fix that issue. I will give it a try, and get back to you then. > On Friday, March 15, 2019 00:31 -03, Eric Biggers wrote: > >> Hi Zhang, >> >> On Mon, Jan 28, 2019 at 11:14:32AM +0800, Tao Huang wrote: >>> Hi Eric and Heiko: >>> >>>>> On Sat, 26 Jan 2019 at 22:05, Eric Biggers wrote: >>>>>> >>>>>> Hello, >>>>>> >>>>>> I don't know whether anyone is actually maintaining the Rockchip crypto driver >>>>>> in drivers/crypto/rockchip/, but it's failing the improved crypto tests >>>>>> that I currently have out for review: https://patchwork.kernel.org/cover/10778089/ >>> >>> Zhang Zhijie, engineer from Rockchip, will try to fix this software bug. >>> >>>>>> >>>>>> See the boot logs for RK3288 from the KernelCI job here: >>>>>> >>>>>> https://storage.kernelci.org/ardb/for-kernelci/v5.0-rc1-86-geaffe22db9d1/arm/multi_v7_defconfig/lab-collabora/boot-rk3288-rock2-square.txt >>>>>> https://storage.kernelci.org/ardb/for-kernelci/v5.0-rc1-86-geaffe22db9d1/arm/multi_v7_defconfig/lab-collabora/boot-rk3288-veyron-jaq.txt >>>>>> >>>>>> alg: skcipher: ecb-aes-rk encryption test failed (wrong result) on test vector 0, cfg=\"random: use_digest src_divs=[15.64%@+3258, 84.36%@+4059] dst_divs=[69.11%@+1796, 8.49%@+4027, 6.34%@+1, 16.6%@+4058] iv_offset=21\" >>>>>> alg: skcipher: cbc-aes-rk encryption test failed (wrong result) on test vector 0, cfg=\"random: may_sleep use_digest src_divs=[100.0%@alignmask+3993] dst_divs=[65.31%@alignmask+1435, 34.69%@+14]\" >>>>>> alg: skcipher: ecb-des-rk encryption test failed (wrong result) on test vector 0, cfg=\"random: may_sleep use_final src_divs=[ 66.52%@+11, 33.48%@+1519] dst_divs=[58.82%@+1, 19.43%@+4082, 21.75%@+8]\" >>>>>> alg: skcipher: cbc-des-rk encryption test failed (wrong result) on test vector 0, cfg=\"random: may_sleep use_finup src_divs=[100.0%@+3980] dst_divs=[60.4%@+3763, 23.9%@+4011, 16.87%@+4046]\" >>>>>> alg: skcipher: ecb-des3-ede-rk encryption test failed (wrong result) on test vector 0, cfg=\"random: may_sleep use_digest src_divs=[100.0%@+4] dst_divs=[47.25%@+19, 14.83%@+22, 37.92%@+31]\" >>>>>> alg: skcipher: cbc-des3-ede-rk encryption test failed (wrong result) on test vector 0, cfg=\"two even aligned splits\" >>>>>> >>>>>> In other words: the ecb-aes-rk, cbc-aes-rk, ecb-des-rk, cbc-des-rk, >>>>>> ecb-des3-ede-rk, and cbc-des3-ede-rk algorithms are failing because they produce >>>>>> the wrong ciphertext on some scatterlist layouts. >>>>>> >>>>>> You can reproduce by pulling from >>>>>> https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git >>>>>> branch "testmgr-improvements", unsetting CONFIG_CRYPTO_MANAGER_DISABLE_TESTS, >>>>>> setting CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y, rebooting and checking dmesg. >>>>>> >>>>>> Note that I don't have this hardware myself, so if it turns out that no one is >>>>>> interested in fixing this anytime soon I'll instead have to propose disabling >>>>>> these algorithms until they can be fixed. >>>>>> >>>>>> Thanks, >>>>>> >>>>>> - Eric >>>>> >> >> Thanks for the fixes, but I've improved the self-tests more, and there is >> another bug. See the KernelCI job here: >> >> https://kernelci.org/boot/all/job/ardb/branch/for-kernelci/kernel/v5.0-11071-g7d597cc3f0ef/ >> >> The self-tests are failing on the rk3288-rock2-square platform: >> >> alg: skcipher: cbc-aes-rk encryption test failed (wrong output IV) on test vector 0, cfg=\"in-place\" >> alg: skcipher: cbc-des-rk encryption test failed (wrong output IV) on test vector 0, cfg=\"in-place\" >> alg: skcipher: cbc-des3-ede-rk encryption test failed (wrong output IV) on test vector 0, cfg=\"in-place\" >> >> The issue is that the self-tests now verify that CBC implementations update the >> IV buffer to contain the next IV, aka the last ciphertext block. But the >> Rockchip crypto driver doesn't do that, so it needs to be fixed. >> >> This has always been a requirement for CBC implementations so that users can >> chain CBC requests. Unfortunately it was just never tested for... >> >> This should be easily reproducible using the mainline kernel. >> >> - Eric > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > Gael _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel