From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5EBCC2BA19 for ; Tue, 14 Apr 2020 10:03:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6FDA52072D for ; Tue, 14 Apr 2020 10:03:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rWM/WaLd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6FDA52072D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GJzTtyAVXrazrol+R7HLsqrI366B3U8OE/bzQP5DeaE=; b=rWM/WaLdoOaL45/dsSd0mqD7W 1u86eMs5joo2s1wPnnxGL9reie33C9UTnsROONsTtwasw2luMiaOimVZJ0sQVP+iOXGWtUDOxqIMo yLrkruAhcGJzAWamxTl4JTndZofQNK5czBXQui4sawQK3uVxgxr9Fnf/YC6wuRnUyEzj81CXN8D+u FS6dDTigMDUpA/HAaqSWEOVtLrF99C9k/umK3zooM4UielVCNs7ojAwdEUTq1bnP7kp02xeLqR2cS /o3xMvCi9ymquybV2hz8/DV3sdTG6qrSoG9ruHPCUbDpPQGJp453ZYx+7rD4wb8c35y+KoJMgkJO/ ezI0HJNsg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jOIPJ-0005bF-IP; Tue, 14 Apr 2020 10:03:05 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jOIPG-0005aA-M1; Tue, 14 Apr 2020 10:03:04 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3CE641FB; Tue, 14 Apr 2020 03:02:59 -0700 (PDT) Received: from [10.57.33.145] (unknown [10.57.33.145]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1E4E63F6C4; Tue, 14 Apr 2020 03:02:57 -0700 (PDT) Subject: Re: [PATCH] arm64: dts: rockchip: remove bus-width from mmc nodes in rk3308.dtsi To: Johan Jonker , heiko@sntech.de References: <20200413193652.1952-1-jbx6244@gmail.com> From: Robin Murphy Message-ID: <20c81edc-247c-8db0-2b3c-a6c2fcad6b4e@arm.com> Date: Tue, 14 Apr 2020 11:02:46 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200413193652.1952-1-jbx6244@gmail.com> Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200414_030302_761070_09A0337C X-CRM114-Status: GOOD ( 17.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, robh+dt@kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2020-04-13 8:36 pm, Johan Jonker wrote: > The 'bus-width' property for mmc nodes is defined both in > 'rk3308.dtsi' and 'rk3308-roc-cc.dts'. > In line with the other Rockchip SoCs define that in a user dts only, > so remove all entries from mmc nodes in 'rk3308.dtsi'. Judging by the pinctrl entries, these represent the number of pins provided by the SoC itself. Obviously boards need to override that if for some reason they don't wire up all the available data lines, but it seems backwards to have every board restate the SoC's default value. In fact, having brought it up, for this particular case the pinctrl setting is inherently related to the bus width, so having one without the other in either place doesn't smell right. Robin. > Signed-off-by: Johan Jonker > --- > arch/arm64/boot/dts/rockchip/rk3308.dtsi | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3308.dtsi b/arch/arm64/boot/dts/rockchip/rk3308.dtsi > index a9b98555d..130771ede 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3308.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3308.dtsi > @@ -587,7 +587,6 @@ > compatible = "rockchip,rk3308-dw-mshc", "rockchip,rk3288-dw-mshc"; > reg = <0x0 0xff480000 0x0 0x4000>; > interrupts = ; > - bus-width = <4>; > clocks = <&cru HCLK_SDMMC>, <&cru SCLK_SDMMC>, > <&cru SCLK_SDMMC_DRV>, <&cru SCLK_SDMMC_SAMPLE>; > clock-names = "biu", "ciu", "ciu-drive", "ciu-sample"; > @@ -602,7 +601,6 @@ > compatible = "rockchip,rk3308-dw-mshc", "rockchip,rk3288-dw-mshc"; > reg = <0x0 0xff490000 0x0 0x4000>; > interrupts = ; > - bus-width = <8>; > clocks = <&cru HCLK_EMMC>, <&cru SCLK_EMMC>, > <&cru SCLK_EMMC_DRV>, <&cru SCLK_EMMC_SAMPLE>; > clock-names = "biu", "ciu", "ciu-drive", "ciu-sample"; > @@ -615,7 +613,6 @@ > compatible = "rockchip,rk3308-dw-mshc", "rockchip,rk3288-dw-mshc"; > reg = <0x0 0xff4a0000 0x0 0x4000>; > interrupts = ; > - bus-width = <4>; > clocks = <&cru HCLK_SDIO>, <&cru SCLK_SDIO>, > <&cru SCLK_SDIO_DRV>, <&cru SCLK_SDIO_SAMPLE>; > clock-names = "biu", "ciu", "ciu-drive", "ciu-sample"; > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel