From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8968DC433F5 for ; Sat, 16 Apr 2022 19:39:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gG1MqIHL9ba4ycdh5TAC5NagVS9gqGie4b5owLCvFZ8=; b=en7mTylhPGCrFC +MAiumIaBheNoaw7Z1m9JZGnlsYqJPtPhFafx3/8HLUrMWlF3tVxII7ayaIb0nHJRqcDjtxUkxmjr 9XWHrVwHO2ezjw/rEf/G9e7gpUzhuzQZQpYL/41I58nR6nX94jgep/GAOO/4yXUL5lgMFCFp2s7UQ dx+fui0H3MhGsXDU87wmn1XTTNyKVP6B/yjM9fQOk5wxNMnuw4gBsG3w7PFoOD6mfGiGsgfVxb9lm 09rUuwOsyKrMD+ul3vdmVX6G/2Pwvp2GOZ//1xTEg+qh9sTxUqKVYDbqRylEjgWb/vmw9tpTPCoTJ xFsyCiBycRKs2zqdRLGg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nfoFQ-00DQp1-Iq; Sat, 16 Apr 2022 19:38:20 +0000 Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nfoFM-00DQnf-6a for linux-arm-kernel@lists.infradead.org; Sat, 16 Apr 2022 19:38:18 +0000 Received: by mail-pl1-x632.google.com with SMTP id j8so9514899pll.11 for ; Sat, 16 Apr 2022 12:38:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=mHBrU/6FS1PWEDbIq/XDCf3uhBAcZz4F8hxO2TMTiLI=; b=Pbrr9ivXtMgzgh6tAg+nn9bID05dXTfcaIe8ate3Wi8Ohs8t6EglfN2njyWlhjpTul tR1mINyTEbBvGPAhMgoSR1rQ4UPnlalDTu2iAw/L/tiSzzl7fdAIr6Ugqvo8ss6hD/dN UVJg69EABO+7PeFq4gKg21BZx3XELRHZSWcNQxJ/clehrKZCTOPln+2ntLmYORnGAqk+ 7z1X/i+gqjxIWPnenKvU7Hw4tOY/PXkSz0bb6LGJYDF+8QPHHUPQpAV8pBKDufq+9olJ hWtXkC0r0x0GPXCJ/l48JpaMEsFQoEwh0G4j/OD1VJdc562oeWatSqpIcm8HnRfH00Ot mY/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=mHBrU/6FS1PWEDbIq/XDCf3uhBAcZz4F8hxO2TMTiLI=; b=FmVAoSx9cv+S92jrgh3FZheZwH2alFfyaSkEPYpWoJ+XrMB+Yofp0TvGmE5E9tkoLn Wekcwpt/TbxOi6BfcrUJu2HK5NJAj+pnd6qJaMg9zqRwfivnjH4dQJATnx+4ok42DRk2 TzNC287snFdJakEBztg34X2E2tnPB5kfaueazxLSQ8uUWX37WqEIPz5jeSn+c0EBQR+F foGHA9uTziDNfIkhTg7jfE/EfyVdGxxjWQEbhW2StONnXp41BepnVxmihd1j0JJEiGL9 CsOSgTNlVIQMgEgKpqCm7vkw3nRGSUgZC4qz30tELrEdR2WTkdqhYsORxCk61J2viMXQ N7nQ== X-Gm-Message-State: AOAM531Fru51w0oxXKfTDnB2rqQyY79BH0M3ylQwCmv+3ZS/mEpYJyQT hY1Gd1GvDTfmkLO90fLyLnI= X-Google-Smtp-Source: ABdhPJwi0GT93WoZvWRnoJUYJPO0y7rxwdlEN9w4ihHyQC85Vlwb9bQPRJwhzRGybsPLuPs6G04O4Q== X-Received: by 2002:a17:902:d511:b0:158:3be2:6637 with SMTP id b17-20020a170902d51100b001583be26637mr4462063plg.107.1650137894204; Sat, 16 Apr 2022 12:38:14 -0700 (PDT) Received: from [192.168.1.3] (ip72-194-116-95.oc.oc.cox.net. [72.194.116.95]) by smtp.gmail.com with ESMTPSA id q12-20020a056a00084c00b0050a4bae6531sm3749099pfk.165.2022.04.16.12.38.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 16 Apr 2022 12:38:13 -0700 (PDT) Message-ID: <20e56bff-b456-3301-0594-dac917416a92@gmail.com> Date: Sat, 16 Apr 2022 12:38:09 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH net-next v4 05/18] net: dsa: mv88e6xxx: remove redundant check in mv88e6xxx_port_vlan() Content-Language: en-US To: Jakob Koschel , "David S. Miller" Cc: Jakub Kicinski , Paolo Abeni , Andrew Lunn , Vivien Didelot , Vladimir Oltean , Lars Povlsen , Steen Hegelund , UNGLinuxDriver@microchip.com, Ariel Elior , Manish Chopra , Edward Cree , Martin Habets , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Jiri Pirko , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Casper Andersson , Bjarni Jonasson , Christophe JAILLET , Arnd Bergmann , Colin Ian King , Eric Dumazet , Xu Wang , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, bpf@vger.kernel.org, Mike Rapoport , Brian Johannesmeyer , Cristiano Giuffrida , "Bos, H.J." , Vladimir Oltean References: <20220415122947.2754662-1-jakobkoschel@gmail.com> <20220415122947.2754662-6-jakobkoschel@gmail.com> From: Florian Fainelli In-Reply-To: <20220415122947.2754662-6-jakobkoschel@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220416_123816_323949_F65B1FA4 X-CRM114-Status: UNSURE ( 9.73 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 4/15/2022 5:29 AM, Jakob Koschel wrote: > From: Vladimir Oltean > > We know that "dev > dst->last_switch" in the "else" block. > In other words, that "dev - dst->last_switch" is > 0. > > dsa_port_bridge_num_get(dp) can be 0, but the check > "if (bridge_num + dst->last_switch != dev) continue", rewritten as > "if (bridge_num != dev - dst->last_switch) continue", aka > "if (bridge_num != something which cannot be 0) continue", > makes it redundant to have the extra "if (!bridge_num) continue" logic, > since a bridge_num of zero would have been skipped anyway. > > Signed-off-by: Vladimir Oltean > Signed-off-by: Jakob Koschel Reviewed-by: Florian Fainelli -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel