From: asutoshd@codeaurora.org
To: Stanley Chu <stanley.chu@mediatek.com>
Cc: linux-scsi@vger.kernel.org, martin.petersen@oracle.com,
andy.teng@mediatek.com, jejb@linux.ibm.com,
chun-hung.wu@mediatek.com, kuohong.wang@mediatek.com,
linux-kernel@vger.kernel.org, avri.altman@wdc.com,
cang@codeaurora.org, linux-mediatek@lists.infradead.org,
peter.wang@mediatek.com, alim.akhtar@samsung.com,
matthias.bgg@gmail.com, bvanassche@acm.org,
linux-arm-kernel@lists.infradead.org, beanhuo@micron.com
Subject: Re: [PATCH v1 2/3] scsi: ufs: add device reset history for vendor implementations
Date: Mon, 13 Jan 2020 10:59:03 -0800 [thread overview]
Message-ID: <20ed97a2333ff27d5901c373579f710a@codeaurora.org> (raw)
In-Reply-To: <1578147968-30938-3-git-send-email-stanley.chu@mediatek.com>
On 2020-01-04 06:26, Stanley Chu wrote:
> Device reset history shall be also added for vendor's device
> reset variant operation implementation.
>
> Cc: Alim Akhtar <alim.akhtar@samsung.com>
> Cc: Asutosh Das <asutoshd@codeaurora.org>
> Cc: Avri Altman <avri.altman@wdc.com>
> Cc: Bart Van Assche <bvanassche@acm.org>
> Cc: Bean Huo <beanhuo@micron.com>
> Cc: Can Guo <cang@codeaurora.org>
> Cc: Matthias Brugger <matthias.bgg@gmail.com>
> Signed-off-by: Stanley Chu <stanley.chu@mediatek.com>
> ---
> drivers/scsi/ufs/ufshcd.c | 5 +++--
> drivers/scsi/ufs/ufshcd.h | 6 +++++-
> 2 files changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index bae43da00bb6..29e3d50aabfb 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -4346,13 +4346,14 @@ static inline int
> ufshcd_disable_device_tx_lcc(struct ufs_hba *hba)
> return ufshcd_disable_tx_lcc(hba, true);
> }
>
> -static void ufshcd_update_reg_hist(struct ufs_err_reg_hist *reg_hist,
> - u32 reg)
> +void ufshcd_update_reg_hist(struct ufs_err_reg_hist *reg_hist,
> + u32 reg)
> {
> reg_hist->reg[reg_hist->pos] = reg;
> reg_hist->tstamp[reg_hist->pos] = ktime_get();
> reg_hist->pos = (reg_hist->pos + 1) % UFS_ERR_REG_HIST_LENGTH;
> }
> +EXPORT_SYMBOL_GPL(ufshcd_update_reg_hist);
>
> /**
> * ufshcd_link_startup - Initialize unipro link startup
> diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h
> index e05cafddc87b..de1be6a862b0 100644
> --- a/drivers/scsi/ufs/ufshcd.h
> +++ b/drivers/scsi/ufs/ufshcd.h
> @@ -805,6 +805,8 @@ int ufshcd_wait_for_register(struct ufs_hba *hba,
> u32 reg, u32 mask,
> u32 val, unsigned long interval_us,
> unsigned long timeout_ms, bool can_sleep);
> void ufshcd_parse_dev_ref_clk_freq(struct ufs_hba *hba, struct clk
> *refclk);
> +void ufshcd_update_reg_hist(struct ufs_err_reg_hist *reg_hist,
> + u32 reg);
>
> static inline void check_upiu_size(void)
> {
> @@ -1083,8 +1085,10 @@ static inline void
> ufshcd_vops_dbg_register_dump(struct ufs_hba *hba)
>
> static inline void ufshcd_vops_device_reset(struct ufs_hba *hba)
> {
> - if (hba->vops && hba->vops->device_reset)
> + if (hba->vops && hba->vops->device_reset) {
> hba->vops->device_reset(hba);
> + ufshcd_update_reg_hist(&hba->ufs_stats.dev_reset, 0);
> + }
> }
>
> extern struct ufs_pm_lvl_states ufs_pm_lvl_states[];
Reviewed-by: Asutosh Das <asutoshd@codeaurora.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-01-13 18:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-04 14:26 [PATCH v1 0/3] scsi: ufs: fix error history and complete device reset history Stanley Chu
2020-01-04 14:26 ` [PATCH v1 1/3] scsi: ufs: fix empty check of error history Stanley Chu
2020-01-06 17:34 ` asutoshd
2020-01-13 9:28 ` [EXT] " Bean Huo (beanhuo)
2020-01-13 9:43 ` Stanley Chu
2020-01-13 9:58 ` Bean Huo (beanhuo)
2020-01-04 14:26 ` [PATCH v1 2/3] scsi: ufs: add device reset history for vendor implementations Stanley Chu
2020-01-13 10:03 ` [EXT] " Bean Huo (beanhuo)
2020-01-13 18:59 ` asutoshd [this message]
2020-01-04 14:26 ` [PATCH v1 3/3] scsi: ufs: remove "errors" word in ufshcd_print_err_hist() Stanley Chu
2020-01-13 10:05 ` [EXT] " Bean Huo (beanhuo)
2020-01-11 7:17 ` [PATCH v1 0/3] scsi: ufs: fix error history and complete device reset history Stanley Chu
2020-01-16 3:00 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20ed97a2333ff27d5901c373579f710a@codeaurora.org \
--to=asutoshd@codeaurora.org \
--cc=alim.akhtar@samsung.com \
--cc=andy.teng@mediatek.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=chun-hung.wu@mediatek.com \
--cc=jejb@linux.ibm.com \
--cc=kuohong.wang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=matthias.bgg@gmail.com \
--cc=peter.wang@mediatek.com \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).