public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] ARM: fix multiplatform allmodcompile
Date: Tue, 11 Nov 2014 20:22:54 +0100	[thread overview]
Message-ID: <2103753.zV3InADiDC@wuerfel> (raw)
In-Reply-To: <1415641951-19753-1-git-send-email-linus.walleij@linaro.org>

On Monday 10 November 2014 18:52:31 Linus Walleij wrote:
> 
> "ARM: integrator: make the Integrator multiplatform"
> broke allmodconfig like this:
> 
> >> arch/arm/include/asm/cmpxchg.h:114:2: error: #error
> "SMP is not supported on this platform"
> (etc)
> 
> This is due to the fact that as we turned on multiplatform
> for the Integrator, this enabled a lot of non-applicable
> CPU's to be selected for its multiplatform images, due to
> a lot of "depends on ARCH_INTEGRATOR" restrictions in
> arch/arm/mm/Kconfig for the different ARM CPU types.
> 
> Fix this by restricting the CPU selections to respective
> multiplatform config, which now becomes a subset of the
> possible Integrator configurations, or alternatively the
> non-multiplatform config plus ARCH_INTEGRATOR, i.e.:
> 
> if (!ARCH_MULTIPLATFORM || ARCH_MULTI_Vx) &&
>    (ARCH_INTEGRATOR || ARCH_FOO ...)
> 
> Since the Integrator has been converted to multiplatform,
> this will often take the short form:
> 
> if (ARCH_MULTI_Vx && ARCH_INTEGRATOR)
> 
> If no other non-multiplatform platforms are elegible.
> 
> Reported-by: Build bot for Mark Brown <broonie@kernel.org>
> Reported-by: Kbuild test robot <fengguang.wu@intel.com>
> Suggested-by: Russell King <linux@arm.linux.org.uk>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

Applied to for-next branch, thanks!

I still have one small question:

> # ARMv7
> config CPU_V7
-       bool "Support ARM V7 processor" if ARCH_INTEGRATOR || MACH_REALVIEW_EB ||MACH_REALVIEW_PBX
>+       bool "Support ARM V7 processor" if (!ARCH_MULTIPLATFORM || ARCH_MULTI_V7) && (ARCH_INTEGRATOR || MACH_REALVIEW_EB || MACH_REALVIEW_PBX)
>        select CPU_32v6K
>        select CPU_32v7
>        select CPU_ABRT_EV7


This lists ARMv7 as available for integrator, but in your platform Kconfig
you have

config ARCH_INTEGRATOR
        bool "ARM Ltd. Integrator family" if (ARCH_MULTI_V4T || ARCH_MULTI_V5 || ARCH_MULTI_V6)

which doesn't list ARMv7. Do you know which one is correct? According the the
official documentation for Integrator, no ARMv7 tile exists, but the original
commit that added ARMv7 had 'depends on ARCH_INTEGRATOR', so I assume that
Catalin had at least one specimen at the time. Do any of those still exist?

	Arnd

      reply	other threads:[~2014-11-11 19:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-10 17:52 [PATCH v3] ARM: fix multiplatform allmodcompile Linus Walleij
2014-11-11 19:22 ` Arnd Bergmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2103753.zV3InADiDC@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox