From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D0B03C433FE for ; Fri, 4 Nov 2022 07:14:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eOJhMR8/po+3iV02ypfJr6Rz5k+Gv65FZRPuB5neNHs=; b=zNbDgvRQzA7xHT d6Y0QDeizNSPBae7v/jM//8WBO5p2RHhmy3RUdBx4a2zr3slxmS401MHvx/zWMVIgORs3MM0Ng1QA RjbH0+dFWURDy7sGvQR7y1ofXMUKF8UNi2iIvto5+Vc6Z0tPQhkMyGBOlxYDrqu0kOYFBR942oLFa Bk0zC3z2XLT+AGWNZw4M8E/IRlfS1RnssO4M9+7iwNXoL57w8zFqI/k4yXNIQRA/9AcVWQk0ZCwl3 jCZjwwOJ66LLZmqU0ivHKn7YEYILHRQK58xfne2fpdL7i45Gj8UM3RMYM7/YF2Pw5kOS1eX+AAoT5 Uy+m4/3OWV956ffi45Ag==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oqqtT-002jya-Ls; Fri, 04 Nov 2022 07:13:35 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oqqtO-002jxi-Ib for linux-arm-kernel@lists.infradead.org; Fri, 04 Nov 2022 07:13:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1667546010; x=1699082010; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=xd0p4wIkQZstjM24CW/U/ZPDBuX1FLgsH4lw2kNwVrI=; b=fBILL3Z0iLTI1pk06OJP+EhKDydnX8dRKFOCgYTdh1ewynJ3H/soFQZi KT1Bw2CFnlpUYuU3lKEi3ifEqIvq0Xk+zi+BNaoyVBYIy6/fgtYU1zXKr KFxFQVqPGgEJ5rFyll5DajLXvxa1vc9EG47jeShrPs3WISTVCIdSgKLeH eDJ0wsVheF7KfQ+P7uvkn1LaXdEHk2w/6yV+Xw1C/jF6TrXXwhD7NcK/x PZAuvNfOzkdova5RnrI363B+bhSxAm+unqp9698QSlBXBd0GC0AjtBzce E/OVsGGJgLQTsxaSIiOKvzyt9nMRLAz0jQEDdi1DrZbZ8EX7cOBpFapQo A==; X-IronPort-AV: E=Sophos;i="5.96,136,1665439200"; d="scan'208";a="27152653" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 04 Nov 2022 08:13:26 +0100 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Fri, 04 Nov 2022 08:13:26 +0100 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Fri, 04 Nov 2022 08:13:26 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1667546006; x=1699082006; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=xd0p4wIkQZstjM24CW/U/ZPDBuX1FLgsH4lw2kNwVrI=; b=T9Ai2bkWX9AUiKBnG4CwZhu4OMFH/+pA6EseudXmSxiM2g0Ins+jniCr Nr+++h9ihgyBnq/p13Afv/YDSKn9jojzXNvu2GFBISgIWwMICsLvprg4E gYt/uRmh0CWVOdIu1fZ7zIsOt1d1DNKFd/AwRExjAsSLowBGiNwPu/qOF Q0RtHf/2ydLgpOxYh/2qFuHDsG4L8Sc0iHn7246rKlHqHrDnb2Zu0JWXr wBOEE0oqmEETHmsvuMIgCa/kqdFNXwG104gB38T08ENEEtlI0nKrTSgYz 19236yIAdTYEOcKmj3jod20rN1ru1DvxGuPUGVAUZfH57yGej0l03ki2m Q==; X-IronPort-AV: E=Sophos;i="5.96,136,1665439200"; d="scan'208";a="27152652" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 04 Nov 2022 08:13:25 +0100 Received: from steina-w.localnet (unknown [10.123.53.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id A2D50280056; Fri, 4 Nov 2022 08:13:25 +0100 (CET) From: Alexander Stein To: Marek Vasut Cc: linux-arm-kernel@lists.infradead.org, Marek Vasut , Adam Ford , Fabio Estevam , Joakim Zhang , Krzysztof Kozlowski , Laurent Pinchart , Lucas Stach , Markus Niebel , NXP Linux Team , Paul Elder , Peng Fan , Pengutronix Kernel Team , Richard Zhu , Rob Herring , Sascha Hauer , Shawn Guo , Tim Harvey , devicetree@vger.kernel.org Subject: Re: [PATCH 1/3] arm64: dts: imx8mq: Swap SAI DMA order Date: Fri, 04 Nov 2022 08:13:22 +0100 Message-ID: <2105362.yKVeVyVuyW@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <20221103181920.95736-1-marex@denx.de> References: <20221103181920.95736-1-marex@denx.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221104_001331_033870_7175F3B6 X-CRM114-Status: GOOD ( 20.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Marek, thanks for this patch. Am Donnerstag, 3. November 2022, 19:19:18 CET schrieb Marek Vasut: > Swap the SAI dmas and dma-names to match the order documented in > Documentation/devicetree/bindings/sound/fsl-sai.txt This file has been converted to Documentation/devicetree/bindings/sound/ fsl,sai.yaml in commit d563336877b2 ("ASoC: dt-bindings: fsl,sai: Convert format to json-schema"). In next since next-20220816. In this schema the DMA order 'tx', 'rx' is only for fsl,vf610-sai, all other compatibles use 'rx', 'tx'. So this swap is not needed anymore. Same is for imx8mm and imx8mn. This change should have been made before schema conversion, so they would have been identical on all compatibles... Best regards, Alexander > using the following regex: > > " > s@\(dma[^=]\+= \)\([^,]\+\), \([^;]\+\);@\1\3, \2; > " > > No functional change. > > Signed-off-by: Marek Vasut > --- > Cc: Adam Ford > Cc: Alexander Stein > Cc: Fabio Estevam > Cc: Joakim Zhang > Cc: Krzysztof Kozlowski > Cc: Laurent Pinchart > Cc: Lucas Stach > Cc: Marek Vasut > Cc: Markus Niebel > Cc: NXP Linux Team > Cc: Paul Elder > Cc: Peng Fan > Cc: Pengutronix Kernel Team > Cc: Richard Zhu > Cc: Rob Herring > Cc: Sascha Hauer > Cc: Shawn Guo > Cc: Tim Harvey > Cc: devicetree@vger.kernel.org > To: linux-arm-kernel@lists.infradead.org > --- > arch/arm64/boot/dts/freescale/imx8mq.dtsi | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi > b/arch/arm64/boot/dts/freescale/imx8mq.dtsi index > c47e2d7235d3e..f00b040ca03e9 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > @@ -345,8 +345,8 @@ sai1: sai@30010000 { > <&clk IMX8MQ_CLK_SAI1_ROOT>, > <&clk IMX8MQ_CLK_DUMMY>, <&clk IMX8MQ_CLK_DUMMY>; > clock-names = "bus", "mclk1", "mclk2", "mclk3"; > - dmas = <&sdma2 8 24 0>, <&sdma1 9 24 0>; > - dma-names = "rx", "tx"; > + dmas = <&sdma1 9 24 0>, <&sdma2 8 24 0>; > + dma-names = "tx", "rx"; > status = "disabled"; > }; > > @@ -359,8 +359,8 @@ sai6: sai@30030000 { > <&clk IMX8MQ_CLK_SAI6_ROOT>, > <&clk IMX8MQ_CLK_DUMMY>, <&clk IMX8MQ_CLK_DUMMY>; > clock-names = "bus", "mclk1", "mclk2", "mclk3"; > - dmas = <&sdma2 4 24 0>, <&sdma2 5 24 0>; > - dma-names = "rx", "tx"; > + dmas = <&sdma2 5 24 0>, <&sdma2 4 24 0>; > + dma-names = "tx", "rx"; > status = "disabled"; > }; > > @@ -373,8 +373,8 @@ sai5: sai@30040000 { > <&clk IMX8MQ_CLK_SAI5_ROOT>, > <&clk IMX8MQ_CLK_DUMMY>, <&clk IMX8MQ_CLK_DUMMY>; > clock-names = "bus", "mclk1", "mclk2", "mclk3"; > - dmas = <&sdma2 2 24 0>, <&sdma2 3 24 0>; > - dma-names = "rx", "tx"; > + dmas = <&sdma2 3 24 0>, <&sdma2 2 24 0>; > + dma-names = "tx", "rx"; > status = "disabled"; > }; > > @@ -387,8 +387,8 @@ sai4: sai@30050000 { > <&clk IMX8MQ_CLK_SAI4_ROOT>, > <&clk IMX8MQ_CLK_DUMMY>, <&clk IMX8MQ_CLK_DUMMY>; > clock-names = "bus", "mclk1", "mclk2", "mclk3"; > - dmas = <&sdma2 0 24 0>, <&sdma2 1 24 0>; > - dma-names = "rx", "tx"; > + dmas = <&sdma2 1 24 0>, <&sdma2 0 24 0>; > + dma-names = "tx", "rx"; > status = "disabled"; > }; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel