From: stillcompiling@gmail.com (Joshua Clayton)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/9] rtc-2123: access the clock offset feature
Date: Tue, 17 Nov 2015 07:30:48 -0800 [thread overview]
Message-ID: <2107368.j5bIbb5cBF@jclayton-pc> (raw)
In-Reply-To: <cover.1446587705.git.stillcompiling@gmail.com>
On Wednesday, November 04, 2015 07:36:31 AM Joshua Clayton wrote:
> Greetings,
> This series was prompted by a need to adjust the clock rate of the rtc
> The existing code performs a soft reset during probe, which wipes out
> several registers including the offset register, which performs adjustments
> to the clock rate.
>
> The first several patches are cleanup, with patch 5 and 6 avoiding the reset,
> and patch 9 adding a nice sysfs interface to the clock offset.
>
> I know that this is not the only rtc to provide a programmable clock offset
> I wonder if this interface would make a good addition to the rtc api?
>
> The rtc chips I have seen list their clock adjustments in parts per million.
> I went with parts per billion, since the ppm listed was listed with a
> fractional component.
>
> Joshua Clayton (9):
> rtc-pcf2123: Document all registers and useful bits
> rtc-pcf2123: clean up reads from the chip
> rtc-pcf2123: clean up writes to the rtc chip
> rtc-pcf2123: replace magic numbers with defines
> rtc-pcf2123: put the chip reset into a function
> rtc-pcf2123: avoid resetting the clock if possible
> rtc-pcf2123: allow sysfs to accept hexidecimal
> rtc-pcf2123: use sysfs groups
> rtc-pcf2123: adjust the clock rate via sysfs
>
> drivers/rtc/rtc-pcf2123.c | 391 ++++++++++++++++++++++++++++++----------------
> 1 file changed, 257 insertions(+), 134 deletions(-)
>
>
Any comments on this series?
I realize now that I submitted it during the merge window, so it may have been overlooked.
--
~Joshua Clayton
next parent reply other threads:[~2015-11-17 15:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1446587705.git.stillcompiling@gmail.com>
2015-11-17 15:30 ` Joshua Clayton [this message]
2015-11-17 16:25 ` [PATCH 0/9] rtc-2123: access the clock offset feature Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2107368.j5bIbb5cBF@jclayton-pc \
--to=stillcompiling@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox