From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1E991C43334 for ; Sat, 23 Jul 2022 18:53:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VWmOUNbXlUpuNfMYdnbU0IRid1cv3H5G5Dadyqu5MCQ=; b=HbxeZ5mx4Gaw81 fEZCZAv2M4YbkP/BqhByZB4yfd7EALo/oFGvoOpDOfHXRshhrSFqX1Lhunct1kiZ8p8T34VYr+1TU wq4CJMsieVvt80n2o9blbCzw4H1gijRay5Cs5kMPkpZWvbkxaYt6evJIHDWNlA7sbC+zHM2Syio2F 31CKbdjYmBiPOPc3mR6yJWiBL2umwGEZhpU6tzFZdnxXUE+yIIOP9i8w7isqZ5P7BpMqrXVkm2+Z6 dskkceU3+ivHXmoiaQ3q+lP2s3j5ISh1JS/0Z4m4NKVr5U6dppGvaWY+wtJEVr84AXQrEApyad1c8 ElnA+vRo/y/nz3RozaJw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oFKEv-006Ubc-6n; Sat, 23 Jul 2022 18:52:37 +0000 Received: from mail.z3ntu.xyz ([128.199.32.197]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oFKEr-006UaX-Nu for linux-arm-kernel@lists.infradead.org; Sat, 23 Jul 2022 18:52:35 +0000 Received: from g550jk.localnet (31-151-115-246.dynamic.upc.nl [31.151.115.246]) by mail.z3ntu.xyz (Postfix) with ESMTPSA id C056CCC0D2; Sat, 23 Jul 2022 18:52:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=z3ntu.xyz; s=z3ntu; t=1658602351; bh=C6HfR4astpKVkxBzzghifT5f2iu0l3CRggJRt27F3sI=; h=From:To:Subject:Date:In-Reply-To:References; b=Yeef8N9HYRGCUE4aGbSBqyHGiE3+euacvgwD0JUG20kYUVpirGHEO5kFs8nzrs34I fnkY4SIslG8eOH6WNqw4yHBcO2gdDEz86P7ofnEbhadFK0iKJCFv1jaTTEjl4I/zNC 669+bFLeUS8B1d50hJnhuL+RWbSWTiuYJOShz1dk= From: Luca Weiss To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Russell King , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski Subject: Re: [PATCH v2 3/3] ARM: qcom_defconfig: order items with savedefconfig Date: Sat, 23 Jul 2022 20:52:31 +0200 Message-ID: <2109260.irdbgypaU6@g550jk> In-Reply-To: References: <20220721155356.248319-1-krzysztof.kozlowski@linaro.org> <2246145.ElGaqSPkdT@g550jk> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220723_115233_977167_0CA5F72E X-CRM114-Status: GOOD ( 18.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Samstag, 23. Juli 2022 20:44:08 CEST Krzysztof Kozlowski wrote: > On 23/07/2022 20:17, Luca Weiss wrote: > > On Samstag, 23. Juli 2022 19:36:17 CEST Krzysztof Kozlowski wrote: > >> On 23/07/2022 11:58, Luca Weiss wrote: > >>> See also > >>> https://lore.kernel.org/linux-arm-msm/20191104210943.101393-1-luca@z3ntu > >>> .x > >>> yz/ (never applied for some reason) > >> > >> Mentioned patch is incorrect so should not be applied - it removes at > >> least TMPFS which is not desired. I did not check other removed symbols. > > > > For this example: TMPFS is still enabled after this, it's selected by > > other > > options, like DRM or COMMON_CLK. > > I know, it does not matter. We had this case (with DEBUGFS and probably > others) and the decision was - user visible symbols must no be removed > by savedefconfig. So savedefconfig is "broken" (not doing the correct thing) then or what? Sounds like a topic for kconfig maintainers? > > > Imo not doing this just hides the brokeness as options wouldn't get > > selected anyways when you do "make qcom_defconfig". Savedefconfig > > afterwards just puts reality into the defconfig file. And yes, if some > > option gets lost then some dependency for it probably needs to get > > enabled as well and this should get fixed. > > But dependencies are no being enabled, because expectation is that all > user-visible options are selected by defconfig. > > > Best regards, > Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel