From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 279B9CFC52F for ; Mon, 14 Oct 2024 09:49:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JhS0VMYI9XOpx9JoepI+pwrrK44FiJe4a4k7H2QiOBU=; b=RpxqzgnExXurj/ifZnmShUjoW0 807V0AqGy3Mt42rHkuFOQJl2HOtkHdJfJWm/PynJsMCY3i9FA6dvWxs7wYAdnEmcv6RZFNqGX4Fpl JxeGdnH+SqCyZgRFvd/oFwcWkNJEqIaQguR5wShwFOwuN+I61PX+ZXV09ECjhZmfoJ/OFKsRCFaW9 wtAZ2Spj7iEYSwBfEW19s6yNAYlxDxTw8E87jo2DPzTwMMFEj/kIfQ4l8iBXuMLLTK8W4NLcu91NP ByTIEYWaDfXGpu3YSfZh6ANiUhJNzdPCxK9dLC7i4OGcBkcvRJ5i1z3mHNIDp40y0SVdK4QwM8qx0 JYkk4NQA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t0Hh8-00000004aw4-1lVg; Mon, 14 Oct 2024 09:48:54 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t0HLv-00000004W0e-2fFc; Mon, 14 Oct 2024 09:27:02 +0000 Received: from [IPV6:2405:201:2015:f873:55d7:c02e:b2eb:ee3f] (unknown [IPv6:2405:201:2015:f873:55d7:c02e:b2eb:ee3f]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 864998BE; Mon, 14 Oct 2024 11:25:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1728897916; bh=ayWkFEgHtTpVIQyAnV0gua3gCdIq0DRPPTgdC6M4laU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=QAu1f+KT/UlsfUQkjNRpDnS2at1ZOu5rFZSX1vIkGmP1vqVGEwA7BpbA3AIrpRPvZ 2RgBhkQj8f5u5diVXumv4S0eFz/4DJ/L1f5bk4rNT7W/9KrOLQbJbnxET+6J2PayTm bucPPn1pQRzFww18VCZ2bFg5HV0uILs/eK7mWPMI= Message-ID: <21116939-a868-4df2-8824-2b56f7ea68c1@ideasonboard.com> Date: Mon, 14 Oct 2024 14:56:51 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 0/2] staging: vchiq_arm: Fix missing refcount decrement in error path for fw_node To: Javier Carrasco , Florian Fainelli , Broadcom internal kernel review list , Greg Kroah-Hartman , Stefan Wahren , Laurent Pinchart Cc: linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20241014-vchiq_arm-of_node_put-v2-0-cafe0a4c2666@gmail.com> Content-Language: en-US From: Umang Jain In-Reply-To: <20241014-vchiq_arm-of_node_put-v2-0-cafe0a4c2666@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241014_022700_113175_90965484 X-CRM114-Status: GOOD ( 10.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Javier, Thank you for the patch On 14/10/24 2:26 pm, Javier Carrasco wrote: > This series refactors some useless goto instructions as a preparation > for the fix of a missing of_node_put() by means of the cleanup > attribute. > > Signed-off-by: Javier Carrasco For the series, Reviewed-by: Umang Jain > --- > Changes in v2: > - Refactor vchiq_probe() to remove goto instructions. > - Declare and initialize the node right before its first usage. > - Link to v1: https://lore.kernel.org/r/20241013-vchiq_arm-of_node_put-v1-1-f72b2a6e47d0@gmail.com > > --- > Javier Carrasco (2): > staging: vchiq_arm: refactor goto instructions in vchiq_probe() > staging: vchiq_arm: Fix missing refcount decrement in error path for fw_node > > .../vc04_services/interface/vchiq_arm/vchiq_arm.c | 19 +++++++------------ > 1 file changed, 7 insertions(+), 12 deletions(-) > --- > base-commit: d61a00525464bfc5fe92c6ad713350988e492b88 > change-id: 20241013-vchiq_arm-of_node_put-60a5eaaafd70 > > Best regards,