From mboxrd@z Thu Jan  1 00:00:00 1970
From: t.figa@samsung.com (Tomasz Figa)
Date: Mon, 12 Aug 2013 13:14:20 +0200
Subject: [PATCH V4 1/4] ARM: dts: exynos5420: add i2s controllers
In-Reply-To: <1376302070-1877-2-git-send-email-padma.v@samsung.com>
References: <1376302070-1877-1-git-send-email-padma.v@samsung.com>
 <1376302070-1877-2-git-send-email-padma.v@samsung.com>
Message-ID: <21180092.af8YMiXtjc@amdc1227>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

Hi Padmavathi, Andrew,

On Monday 12 of August 2013 15:37:47 Padmavathi Venna wrote:
> From: Andrew Bresticker <abrestic@chromium.org>
> 
> This adds device-tree bindings for the i2s controllers on Exynos 5420.
> 
> Signed-off-by: Andrew Bresticker <abrestic@chromium.org>
> Signed-off-by: Padmavathi Venna <padma.v@samsung.com>
> Reviewed-on: https://gerrit.chromium.org/gerrit/57713
> ---
>  arch/arm/boot/dts/exynos5420.dtsi |   32
> ++++++++++++++++++++++++++++++++ 1 files changed, 32 insertions(+), 0
> deletions(-)
> 
> diff --git a/arch/arm/boot/dts/exynos5420.dtsi
> b/arch/arm/boot/dts/exynos5420.dtsi index d2fdb87..8d57369 100644
> --- a/arch/arm/boot/dts/exynos5420.dtsi
> +++ b/arch/arm/boot/dts/exynos5420.dtsi
> @@ -242,4 +242,36 @@
>  		pinctrl-names = "default";
>  		pinctrl-0 = <&i2c3_bus>;
>  	};
> +
> +	i2s_0: i2s at 03830000 {
> +		compatible = "samsung,exynos5420-i2s";
> +		dmas = <&adma 0
> +			&adma 2
> +			&adma 1>;
> +		dma-names = "tx", "rx", "tx-sec";
> +		clocks = <&clock_audss EXYNOS_I2S_BUS>,
> +			<&clock_audss EXYNOS_I2S_BUS>,
> +			<&clock_audss EXYNOS_SCLK_I2S>;
> +		clock-names = "iis", "i2s_opclk0", "i2s_opclk1";
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&i2s0_bus>;
> +		status = "disabled";

If a node does not require any board-specific properties for the device to 
operate properly, there is no point in disabling it, just to add a single 
status property at board level.

> +	};
> +
> +	i2s_1: i2s at 12D60000 {
> +		clocks = <&clock 275>, <&clock 138>;
> +		clock-names = "iis", "i2s_opclk0";
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&i2s1_bus>;
> +		status = "disabled";

Ditto.

> +	};
> +
> +	i2s_2: i2s at 12D70000 {
> +		clocks = <&clock 276>, <&clock 139>;
> +		clock-names = "iis", "i2s_opclk0";
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&i2s2_bus>;
> +		status = "disabled";

Ditto.

Best regards,
Tomasz