From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E31A5C43334 for ; Wed, 20 Jul 2022 15:18:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Y9J6EmOvEWu+8g28fRrf5AiOg451JxRGxUr0tpJqc98=; b=rz4W048rn1Gkbm 0JgEF9GDTaeFDo0lE2jg9060kt3Q7t2W503RMHKMiyyKNtuI21DE4JFfzAgqPru1YIcEGiiZBI8Sd a9pFa4qo+z5hQavVI/+YObBZZYo7T75QuM6fsBWk227KgRVM0up7c+uKMcceBIqLw93Ufym5NrrVk CIn+94pvqW3n2Z4sp0OgTtBOezHRgOeCpLNjJNU4vIEWuSmMYQVakWmnwcjKiif13wCxhf0dgjuNX yhIPwGIt3DcYhxkJnDkiv1WFXco2yO0AQ5Hui+zIYvrffd+fliOUg6p/OdzEn1wVH0FmwoIaFoi+F WlhjWrWUrRRFd4GvP0qg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oEBRd-007RJq-Iu; Wed, 20 Jul 2022 15:17:01 +0000 Received: from mail-ed1-x530.google.com ([2a00:1450:4864:20::530]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oEBRa-007RId-HA for linux-arm-kernel@lists.infradead.org; Wed, 20 Jul 2022 15:16:59 +0000 Received: by mail-ed1-x530.google.com with SMTP id r6so24189241edd.7 for ; Wed, 20 Jul 2022 08:16:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QJ8tIkSKOkkmif94JS5g10IqhgFBHH/VewA9Hfwkj3E=; b=b4X+6ADLKOKGU2dRMxpMAKC3N5cJNdhZuChd7j2wol/p07g6hZLQvv0fP6dkQFrDJE 1msnYjyF+isxpx45RB3HO519e5SRnYQxLzBdVExGkZKLLUv8VgZ87GWtdoaVcWc7MPNL QEcwuKixToONXpvLxXpcrC+qfS1sM80UX8p/qONnzuIfPX8+cmUXyH1cjQ+Molyog0Uv A+NbrR9m6SfxZyEiH9FAIwOjqGN2hMbi/v+bpVJ6xhHAYLiHtbl5l1Ep6mrOFxzJfthj mVFyKNBNAV0cf3isYkAA1vyvSDf982Ij/tkgqqfXvOV8cVRU0QgjgjPweLNUy+Mbazoe jBJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QJ8tIkSKOkkmif94JS5g10IqhgFBHH/VewA9Hfwkj3E=; b=ylj0cJ+sBWl741scX7jO5eGblGMxklhXAt9SmwWBoXGzdsI1C4CXFPkc2yFvCLV1xq xG9M8FSkkWA7TUhH3NlUZxNLIOVxdvw3FGT7Ff99d4Nj/wupwQe0UNxjzENsbzaNlBs3 UJJ9TLtXSJsccQgs1YKqkC2CQLshtq4vB0i0yfVb5PKK92/3s2Mx0TuGLehiieyxAsai lLN97GleTbcLnJCqkMnk+3b3myjlCPLunAms3GZx91oSIP6u5IO9+xmbCKHCbFXJ8VoK brobdA6RReRgTDIaoz/5vqzZvtJyL20wTJWF6pVAMSgaG8w1n4xYt3c4AGUh/osvJZ1L YdxA== X-Gm-Message-State: AJIora+PO72dhsmMQlCuTTA9i0rGIUmxvLGjmunrmXY+Xh+MRB6E5UrC i8XiN1PZQRe+tH3XrJ8jPZk= X-Google-Smtp-Source: AGRyM1u1BR8LNjkBsnuM8bpiSzpEzLc1IbLV+0Vxsg+IzWfBDs4hk7RLLOpKehKwEO6sJHqOB4GkyA== X-Received: by 2002:a05:6402:51d1:b0:43a:8154:babe with SMTP id r17-20020a05640251d100b0043a8154babemr52351088edd.26.1658330215841; Wed, 20 Jul 2022 08:16:55 -0700 (PDT) Received: from jernej-laptop.localnet (86-58-13-89.dynamic.telemach.net. [86.58.13.89]) by smtp.gmail.com with ESMTPSA id js1-20020a170906ca8100b00718d18a1860sm7942350ejb.61.2022.07.20.08.16.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Jul 2022 08:16:55 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: wens@csie.org, Samuel Holland Cc: mturquette@baylibre.com, sboyd@kernel.org, andre.przywara@arm.com, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: sunxi-ng: Fix H6 RTC clock definition Date: Wed, 20 Jul 2022 17:16:54 +0200 Message-ID: <2118699.Icojqenx9y@jernej-laptop> In-Reply-To: References: <20220719183725.2605141-1-jernej.skrabec@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220720_081658_624635_0CF66E88 X-CRM114-Status: GOOD ( 18.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne sreda, 20. julij 2022 ob 02:21:29 CEST je Samuel Holland napisal(a): > On 7/19/22 1:37 PM, Jernej Skrabec wrote: > > While RTC clock was added in H616 ccu_common list, it was not in H6 > > list. That caused invalid pointer dereference like this: > > > > Unable to handle kernel NULL pointer dereference at virtual address > > 000000000000020c> > > Mem abort info: > > ESR = 0x96000004 > > EC = 0x25: DABT (current EL), IL = 32 bits > > SET = 0, FnV = 0 > > EA = 0, S1PTW = 0 > > FSC = 0x04: level 0 translation fault > > > > Data abort info: > > ISV = 0, ISS = 0x00000004 > > CM = 0, WnR = 0 > > > > user pgtable: 4k pages, 48-bit VAs, pgdp=000000004d574000 > > [000000000000020c] pgd=0000000000000000, p4d=0000000000000000 > > Internal error: Oops: 96000004 [#1] PREEMPT SMP > > CPU: 3 PID: 339 Comm: cat Tainted: G B 5.18.0-rc1+ #1352 > > Hardware name: Tanix TX6 (DT) > > pstate: 00000005 (nzcv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--) > > pc : ccu_gate_is_enabled+0x48/0x74 > > lr : ccu_gate_is_enabled+0x40/0x74 > > sp : ffff80000c0b76d0 > > x29: ffff80000c0b76d0 x28: 00000000016e3600 x27: 0000000000000000 > > x26: 0000000000000000 x25: 0000000000000002 x24: ffff00000952fe08 > > x23: ffff800009611400 x22: ffff00000952fe79 x21: 0000000000000000 > > x20: 0000000000000001 x19: ffff80000aad6f08 x18: 0000000000000000 > > x17: 2d2d2d2d2d2d2d2d x16: 2d2d2d2d2d2d2d2d x15: 2d2d2d2d2d2d2d2d > > x14: 0000000000000000 x13: 00000000f2f2f2f2 x12: ffff700001816e89 > > x11: 1ffff00001816e88 x10: ffff700001816e88 x9 : dfff800000000000 > > x8 : ffff80000c0b7447 x7 : 0000000000000001 x6 : ffff700001816e88 > > x5 : ffff80000c0b7440 x4 : 0000000000000001 x3 : ffff800008935c50 > > x2 : dfff800000000000 x1 : 0000000000000000 x0 : 000000000000020c > > > > Call trace: > > ccu_gate_is_enabled+0x48/0x74 > > clk_core_is_enabled+0x7c/0x1c0 > > clk_summary_show_subtree+0x1dc/0x334 > > clk_summary_show_subtree+0x250/0x334 > > clk_summary_show_subtree+0x250/0x334 > > clk_summary_show_subtree+0x250/0x334 > > clk_summary_show_subtree+0x250/0x334 > > clk_summary_show+0x90/0xdc > > seq_read_iter+0x248/0x6d4 > > seq_read+0x17c/0x1fc > > full_proxy_read+0x90/0xf0 > > vfs_read+0xdc/0x28c > > ksys_read+0xc8/0x174 > > __arm64_sys_read+0x44/0x5c > > invoke_syscall+0x60/0x190 > > el0_svc_common.constprop.0+0x7c/0x160 > > do_el0_svc+0x38/0xa0 > > el0_svc+0x68/0x160 > > el0t_64_sync_handler+0x10c/0x140 > > el0t_64_sync+0x18c/0x190 > > > > Code: d1006260 97e5c981 785e8260 8b0002a0 (b9400000) > > ---[ end trace 0000000000000000 ]--- > > > > Fix that by adding rtc clock to H6 ccu_common list too. > > > > Fixes: 38d321b61bda ("clk: sunxi-ng: h6-r: Add RTC gate clock") > > Signed-off-by: Jernej Skrabec > > Reviewed-by: Samuel Holland > > This bug also got fixed in passing by e1c51d31befc ("clk: sunxi-ng: > Deduplicate ccu_clks arrays"), but that won't land until 5.20. Argh, good catch. I will send your patch as fix then, otherwise there will be issues during merging. Best regards, Jernej > > Regards, > Samuel > > > --- > > > > drivers/clk/sunxi-ng/ccu-sun50i-h6-r.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/clk/sunxi-ng/ccu-sun50i-h6-r.c > > b/drivers/clk/sunxi-ng/ccu-sun50i-h6-r.c index 29a8c710ae06..b7962e5149a5 > > 100644 > > --- a/drivers/clk/sunxi-ng/ccu-sun50i-h6-r.c > > +++ b/drivers/clk/sunxi-ng/ccu-sun50i-h6-r.c > > @@ -138,6 +138,7 @@ static struct ccu_common *sun50i_h6_r_ccu_clks[] = { > > > > &r_apb2_rsb_clk.common, > > &r_apb1_ir_clk.common, > > &r_apb1_w1_clk.common, > > > > + &r_apb1_rtc_clk.common, > > > > &ir_clk.common, > > &w1_clk.common, > > > > }; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel