From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BB3ADC433FE for ; Tue, 15 Nov 2022 21:32:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=O/Gz7TFPNihPw5J4S/Q308yEhykpkhWNK7C/oXhLYhk=; b=gWLH6ql3fZ82GO 8/fGymvfgvRYE7dRgikKwfaO/6vOt8M34Zh0bc03qFN1fdDUuRxVtHPR9D/RXBqXc2plCTP9Y5xY1 ElOVSep5HRru90POVhX8AnpBVrjjlFZ2jw79QRpCBtd5LTQsGglWreyN7WqqmB48Ay4GpIK5RIB1n CINgQP2mnZNk+HtYLZSCQrorgDtvFP8dn8k+kCdfr6loGtSZzsu1JogKjVJ+1TYX45sOlu1VEct2n MenrxH7ZMNrboVnRIDYNUo6qmzaSh9GVurFq3Tps/++dDYLYucm11L+ZFJoiNVT+OzJ9bbDJ21pnL QBlfFf6deGyHajzHzfeg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ov3Vw-00F3YR-Au; Tue, 15 Nov 2022 21:30:41 +0000 Received: from mail-ej1-x629.google.com ([2a00:1450:4864:20::629]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ov3Vp-00F3VO-Lo for linux-arm-kernel@lists.infradead.org; Tue, 15 Nov 2022 21:30:35 +0000 Received: by mail-ej1-x629.google.com with SMTP id n20so18824911ejh.0 for ; Tue, 15 Nov 2022 13:30:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3YMB5wqa41Qx7Nhpc1b1K/YGC00PDJRyqPvnVv8h9bw=; b=H94SosSAInfkcwKBQIK27bslSv2Xdm3jxgjp2d0WXHIgaKTzQ9TBMGGEa7GtKyCQ2l DGVvIvHWBlOMW6FH0t/HLwSfByqktPEwJqsL3IWDUyYKdj5fGOEOWwVtBF7jK9aPrijX dB3RtYXmZzjxTkp/qw09Se8fHdUGBVsBLKyb63g5nBBn985rwqs9UqKOc0XZePKm21JZ yW2kFLoD5UuixPn8zx1i4wkxkOnkHqkzl7OJtkMYImQWsIGNBUwRX3mg7Qcz6crVQ3wQ WHNas3JTSMVD0bYDCEOpHwDtwkGfwe2hsNXlJWAD6i/i/NjD8DSxwR1+Pb6NRDfAOXPg vlEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3YMB5wqa41Qx7Nhpc1b1K/YGC00PDJRyqPvnVv8h9bw=; b=0wYaMpsTMpqEILtfjukZ6dQDhc2bWUxzqFIwpYJ/+J8N6oD1NxWd5/88TYPTHMRBwD n0dIym9c4mq+HLXEzUH2gD6t8ww3HPaxfcmIPZh2q2aV4nl90Y3K6k680cX8M7PqQ4iy EHFFDRGQhjohIroKaFbadwYDxCiEbkx/mG8kS/+y4sVG0AD7YFLarN6FdBe32M//5tKK t3m+S0ORUItBOwvyo9ay7Fh8FkgaBxy/+2dun9wWwJeZlGc89RVyUnd6Gko5OGlUuQWP I/SaTAP5xp7gqzcyd2yqTJQ6uP323+UdCBn7k3uoz8Pf0nbwIcVhVdXIQifGPfTGxyHw RHZw== X-Gm-Message-State: ANoB5pkYY45Wl9VD48AjttkZu7Ewer/IwNLdvYEryyUgIrjnRO9Jk3W1 NAsdRtnZXw3cEGnusfz+u8Y= X-Google-Smtp-Source: AA0mqf5NuFVrNYRrXLO9HcnMljXOMrLrHDjFWROyEYkpFGTdhpCcqTY3MCd3RNI/6kfbaaZPOzEplQ== X-Received: by 2002:a17:906:3a55:b0:78d:f2d8:4623 with SMTP id a21-20020a1709063a5500b0078df2d84623mr15863994ejf.274.1668547828479; Tue, 15 Nov 2022 13:30:28 -0800 (PST) Received: from jernej-laptop.localnet (82-149-19-102.dynamic.telemach.net. [82.149.19.102]) by smtp.gmail.com with ESMTPSA id a2-20020aa7d742000000b004623028c594sm6639814eds.49.2022.11.15.13.30.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Nov 2022 13:30:27 -0800 (PST) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Samuel Holland , Hans Verkuil , Chen-Yu Tsai Cc: Chen-Yu Tsai , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] media: dt-bindings: allwinner: h6-vpu-g2: Add IOMMU reference property Date: Tue, 15 Nov 2022 22:30:26 +0100 Message-ID: <2121144.irdbgypaU6@jernej-laptop> In-Reply-To: <20221115090644.3602573-2-wenst@chromium.org> References: <20221115090644.3602573-1-wenst@chromium.org> <20221115090644.3602573-2-wenst@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221115_133033_763393_2152FE28 X-CRM114-Status: GOOD ( 19.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne torek, 15. november 2022 ob 10:06:43 CET je Chen-Yu Tsai napisal(a): > The Hantro G2 video decoder block sits behind an IOMMU. The device tree > binding needs a property to reference it. Without a reference for the > implementation to properly configure the IOMMU, it will fault and cause > the video decoder to fail. Note, Hantro G2 can happily work without IOMMU, if it is disabled for whole system, like disabling driver in kernel config. In such cases, it uses CMA. Anyway, it's true that there should be proper reference in DT and bindings, so: Acked-by: Jernej Skrabec Best regards, Jernej > > Add an "iommus" property for referring to the IOMMU port. The master ID > in the example is taken from the IOMMU fault error message on Linux, > and the number seems to match the order in the user manual's IOMMU > diagram. > > Fixes: fd6be12716c4 ("media: dt-bindings: allwinner: document H6 Hantro G2 > binding") Signed-off-by: Chen-Yu Tsai > --- > .../bindings/media/allwinner,sun50i-h6-vpu-g2.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git > a/Documentation/devicetree/bindings/media/allwinner,sun50i-h6-vpu-g2.yaml > b/Documentation/devicetree/bindings/media/allwinner,sun50i-h6-vpu-g2.yaml > index 24d7bf21499e..9d44236f2deb 100644 > --- > a/Documentation/devicetree/bindings/media/allwinner,sun50i-h6-vpu-g2.yaml > +++ > b/Documentation/devicetree/bindings/media/allwinner,sun50i-h6-vpu-g2.yaml > @@ -36,6 +36,9 @@ properties: > resets: > maxItems: 1 > > + iommus: > + maxItems: 1 > + > required: > - compatible > - reg > @@ -43,6 +46,7 @@ required: > - clocks > - clock-names > - resets > + - iommus > > additionalProperties: false > > @@ -59,6 +63,7 @@ examples: > clocks = <&ccu CLK_BUS_VP9>, <&ccu CLK_VP9>; > clock-names = "bus", "mod"; > resets = <&ccu RST_BUS_VP9>; > + iommus = <&iommu 5>; > }; > > ... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel