public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: alexanders83@web.de (Alexander Stein)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pinctrl/at91: convert driver to use gpiolib irqchip
Date: Wed, 23 Apr 2014 07:57:56 +0200	[thread overview]
Message-ID: <2125824.Uoi7hIqf8o@ws-stein> (raw)
In-Reply-To: <CACRpkdYsPPRkht9+nTLHHQdzmej9sMpdFLqyy37YjEtYePB+mw@mail.gmail.com>

On Tuesday 22 April 2014 23:39:38, Linus Walleij wrote:
> On Tue, Apr 15, 2014 at 10:09 PM, Alexander Stein <alexanders83@web.de> wrote:
> 
> > This converts the AT91 pin control driver to register its
> > chained irq handler and irqchip using the helpers in the
> > gpiolib core.
> >
> > Signed-off-by: Alexander Stein <alexanders83@web.de>
> 
> Part of the large attempt to pull all these local hacks into the
> gpiolib irqchip helpers so patch applied. Any further quarrels
> can be solved on top of this in the *generic* code.
> 
> I changed this:
> 
> > +static void gpio_orq_ack(struct irq_data *d)
> > +{
> > +       /* the interrupt is already cleared before by reading ISR */
> > +}
> > +
> >  static unsigned int gpio_irq_startup(struct irq_data *d)
> >  {
> >         struct at91_gpio_chip *at91_gpio = irq_data_get_irq_chip_data(d);
> > @@ -1434,6 +1420,7 @@ void at91_pinctrl_gpio_resume(void)
> >
> >  static struct irq_chip gpio_irqchip = {
> >         .name           = "GPIO",
> > +       .irq_ack        = gpio_orq_ack,
> 
> orq? I didn't get it so changed to irq when applying.

Yep, that was a typo. Thanks for noticing.

Regards,
Alexander

      reply	other threads:[~2014-04-23  5:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-15 20:09 [PATCH] pinctrl/at91: convert driver to use gpiolib irqchip Alexander Stein
2014-04-22 21:39 ` Linus Walleij
2014-04-23  5:57   ` Alexander Stein [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2125824.Uoi7hIqf8o@ws-stein \
    --to=alexanders83@web.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox