[PATCH 10/21] ARM: MM: Add DT binding for Feroceon L2 cache

Sudeep Holla
2014-02-07T19:12:45Z

On 07/02/14 18:21, Jason Gunthorpe wrote:
> On Fri, Feb 07, 2014 at 02:48:26PM +0000, Sudeep Holla wrote:
>> On 06/02/14 23:42, Andrew Lunn wrote:
>
>> Looks more like a software configuration for me unless I am missing
>> something.
>
> There is precedence for this, see
> Documentation/devicetree/bindings/arm/l2cc.txt
>
> Though the feorceon name should match 'wt-override'
>

Thanks for pointing out, may be its good to add reference to l2cc binding if its
applicable.

Do we need both wt-override and writethrough ?

>> It should not be here IMO if its pure software construct, may be you
>> can use already existing cachepolicy kernel parameter instead.
>
> cachepolicy is already doing something very different, it would not be
> appropriate to use it for this.
>

Yes I suspected that by a quick inspection at the code using it, but thought of
checking instead.

Regards,
Sudeep