From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org,
Fabio Estevam <festevam@denx.de>
Subject: Re: [PATCH] arm64: dts: tqma8mqml: Include phy-imx8-pcie.h header
Date: Fri, 09 Sep 2022 16:08:42 +0200 [thread overview]
Message-ID: <2128443.Mh6RI2rZIc@steina-w> (raw)
In-Reply-To: <20220909135150.4063471-1-festevam@gmail.com>
Hello Fabio,
thanks for the patch.
Am Freitag, 9. September 2022, 15:51:50 CEST schrieb Fabio Estevam:
> From: Fabio Estevam <festevam@denx.de>
>
> imx8mm-tqma8mqml.dtsi has PCIe support, so it should include
> <dt-bindings/phy/phy-imx8-pcie.h>.
>
> Otherwise, there are build errors when this SoM dtsi is included
> on customers' carrier boards.
>
> Fixes: 1d84283101fc ("arm64: dts: tqma8mqml: add PCIe support")
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
> arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml.dtsi index
> 16ee9b5179e6..f649dfacb4b6 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml.dtsi
> @@ -3,6 +3,7 @@
> * Copyright 2020-2021 TQ-Systems GmbH
> */
>
> +#include <dt-bindings/phy/phy-imx8-pcie.h>
> #include "imx8mm.dtsi"
>
> / {
Does it make sense to remove this include from the board then? It's not needed
then anymore. Either way:
Reviewed-by: Alexander Stein <alexander.stein@ew.tq-group.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-09-09 14:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-09 13:51 [PATCH] arm64: dts: tqma8mqml: Include phy-imx8-pcie.h header Fabio Estevam
2022-09-09 14:08 ` Alexander Stein [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2128443.Mh6RI2rZIc@steina-w \
--to=alexander.stein@ew.tq-group.com \
--cc=festevam@denx.de \
--cc=festevam@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox