From: "Heiko Stübner" <heiko@sntech.de>
To: "Vinod Koul" <vkoul@kernel.org>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-phy@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, kernel@pengutronix.de
Subject: Re: [PATCH 21/31] phy: rockchip: phy-rockchip-inno-hdmi: Convert to platform remove callback returning void
Date: Tue, 07 Mar 2023 13:02:37 +0100 [thread overview]
Message-ID: <2144678.Mh6RI2rZIc@diego> (raw)
In-Reply-To: <20230307115900.2293120-22-u.kleine-koenig@pengutronix.de>
Am Dienstag, 7. März 2023, 12:58:50 CET schrieb Uwe Kleine-König:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-03-07 12:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230307115900.2293120-1-u.kleine-koenig@pengutronix.de>
2023-03-07 11:58 ` [PATCH 01/31] phy: allwinner: phy-sun4i-usb: Convert to platform remove callback returning void Uwe Kleine-König
2023-03-14 20:11 ` Jernej Škrabec
2023-03-07 11:58 ` [PATCH 06/31] phy: freescale: phy-fsl-imx8qm-lvds-phy: " Uwe Kleine-König
2023-03-07 11:58 ` [PATCH 08/31] phy: mediatek: phy-mtk-mipi-dsi: " Uwe Kleine-König
2023-03-07 11:58 ` [PATCH 19/31] phy: rockchip: phy-rockchip-inno-csidphy: " Uwe Kleine-König
2023-03-07 12:02 ` Heiko Stübner
2023-03-07 11:58 ` [PATCH 20/31] phy: rockchip: phy-rockchip-inno-dsidphy: " Uwe Kleine-König
2023-03-07 12:02 ` Heiko Stübner
2023-03-07 11:58 ` [PATCH 21/31] phy: rockchip: phy-rockchip-inno-hdmi: " Uwe Kleine-König
2023-03-07 12:02 ` Heiko Stübner [this message]
2023-03-07 11:58 ` [PATCH 22/31] phy: rockchip: phy-rockchip-typec: " Uwe Kleine-König
2023-03-07 12:02 ` Heiko Stübner
2023-03-07 11:58 ` [PATCH 23/31] phy: st: phy-stm32-usbphyc: " Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2144678.Mh6RI2rZIc@diego \
--to=heiko@sntech.de \
--cc=kernel@pengutronix.de \
--cc=kishon@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).