From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 14DBAC433EF for ; Sat, 27 Nov 2021 15:09:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SOBFaQYbwu4k++UyEIl3uHHgoGH0ZbiMO6Fku4Ci6v8=; b=rw4EY4g2/STf6c o/RwsGhfR8WJn75cyW4MInPiw9ZiPrXHzU4gK1ZXqUX5ljKUXaL9MTFzLth3gruVyt4wnI8HOjNsN y0cYErm5SXszQ9/0HE+lLHItIx+RDNq/o9P0pRVCha+RZpvvRXPelk3euKcmV34oiHQb5rb7bAQOB ypFCVMp6iktKe3Ff3tN9hz+m4dDkQQ5R6P8qvWOR581CotN4jWdyvU5d6oXySKE+NcuOfP8QP6Zhu 6MI9eRKJ5L8v1Aoz5wEKnPDeOejwx+MvzqArhHte7TMLi6d7NmCwAwhoTyZUiVt8Gr3t7lErxOJpB VwcoYjm+CjFO732fiMPg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mqzJ6-00DsNW-WD; Sat, 27 Nov 2021 15:08:05 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mqzJ2-00DsMX-SI; Sat, 27 Nov 2021 15:08:02 +0000 Received: from [20.79.204.165] (helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mqzIx-000681-5M; Sat, 27 Nov 2021 16:07:55 +0100 From: Heiko Stuebner To: dri-devel@lists.freedesktop.org, Sascha Hauer Cc: linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, kernel@pengutronix.de, Benjamin Gaignard , Michael Riesch , Sandy Huang , Peter Geis , Rob Herring , Sascha Hauer Subject: Re: [PATCH 01/12] dt-bindings: display: rockchip: Add compatible for rk3568 HDMI Date: Sat, 27 Nov 2021 16:07:37 +0100 Message-ID: <2147171.aSpvfvgOub@phil> In-Reply-To: <20211117143347.314294-2-s.hauer@pengutronix.de> References: <20211117143347.314294-1-s.hauer@pengutronix.de> <20211117143347.314294-2-s.hauer@pengutronix.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211127_070800_948959_20B63880 X-CRM114-Status: GOOD ( 17.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Am Mittwoch, 17. November 2021, 15:33:36 CET schrieb Sascha Hauer: > From: Benjamin Gaignard > > Define a new compatible for rk3568 HDMI. > This version of HDMI hardware block needs two new clocks hclk_vio and hclk > to provide phy reference clocks. > > Signed-off-by: Benjamin Gaignard > Reviewed-by: Rob Herring > Link: https://lore.kernel.org/r/20210707120323.401785-2-benjamin.gaignard@collabora.com > Signed-off-by: Sascha Hauer > --- > .../bindings/display/rockchip/rockchip,dw-hdmi.yaml | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml > index da3b889ad8fcd..53fa42479d5b7 100644 > --- a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml > +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml > @@ -23,6 +23,7 @@ properties: > - rockchip,rk3288-dw-hdmi > - rockchip,rk3328-dw-hdmi > - rockchip,rk3399-dw-hdmi > + - rockchip,rk3568-dw-hdmi > > reg-io-width: > const: 4 > @@ -49,8 +50,11 @@ properties: > - vpll > - enum: > - grf > + - hclk_vio I don't believe this clock should be here: (1) the rk3568 dts node later in the series doesn't use it at all (2) generally vio-clocks are part of the interconnect where the ip block connects to, so right now we just enable it as critical on all socs and if someone actually models the interconnect (where also the qos [quality of service configs] nodes would play into), it would need to be included there. Heiko > + - vpll > + - enum: > + - hclk > - vpll > - - const: vpll > > ddc-i2c-bus: > $ref: /schemas/types.yaml#/definitions/phandle > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel