From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1A8CECE7A8A for ; Sun, 24 Sep 2023 19:47:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PXod4KfbvtNKrT+Jtfl31YOn++qZClkSI389WrfvGTY=; b=zKEbPZigJCY/J7 qlFXzrZhrtRvEUs3jPM77s+R8IEbTazx43A4eHIXTDlL9qRKJaZ7BdKdPFcHPa++4l7uI+ZC3nWdo G+x8fRuQ9VyBSmD8azWrsfM20YhIdD2BljlzOoYS+rk+Qfj4hatdGYS36eictwN34mq5LM+TQN3iK aqRhUpAHh423x8ka//RQa+IfeKuCb/HTT+sHbaKmWzPWQkiU2BuBL1oQkGy6/lPKMSM7g7UsAPzhS gDW9oTE7WTvG0hvGRAnAGGtrH6JaWZev5eZhIk86MF4ut0WgFLMpE70rGoxB+MwM0zz6npbIubaRg MkfhePFXrz46rTaCDF4Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qkV4j-00CjFj-2r; Sun, 24 Sep 2023 19:47:29 +0000 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qkV4g-00CjF0-2g for linux-arm-kernel@lists.infradead.org; Sun, 24 Sep 2023 19:47:28 +0000 Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-4056ce55e7eso18367595e9.2 for ; Sun, 24 Sep 2023 12:47:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695584844; x=1696189644; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=X0UiLgnPTra5qLP9o6AOXP+MP5rQqIbxexMkPfbpuaE=; b=bayP7GsMq3Hi0VSVI/dW3yKujQBWg9J9/RIGpWyHSbJa+2Gr7p7CUyiBeahZ6l8Ql4 hk088WOYhwt6mKMmYHjsol9M664lr3URMOJZGILoqo9BIbJCclB1YDZnRDeZ7KA91lUS Yt5oGlod2jA3j1JsYJNVL9Y/ZQJuIJSfJtq9VHp74cn8TudFBXqUB+fvLHyiJhlopTkn YFK+R1ArIxFBsJ7gpSFT9sILShgDOiP55NGfijcKoyTAx20nAbuvle128gei7yAzwpoE 0a2khJEXz/mzi879QSRvp+zX7NIjp7Wlujc4gm5Teb+tLnyePkgrI19e9lqs5RrkwU/z WAtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695584844; x=1696189644; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=X0UiLgnPTra5qLP9o6AOXP+MP5rQqIbxexMkPfbpuaE=; b=oxsLkhPdgYc8/s2dEr8hP+mBjH9BZfu7HEL66PC2w0m/pFVR0OxGoMjU5QBtHjC+lO 38e+A7jE2KEbjKY574qDdICxL0Ye38gcafz2qXd7ZQKy0Xl6BHDIS6E0MwI+KT4B91Jw iA0Z+ZR+uB5BiGO+pMSZHnz/vcLsu7h2G0ff0ofD7YAmZLqV5GQ8EWhmzxXBI8xiL7SQ oeQXcnIsrH2dENNnHlcsqxIkpRsKIQN4k9ifH02MA6oPDpW34F7aj28k5/28W8/iv+jK gCGefMqn7iDee+uMbjpTgAJQDXlmg2DFDOPsNtCjuVfwp4gH1XfDRNHYRGh2rPdyi3hj qmOg== X-Gm-Message-State: AOJu0YyyoBY3S11mccLQTYhQ/bcVl7yp5SESKTfCkzjOAQTNInx73UQV CCYKx+mu07EFkcaw+TJ+SfSoE63RcCBi9w== X-Google-Smtp-Source: AGHT+IGDoDkjcAsXY5BDoD37D7SSWWRRbHvSuc/IWVrkcNbbcS4m6aLfl01i4du0XtIIfHFrGLoGGQ== X-Received: by 2002:adf:ebcc:0:b0:319:85e2:6972 with SMTP id v12-20020adfebcc000000b0031985e26972mr4084047wrn.42.1695584844170; Sun, 24 Sep 2023 12:47:24 -0700 (PDT) Received: from jernej-laptop.localnet (82-149-12-148.dynamic.telemach.net. [82.149.12.148]) by smtp.gmail.com with ESMTPSA id sd6-20020a170906ce2600b00997e99a662bsm5315866ejb.20.2023.09.24.12.47.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Sep 2023 12:47:23 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: airlied@gmail.com, liuhaoran Cc: daniel@ffwll.ch, samuel@sholland.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, liuhaoran Subject: Re: [PATCH] drm/sun4i: Add error handling in sun4i_layer_init_one() Date: Sun, 24 Sep 2023 21:47:22 +0200 Message-ID: <2156768.irdbgypaU6@jernej-laptop> In-Reply-To: <20230924074216.17390-1-liuhaoran14@163.com> References: <20230924074216.17390-1-liuhaoran14@163.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230924_124726_913400_F0792B2C X-CRM114-Status: GOOD ( 17.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi! Dne nedelja, 24. september 2023 ob 09:42:16 CEST je liuhaoran napisal(a): > This patch adds error-handling for the drm_plane_create_alpha_property() > and drm_plane_create_zpos_property() inside the dw_hdmi_imx_probe(). dw_hdmi_imx_probe() is not from this driver. Best regards, Jernej > > Signed-off-by: liuhaoran > --- > drivers/gpu/drm/sun4i/sun4i_layer.c | 19 ++++++++++++++++--- > 1 file changed, 16 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/sun4i/sun4i_layer.c b/drivers/gpu/drm/sun4i/sun4i_layer.c > index 98f3176366c0..a3343afb7935 100644 > --- a/drivers/gpu/drm/sun4i/sun4i_layer.c > +++ b/drivers/gpu/drm/sun4i/sun4i_layer.c > @@ -224,9 +224,22 @@ static struct sun4i_layer *sun4i_layer_init_one(struct drm_device *drm, > drm_plane_helper_add(&layer->plane, > &sun4i_backend_layer_helper_funcs); > > - drm_plane_create_alpha_property(&layer->plane); > - drm_plane_create_zpos_property(&layer->plane, layer->id, > - 0, SUN4I_BACKEND_NUM_LAYERS - 1); > + ret = drm_plane_create_alpha_property(&layer->plane); > + > + if (ret) { > + dev_err(drm->dev, "Failed to install alpha property, > + rc = %d\n", ret); > + return ERR_PTR(ret); > + } > + > + ret = drm_plane_create_zpos_property(&layer->plane, layer->id, 0, > + SUN4I_BACKEND_NUM_LAYERS - 1); > + > + if (ret) { > + dev_err(drm->dev, "Failed to install zpos property, > + rc = %d\n", ret); > + return ERR_PTR(ret); > + } > > return layer; > } > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel