Re: [PATCH 2/2] arm64: dts: imx8mq: Move funnel outside from soc

Alexander Stein
2023-09-07T06:43:52Z

Am Mittwoch, 6. September 2023, 13:54:44 CEST schrieb Fabio Estevam:
> From: Fabio Estevam <festevam@denx.de>
>
> The 'funnel' node does not contain a register range, so it should
> be placed outside of the soc node to fix schema warnings from
> simple-bus.yaml.
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>

I noticed the warning in dtbs_check as well. LGTM
Acked-by: Alexander Stein <alexander.stein@ew.tq-group.com>

> ---
> arch/arm64/boot/dts/freescale/imx8mq.dtsi | 106 +++++++++++-----------
> 1 file changed, 53 insertions(+), 53 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mq.dtsi index
> 35f07dfb4ca8..4b1ce9fc1758 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -225,6 +225,59 @@ opp-1500000000 {
> };
> };
>
> + funnel {
> + /*
> + * non-configurable funnel don't show up on the AMBA
> + * bus. As such no need to add "arm,primecell".
> + */
> + compatible = "arm,coresight-static-funnel";
> +
> + in-ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> +
> + ca_funnel_in_port0: endpoint {
> + remote-endpoint =
<&etm0_out_port>;
> + };
> + };
> +
> + port@1 {
> + reg = <1>;
> +
> + ca_funnel_in_port1: endpoint {
> + remote-endpoint =
<&etm1_out_port>;
> + };
> + };
> +
> + port@2 {
> + reg = <2>;
> +
> + ca_funnel_in_port2: endpoint {
> + remote-endpoint =
<&etm2_out_port>;
> + };
> + };
> +
> + port@3 {
> + reg = <3>;
> +
> + ca_funnel_in_port3: endpoint {
> + remote-endpoint =
<&etm3_out_port>;
> + };
> + };
> + };
> +
> + out-ports {
> + port {
> + ca_funnel_out_port0: endpoint {
> + remote-endpoint =
<&hugo_funnel_in_port0>;
> + };
> + };
> + };
> + };
> +
> pmu {
> compatible = "arm,cortex-a53-pmu";
> interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_HIGH>;
> @@ -394,59 +447,6 @@ etm3_out_port: endpoint {
> };
> };
>
> - funnel {
> - /*
> - * non-configurable funnel don't show up on the
AMBA
> - * bus. As such no need to add "arm,primecell".
> - */
> - compatible = "arm,coresight-static-funnel";
> -
> - in-ports {
> - #address-cells = <1>;
> - #size-cells = <0>;
> -
> - port@0 {
> - reg = <0>;
> -
> - ca_funnel_in_port0: endpoint
{
> - remote-endpoint =
<&etm0_out_port>;
> - };
> - };
> -
> - port@1 {
> - reg = <1>;
> -
> - ca_funnel_in_port1: endpoint
{
> - remote-endpoint =
<&etm1_out_port>;
> - };
> - };
> -
> - port@2 {
> - reg = <2>;
> -
> - ca_funnel_in_port2: endpoint
{
> - remote-endpoint =
<&etm2_out_port>;
> - };
> - };
> -
> - port@3 {
> - reg = <3>;
> -
> - ca_funnel_in_port3: endpoint
{
> - remote-endpoint =
<&etm3_out_port>;
> - };
> - };
> - };
> -
> - out-ports {
> - port {
> - ca_funnel_out_port0:
endpoint {
> - remote-endpoint =
<&hugo_funnel_in_port0>;
> - };
> - };
> - };
> - };
> -
> funnel@28c03000 {
> compatible = "arm,coresight-dynamic-funnel",
"arm,primecell";
> reg = <0x28c03000 0x1000>;

--
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider