From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 269CEC76196 for ; Mon, 10 Apr 2023 23:37:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Date:To:Cc:From:Subject:References: In-Reply-To:MIME-Version:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gerOBzjooc+kCrwyNbOra6ShwKAu0ujto5w1nyOV2pQ=; b=BxDxNIOx/xUuDU IU+u/TiWyiydxKAT/aHLMzY/iLCx/BFNaP+yiDmOJlRA0zZjufRcofYB18ybk7OpGhMtN4/lmyp9O adyDjY35K2uBshO3oeFtdYq5zyrEL4J/2wvUj3e1tKduothGYRFECiM8+odUgidwg0/hzNiMdlu92 8yg+kSKJxLU+vw4FzisNmJRSugQVQzsc4QpzCL4U3Fd8Hlu6J7STGite/w9OnH9AJPFTwbG9G3Ykg CvE8EFV7dpcmS2fkTcg9/2t+AOjyj7JQZjNM64CB/VNt1Xv82Sxvxp+FceOOeJNG/+WMl+quP4Kqf ikkBPRET4UEchATXGKsA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pm13j-00G63M-36; Mon, 10 Apr 2023 23:36:27 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pm13g-00G62i-37 for linux-arm-kernel@lists.infradead.org; Mon, 10 Apr 2023 23:36:26 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4FD2461982; Mon, 10 Apr 2023 23:36:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A49ABC433D2; Mon, 10 Apr 2023 23:36:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681169783; bh=TirLwEYBbP4VCi+NhiloSleSjPJ6R//R3r7qXDcBu9I=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=g8NZ85bPEriDDh2zVqaVoPv4YOphP1x+jqdyhswCs08JNo32vx/uYplhfJmCSIKY0 BtnpSARwyar60MHcxFJSDO0Kzl4Qys/FwC9jLiCu3c+MpcJANIMbkMTB0yNlrWfJpI 9MTcOpBJ952vtKUngt7jwgtFfRaEni39llZhTcrGA8MprqhHOp7xVAFSLGuLhmheYn SvIVXC6xKsLfhRqdopJO3Za9tVcS+zdmR/n8lNcZgnuW9d4pvdYstlMM/4ZwV51CRI bH3pcNUkb8szMUfCFodqES2p20hmnF/cOevZzKSLrtWe0+3MxRse7xA2p0xOzCIHl/ qe3jScwMooj9g== Message-ID: <216176104e507b860e24399bf020d836.sboyd@kernel.org> MIME-Version: 1.0 In-Reply-To: <20230327-mvebu-clk-fixes-v1-2-438de1026efd@kernel.org> References: <20230327-mvebu-clk-fixes-v1-0-438de1026efd@kernel.org> <20230327-mvebu-clk-fixes-v1-2-438de1026efd@kernel.org> Subject: Re: [PATCH 2/3] clk: mvebu: Use of_get_cpu_hwid() to read CPU ID From: Stephen Boyd Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org To: Andrew Lunn , Gregory Clement , Michael Turquette , Rob Herring , Sebastian Hesselbarth Date: Mon, 10 Apr 2023 16:36:21 -0700 User-Agent: alot/0.10 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230410_163625_041044_041F7310 X-CRM114-Status: GOOD ( 12.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Rob Herring (2023-03-27 11:43:19) > Use of_get_cpu_hwid() rather than the open coded reading of the CPU > nodes "reg" property. The existing code is in fact wrong as the "reg" > address cells size is 2 cells for arm64. The existing code happens to > work because the DTS files are wrong as well. > > Signed-off-by: Rob Herring > --- > Note this should be marked for stable so that if/when the DTS files are > fixed, then at least stable kernels will work. This is untested, so I > didn't mark for stable. That makes it sound like it breaks for existing DTS files. Is that the case? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel