From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3799BC4332F for ; Wed, 9 Nov 2022 07:24:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MnLV2B+/wH4GUT53nQKMNZvDIMO+2lkDRx05wECczcg=; b=3B6n9zsSTUjfdt sOZRzOQ+ptnVsPHeCQMve0i3sDWC+ojaxBI8jqEBmrs1SBEIlU75O/12SMZxZ5F4WpO0TMTmkzyW5 GJUWnwQqL/MaoUXIDlBz5kkOXiO1c2E+xIK/r9Z5ym0R97pBU/P8N7dGAN+tE5F1RFN4pBwo7aUvj a1mCa95nCJLV7ltOkHjOZsRAQm258YhfvZ1TBAgOXyYVnCE2djF64yd9WRB8elL1LWSE7IqEvXwCf 9JyNYShEVXLHmWeiNcp5kXBrJzZwnxWAhYJpdD1IaFa9jCC9XjzZZebNcVXxA9sMhx9A8UwxePtE5 EUaCbnducr6t/vMxZBOg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1osfQQ-00BYa6-La; Wed, 09 Nov 2022 07:23:06 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1osfQM-00BYZ7-Hk for linux-arm-kernel@lists.infradead.org; Wed, 09 Nov 2022 07:23:04 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1667978582; x=1699514582; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=r5AS8oIHpyzuOh41/a1bWf+zGuXF46zGbGnB3FikE9Q=; b=HBbbg1GHhObFhRV4E0Ln6hQXvtZT/AvFO51yfmHDvWrjis6jSbOwfGY4 hoJ/4jAX1d0RhjBmtbOK06I76GUQthacriZtKSdSzdUILdn+4jpr5YsO3 XdGAT+lPd+n3bqSLNoPCU44AblzaWE+XGhSaWjsqVuJR7xOnwQ+DdNv+k H8Hy9RJvxvvYWHIWFCmmwuOiDwXnfkqYxXqUzQD0DwLtpAhNRTte/7PwV sx1sL35DxjuZMNI+GH5No5PiGxWhV8ybCIit4oSbbWOd8biwDYPRz65V6 IXEaegj0/7j9szn/kzYKvvsoi8Iou6TlYG97+FMdEV9vu+DLCn6cYWXBI A==; X-IronPort-AV: E=Sophos;i="5.96,149,1665439200"; d="scan'208";a="27242576" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 09 Nov 2022 08:22:57 +0100 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Wed, 09 Nov 2022 08:22:57 +0100 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Wed, 09 Nov 2022 08:22:57 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1667978577; x=1699514577; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=r5AS8oIHpyzuOh41/a1bWf+zGuXF46zGbGnB3FikE9Q=; b=oBPgUrB6HH+7wgJNHLCCDFqsaNza+YgqHg97Nhh/QR6+89zbqpWUh5Qr wbpAho9Dj4wcoEDRrjvBffPrMhAJt/h92CeMJ4mCo3MOuAGwNzJluHLyc 7rsup0PfGpvSjMICZOQ+NQ+y9zWfZw2fgXQF2h/BFJWnQzh84prVXroIO bLkVQVNl/sqj0BDlwoeNzsj4c+XAKBMnimyGKDEv/AYX3G/qXthWE2OMd msiiRLosepLY39fnqCuQbDG3H98uh/C4wukFA4ONyQnSPU8VKCU6PmIEb 7/tQrB2xfsuuSBSeGFgRk3/ruEkRyOzB1REC8GK+TGnASLadSovenolcd w==; X-IronPort-AV: E=Sophos;i="5.96,149,1665439200"; d="scan'208";a="27242575" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 09 Nov 2022 08:22:56 +0100 Received: from steina-w.localnet (unknown [10.123.53.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id 633B6280056; Wed, 9 Nov 2022 08:22:56 +0100 (CET) From: Alexander Stein To: Marek Vasut Cc: devicetree@vger.kernel.org, Marek Vasut , Fabio Estevam , Krzysztof Kozlowski , Lucas Stach , Richard Zhu , Rob Herring , Shawn Guo , linux-arm-kernel@lists.infradead.org, NXP Linux Team Subject: Re: [PATCH v5 1/3] dt-bindings: imx6q-pcie: Handle various clock configurations Date: Wed, 09 Nov 2022 08:22:51 +0100 Message-ID: <21665881.EfDdHjke4D@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <20221109002449.35936-1-marex@denx.de> References: <20221109002449.35936-1-marex@denx.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221108_232302_927760_C4EC8720 X-CRM114-Status: GOOD ( 23.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Marek, Am Mittwoch, 9. November 2022, 01:24:47 CET schrieb Marek Vasut: > The i.MX SoCs have various clock configurations routed into the PCIe IP, > the list of clock is below. Document all those configurations in the DT > binding document. > > All SoCs: pcie, pcie_bus > 6QDL, 7D: + pcie_phy > 6SX: + pcie_phy pcie_inbound_axi > 8MQ: + pcie_phy pcie_aux > 8MM, 8MP: + pcie_aux > > Acked-by: Alexander Stein > Signed-off-by: Marek Vasut I just noticed this is a separate series. Please note that there is already another patch doing the same at [1] Regards, Alexander [1] https://patchwork.kernel.org/project/linux-arm-kernel/patch/ 20221107204934.32655-2-Sergey.Semin@baikalelectronics.ru/ > --- > Cc: Fabio Estevam > Cc: Krzysztof Kozlowski > Cc: Lucas Stach > Cc: Richard Zhu > Cc: Rob Herring > Cc: Shawn Guo > Cc: linux-arm-kernel@lists.infradead.org > Cc: NXP Linux Team > To: devicetree@vger.kernel.org > --- > V2: - Add AB from Alex > V3: - Duplicate clock-names maxItems to mx6sx and mx8mq compatibles > - Flatten the if-else structure > - The validation no longer works and introduces errors like these: > arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dahlia.dtb: > pcie@33800000: clock-names:2: 'pcie_phy' was expected V4: - Reinstate > minItems: for clock-names in main section, turn the last two clock-names > items into enums to cover all IP variants. - Add another allOf entry for > mx6q/mx6qp/mx7d clock-names list. - Adjust clock maxItems in the allOf > section. > V5: - No change > --- > .../bindings/pci/fsl,imx6q-pcie.yaml | 73 +++++++++++++++++-- > 1 file changed, 68 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml > b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml index > 376e739bcad40..2df73be0ffbea 100644 > --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml > @@ -14,9 +14,6 @@ description: |+ > This PCIe host controller is based on the Synopsys DesignWare PCIe IP > and thus inherits all the common properties defined in snps,dw-pcie.yaml. > > -allOf: > - - $ref: /schemas/pci/snps,dw-pcie.yaml# > - > properties: > compatible: > enum: > @@ -60,8 +57,8 @@ properties: > items: > - const: pcie > - const: pcie_bus > - - const: pcie_phy > - - const: pcie_inbound_axi for imx6sx-pcie, pcie_aux for imx8mq-pcie > + - enum: [ pcie_phy, pcie_aux ] > + - enum: [ pcie_aux, pcie_inbound_axi ] > > num-lanes: > const: 1 > @@ -177,6 +174,72 @@ required: > > unevaluatedProperties: false > > +allOf: > + - $ref: /schemas/pci/snps,dw-pcie.yaml# > + > + - if: > + properties: > + compatible: > + contains: > + enum: > + - fsl,imx6q-pcie > + - fsl,imx6qp-pcie > + - fsl,imx7d-pcie > + then: > + properties: > + clocks: > + maxItems: 3 > + clock-names: > + items: > + - const: pcie > + - const: pcie_bus > + - const: pcie_phy > + > + - if: > + properties: > + compatible: > + contains: > + const: fsl,imx6sx-pcie > + then: > + properties: > + clock-names: > + items: > + - const: pcie > + - const: pcie_bus > + - const: pcie_phy > + - const: pcie_inbound_axi > + > + - if: > + properties: > + compatible: > + contains: > + const: fsl,imx8mq-pcie > + then: > + properties: > + clock-names: > + items: > + - const: pcie > + - const: pcie_bus > + - const: pcie_phy > + - const: pcie_aux > + > + - if: > + properties: > + compatible: > + contains: > + enum: > + - fsl,imx8mm-pcie > + - fsl,imx8mp-pcie > + then: > + properties: > + clocks: > + maxItems: 3 > + clock-names: > + items: > + - const: pcie > + - const: pcie_bus > + - const: pcie_aux > + > examples: > - | > #include _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel