Re: [PATCH 8/9] ARM: multi_v7_defconfig: Add options to support TQMLS102xA series

Krzysztof Kozlowski
2023-01-20T11:36:55Z

On 20/01/2023 12:12, Alexander Stein wrote:
>>> CONFIG_GPIO_MXC=y
>>> CONFIG_GPIO_RCAR=y
>>> CONFIG_GPIO_SYSCON=y
>>>
>>> @@ -493,6 +497,7 @@ CONFIG_GPIO_PCA953X=y
>>>
>>> CONFIG_GPIO_PCA953X_IRQ=y
>>> CONFIG_GPIO_PCF857X=y
>>> CONFIG_GPIO_PALMAS=y
>>>
>>> +CONFIG_GPIO_STMPE=y
>>
>> module
>
> That one as well, it's just a bool.

OK

>
>>> CONFIG_GPIO_TPS6586X=y
>>> CONFIG_GPIO_TPS65910=y
>>> CONFIG_GPIO_TWL4030=y
>>>
>>> @@ -533,6 +538,7 @@ CONFIG_SENSORS_INA2XX=m
>>>
>>> CONFIG_CPU_THERMAL=y
>>> CONFIG_DEVFREQ_THERMAL=y
>>> CONFIG_IMX_THERMAL=y
>>>
>>> +CONFIG_QORIQ_THERMAL=m
>>>
>>> CONFIG_ROCKCHIP_THERMAL=y
>>> CONFIG_RCAR_THERMAL=y
>>> CONFIG_ARMADA_THERMAL=y
>>>
>>> @@ -821,6 +827,8 @@ CONFIG_SND_SOC_MSM8916_WCD_ANALOG=m
>>>
>>> CONFIG_SND_SOC_MSM8916_WCD_DIGITAL=m
>>> CONFIG_SND_SOC_SGTL5000=m
>>> CONFIG_SND_SOC_STI_SAS=m
>>>
>>> +CONFIG_SND_SOC_TLV320AIC32X4=m
>>> +CONFIG_SND_SOC_TLV320AIC32X4_I2C=m
>>>
>>> CONFIG_SND_SOC_WM8978=m
>>> CONFIG_SND_AUDIO_GRAPH_CARD=m
>>> CONFIG_USB=y
>>>
>>> @@ -830,6 +838,7 @@ CONFIG_USB_XHCI_MVEBU=y
>>>
>>> CONFIG_USB_XHCI_TEGRA=m
>>> CONFIG_USB_BRCMSTB=m
>>> CONFIG_USB_EHCI_HCD=y
>>>
>>> +CONFIG_USB_EHCI_FSL=y
>>
>> module
>
> Well, apparently module autoload is broken due to wrong modalias value of ehci
> node created by fsl-mph-dr-of. This setting this as a module is currently not
> working.

But this is not valid argument for defconfig change. This must be
module. If autoloading does not work, fix that one.

>
>>> CONFIG_USB_EHCI_HCD_STI=y
>>> CONFIG_USB_EHCI_EXYNOS=m
>>> CONFIG_USB_EHCI_MV=m
>>>
>>> @@ -933,6 +942,8 @@ CONFIG_NEW_LEDS=y
>>>
>>> CONFIG_LEDS_CLASS=y
>>> CONFIG_LEDS_CLASS_FLASH=m
>>> CONFIG_LEDS_CPCAP=m
>>>
>>> +CONFIG_LEDS_PCA9532=m
>>> +CONFIG_LEDS_PCA9532_GPIO=y
>>>
>>> CONFIG_LEDS_GPIO=y
>>> CONFIG_LEDS_PWM=y
>>> CONFIG_LEDS_MAX8997=m
>>>
>>> @@ -949,6 +960,7 @@ CONFIG_LEDS_TRIGGER_DEFAULT_ON=y
>>>
>>> CONFIG_LEDS_TRIGGER_TRANSIENT=y
>>> CONFIG_LEDS_TRIGGER_CAMERA=y
>>> CONFIG_EDAC=y
>>>
>>> +CONFIG_EDAC_LAYERSCAPE=y
>>>
>>> CONFIG_EDAC_HIGHBANK_MC=y
>>> CONFIG_EDAC_HIGHBANK_L2=y
>>> CONFIG_RTC_CLASS=y
>>>
>>> @@ -962,6 +974,7 @@ CONFIG_RTC_DRV_MAX8997=m
>>>
>>> CONFIG_RTC_DRV_MAX77686=y
>>> CONFIG_RTC_DRV_RK808=m
>>> CONFIG_RTC_DRV_RS5C372=m
>>>
>>> +CONFIG_RTC_DRV_PCF85063=y
>>
>> module
>
> Okay, module it is. So I assume it is acceptable the system time is set much
> later after mounting rootfs then?

Modules can be loaded from initramfs, not rootfs.

Defconfig=y is only for critical stuff needed to bring initramfs. Time
is not needed for initramfs.

Best regards,
Krzysztof