From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3FAC5C4332F for ; Wed, 13 Dec 2023 20:07:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6l4GKH6ufA8HPE+7UaW7G1mwtVd1umO1Cos8B0BMH/g=; b=WyFpj2EQPzvDct GbinTZIJrdgbkB0A5g8b5OkaZhvqybpEoY8BE9hHAsW5Zl8c6sSuXE2KHSjG3Q36ptclpunrZqVAN 18xtGPdYDkVbnOMEe69qRqbf1t3MdUymuAgDxv/9e5Ulr3wdPDaR5ngYh44b+bb1zNAUa98yPL4sC 41gTmXmE3ZisXIPZv8oheC6mEUntsOHiMQDXTKX4j1GY/mF5Z+6PqrSyJB7j3clZL6l9ZivNwd2l7 XjMWUklv/aVXHADwD3uhE/s4nhpLurcW3aKzx5+OXTnlYs2ojudu5DzX825YDDcY1Iy9AqYmVkVNp WH/N3ueXgaEmvBmjGtIw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rDVVu-00Fw08-1O; Wed, 13 Dec 2023 20:07:26 +0000 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rDVVs-00Fvze-1I for linux-arm-kernel@lists.infradead.org; Wed, 13 Dec 2023 20:07:25 +0000 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-40c256ffdbcso75314265e9.2 for ; Wed, 13 Dec 2023 12:07:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702498043; x=1703102843; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Gsu3q13MvDpE/CGXMPYCWwJtd9OUgwH5TkWvsm2e2cA=; b=f6Lu29/iYmrATUy6pkuxqTzO3fLaNI0VNvtIIQkKCn6p8pgk6PxtFgLsdwEDFkkhYu pRzlZasP4F40u9N4Vw5ivDF9sgDxxv5r4F7ETvoS6qU2gs88Qgv0bQEpEsuXt+q9wTqT sG/a3Ll6Acii2PYVTrB7SvMFgxajuqyUdtDlQlP0dB3Nzmk3U6Yn7MvHoT2aa44x2Aua kmEMPOScPzx0QetI07CgSKU3mqcLijNyWnI+qGBTcpmzrYAlTJIMnTCtrekPhqy+nuBx LM3jpE0nfu7KZ0/qvpjrwun9IL6zx+E5diMW5dWVSmmWGGveSBRdt0ugQpsbAZnOpxIK zksQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702498043; x=1703102843; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Gsu3q13MvDpE/CGXMPYCWwJtd9OUgwH5TkWvsm2e2cA=; b=eiOTtD+dGdjLyy7tZdwQGWoirh6AjPdxM0jXVxjXJA6NV7exOnHPCljQvI9N5Hlpfk ncflyYy7vsznLv3rWy5Q1pdmjtVssP7c69Y843phmaZhqeU65f17k5fZW1MIWLkEI57U jrjPFP09pI3MHzc8Jwmd4tu57auZQt/Tb5TQOJxlHKlugrKuzed6qs9I7I0rvK3pX9jA t0XRqkCGIiBOsOfv4Wn3mU4Lovx+Geb8wlZ1TLnx+fn9MlfIjkqnLLLCuxqcko/TXlBK zOOc46xuN/cLbrS5u1UzANApJpWhhqvbqIiFlevNmBGN/4qTcZjrcFBe3cvhr2mJl/pr Xl6g== X-Gm-Message-State: AOJu0YzZQaX7P94VNQxS9Q/IJDS/RA1Cf8qGyscTtkfvKRi3lGLyT/Qk 8HSjMMO33fk1fExFdutvEcc= X-Google-Smtp-Source: AGHT+IHXFAhPhkQlTGwETgEwQJ0+N7+UNA2cm4OrTmck51BAJtoT4bV4BK2nZBlfQ3MZpCxFuPiTkg== X-Received: by 2002:a05:600c:81b:b0:40b:5e59:c590 with SMTP id k27-20020a05600c081b00b0040b5e59c590mr4312661wmp.186.1702498042479; Wed, 13 Dec 2023 12:07:22 -0800 (PST) Received: from archlinux.localnet (82-149-12-148.dynamic.telemach.net. [82.149.12.148]) by smtp.gmail.com with ESMTPSA id p7-20020a05600c468700b0040c420eda48sm15195843wmo.22.2023.12.13.12.07.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 12:07:21 -0800 (PST) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Paul Kocialkowski Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Samuel Holland , Maxime Ripard , Laurent Pinchart , Michael Turquette , Stephen Boyd , Paul Kocialkowski Subject: Re: [PATCH v7 3/7] ARM: dts: sun8i: v3s: Add nodes for MIPI CSI-2 support Date: Wed, 13 Dec 2023 21:07:20 +0100 Message-ID: <2169265.irdbgypaU6@archlinux> In-Reply-To: <20231122141426.329694-4-paul.kocialkowski@bootlin.com> References: <20231122141426.329694-1-paul.kocialkowski@bootlin.com> <20231122141426.329694-4-paul.kocialkowski@bootlin.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231213_120724_442636_CC7498D1 X-CRM114-Status: GOOD ( 22.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Paul! Sorry for late reply. On Wednesday, November 22, 2023 3:14:21 PM CET Paul Kocialkowski wrote: > MIPI CSI-2 is supported on the V3s with an A31-based MIPI CSI-2 bridge > controller. The controller uses a separate D-PHY, which is the same > that is otherwise used for MIPI DSI, but used in Rx mode. > > On the V3s, the CSI0 controller is dedicated to MIPI CSI-2 as it does > not have access to any parallel interface pins. > > Add all the necessary nodes (CSI0, MIPI CSI-2 bridge and D-PHY) to > support the MIPI CSI-2 interface. > > Note that a fwnode graph link is created between CSI0 and MIPI CSI-2 > even when no sensor is connected. This will result in a probe failure > for the controller as long as no sensor is connected but this is fine > since no other interface is available. > > The interconnects property is used to inherit the proper DMA offset. > > Signed-off-by: Paul Kocialkowski > --- > arch/arm/boot/dts/allwinner/sun8i-v3s.dtsi | 71 ++++++++++++++++++++++ > 1 file changed, 71 insertions(+) > > diff --git a/arch/arm/boot/dts/allwinner/sun8i-v3s.dtsi b/arch/arm/boot/dts/allwinner/sun8i-v3s.dtsi > index 506e98f4f69d..d57612023aa4 100644 > --- a/arch/arm/boot/dts/allwinner/sun8i-v3s.dtsi > +++ b/arch/arm/boot/dts/allwinner/sun8i-v3s.dtsi > @@ -621,6 +621,77 @@ gic: interrupt-controller@1c81000 { > interrupts = ; > }; > > + csi0: camera@1cb0000 { > + compatible = "allwinner,sun8i-v3s-csi"; > + reg = <0x01cb0000 0x1000>; > + interrupts = ; > + clocks = <&ccu CLK_BUS_CSI>, > + <&ccu CLK_CSI1_SCLK>, > + <&ccu CLK_DRAM_CSI>; > + clock-names = "bus", "mod", "ram"; > + resets = <&ccu RST_BUS_CSI>; > + interconnects = <&mbus 5>; > + interconnect-names = "dma-mem"; As far as I can see, interconnects are not documented in allwinner,sun6i-a31-csi.yaml. Please run make dtbs_check on this. Best regards, Jernej > + status = "disabled"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@1 { > + reg = <1>; > + > + csi0_in_mipi_csi2: endpoint { > + remote-endpoint = <&mipi_csi2_out_csi0>; > + }; > + }; > + }; > + }; > + > + mipi_csi2: csi@1cb1000 { > + compatible = "allwinner,sun8i-v3s-mipi-csi2", > + "allwinner,sun6i-a31-mipi-csi2"; > + reg = <0x01cb1000 0x1000>; > + interrupts = ; > + clocks = <&ccu CLK_BUS_CSI>, > + <&ccu CLK_CSI1_SCLK>; > + clock-names = "bus", "mod"; > + resets = <&ccu RST_BUS_CSI>; > + status = "disabled"; > + > + phys = <&dphy>; > + phy-names = "dphy"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + mipi_csi2_in: port@0 { > + reg = <0>; > + }; > + > + mipi_csi2_out: port@1 { > + reg = <1>; > + > + mipi_csi2_out_csi0: endpoint { > + remote-endpoint = <&csi0_in_mipi_csi2>; > + }; > + }; > + }; > + }; > + > + dphy: d-phy@1cb2000 { > + compatible = "allwinner,sun6i-a31-mipi-dphy"; > + reg = <0x01cb2000 0x1000>; > + clocks = <&ccu CLK_BUS_CSI>, > + <&ccu CLK_MIPI_CSI>; > + clock-names = "bus", "mod"; > + resets = <&ccu RST_BUS_CSI>; > + allwinner,direction = "rx"; > + status = "disabled"; > + #phy-cells = <0>; > + }; > + > csi1: camera@1cb4000 { > compatible = "allwinner,sun8i-v3s-csi"; > reg = <0x01cb4000 0x3000>; > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel