From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB27EC433B4 for ; Mon, 17 May 2021 12:04:31 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 765EA611CC for ; Mon, 17 May 2021 12:04:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 765EA611CC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=foss.st.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:CC:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/78A4i0F+23twA9QXE4OsxlZceJxHhEb45cqwgRnnu4=; b=LX4UlPIk7gevHefbKCW06tyup KjqvqQtR0t3O+fNG3vXRmdUsinKwUZRJeeVl+FfJ3dhSW5Zf084uI89DVuUKX5ptQsVyjqv8WI+1P Jy1OBrXOOAUv8xT/xlYaIX+E6h59FJMohS93EqIuGHzs0VQIxhDjhmGNHQc0eSs8NW89Fb/VJiVmf Huo36aOx4lrUA3sM+DcPZhAIMulCtbmVLrGXb5TAiqzTKR5NPWeiohoz7+JSl/lAKlTp8glYBaFiA DlqGjAiPvboIqvrFyhgPeWwfBZN+pIJPsFfSFeW/fcltIPSFPA9Hh+6DZsvfmwS/+qQCMTjrcTbmp GKAL3YW9A==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1libxI-00Ep59-IB; Mon, 17 May 2021 12:02:40 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1libuq-00Eos0-Q6; Mon, 17 May 2021 12:00:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:CC:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=TcmYJNU4eWE15FZk4OMDeaIOkzfFDoWeoFbrHlPKHBE=; b=k4sphUfqC7UyvfXSSjAjmtx3no SvPJB1OxMvNQlu3XN6X4fms1XI8UVCyiqn/tao+ouukJuQJn2mdMBqsn5o7GTVVskHQHbqaFc15KJ kvz1W7Zdur2vLM+yjPLGKr8G3+XYMl6sr/4ehfqxOw+YdOf394dUWGGpWHiTplvQsk8YzW5xH2hZz L57d+6Mdbss8MvtgSSFum06eA7rg9hraJtA4BVCVN2sqzAvM3Xw4III9OnUyQ7UjXs03s7xTMhj3V +oB3gcD7v08eTV1+fzr+G3IMQzuqqUDQ4R/u0zi/lnYo/wpP0EzPQekYuIIC3iyF+2oQfz6OZeqpG JgnytU1Q==; Received: from mx07-00178001.pphosted.com ([185.132.182.106]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1libun-00Djrk-95; Mon, 17 May 2021 12:00:07 +0000 Received: from pps.filterd (m0046668.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 14HBup7o021853; Mon, 17 May 2021 13:59:58 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=TcmYJNU4eWE15FZk4OMDeaIOkzfFDoWeoFbrHlPKHBE=; b=SrBDm4E1fcMVUx6NrqfB71mvVNlmuO5I2IsbrlAgxKS3ciI408l5PHaYEBrZbGwJ55Yf iy5oedphfssetrHYMgq2nV37FgbtXL0jNlarfPnxw4qkZHT3T0BRk0P+XbSsb4MLE1Jy 4Cs5jDzTr2k+eNmE7gDfVQhBmN2WmaflfmHlr+MDqkR8wt8dFSChGHKsDHFyVY8TPRjj BGnJL9VTebB58sEDEiMfLBwaRmsoBHPwI8Dydp26kW3la9w+K3qsTBCDwC6/oQZ6ZcFe twl9SbmFGncDM4/kTflsV16mHyVpkAwWuqAlxbuhsl0NdoIgiZjjFMx60lSBIoh9Fwc7 dA== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 38kmb2sdhk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 17 May 2021 13:59:58 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id A73A910002A; Mon, 17 May 2021 13:59:56 +0200 (CEST) Received: from Webmail-eu.st.com (sfhdag2node3.st.com [10.75.127.6]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 8919F22D614; Mon, 17 May 2021 13:59:56 +0200 (CEST) Received: from lmecxl0573.lme.st.com (10.75.127.49) by SFHDAG2NODE3.st.com (10.75.127.6) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 17 May 2021 13:59:55 +0200 Subject: Re: [PATCH v2 1/3] spi: spi-mem: add automatic poll status functions To: Boris Brezillon CC: Mark Brown , Miquel Raynal , Vignesh Raghavendra , , Alexandre Torgue , , , , , References: <20210507131756.17028-1-patrice.chotard@foss.st.com> <20210507131756.17028-2-patrice.chotard@foss.st.com> <20210517094140.53cb643a@collabora.com> <20210517132551.7dd56a5e@collabora.com> From: Patrice CHOTARD Message-ID: <21717dd0-86a7-b3d9-952e-5c7539f90bee@foss.st.com> Date: Mon, 17 May 2021 13:59:54 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210517132551.7dd56a5e@collabora.com> Content-Language: en-US X-Originating-IP: [10.75.127.49] X-ClientProxiedBy: SFHDAG2NODE1.st.com (10.75.127.4) To SFHDAG2NODE3.st.com (10.75.127.6) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-05-17_04:2021-05-17, 2021-05-17 signatures=0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210517_050005_651441_19EE7DF0 X-CRM114-Status: GOOD ( 32.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi On 5/17/21 1:25 PM, Boris Brezillon wrote: > On Mon, 17 May 2021 11:24:25 +0200 > Patrice CHOTARD wrote: > >> Hi Boris >> >> On 5/17/21 9:41 AM, Boris Brezillon wrote: >>> On Fri, 7 May 2021 15:17:54 +0200 >>> wrote: >>> >>>> +/** >>>> + * spi_mem_poll_status() - Poll memory device status >>>> + * @mem: SPI memory device >>>> + * @op: the memory operation to execute >>>> + * @mask: status bitmask to ckeck >>>> + * @match: (status & mask) expected value >>>> + * @timeout_ms: timeout in milliseconds >>>> + * >>>> + * This function send a polling status request to the controller driver >>>> + * >>>> + * Return: 0 in case of success, -ETIMEDOUT in case of error, >>>> + * -EOPNOTSUPP if not supported. >>>> + */ >>>> +int spi_mem_poll_status(struct spi_mem *mem, >>>> + const struct spi_mem_op *op, >>>> + u16 mask, u16 match, u16 timeout_ms) >>> >>> Maybe you should pass a delay_us too, to poll the status at the right >>> rate in the SW-based case (can also be used by drivers if they need to >> >> Ok, i will add a polling_rate_us parameter to poll_status() callback, >> even if in STM32 driver case we will not use it, i agree it should be useful >> depending of driver's implementation. >> >>> configure the polling rate). You could also add an initial_delay_us to >>> avoid polling the status too early: an erase operation will take longer >>> than a write which will take longer than a read. No need to check the >>> status just after issuing the command, especially if the polling is >>> done in SW. Those 2 arguments should also be passed to the driver. >> >> Regarding the addition of an initial_delay_us. We got two solution: >> - use the same polling rate already used by read_poll_timeout() and >> set read_poll_timeout()'s sleep_before_read parameter to true (in our case 20 us >> will be used as initial delay and as polling rate). >> >> - add an udelay(initial_delay_us) or even better usleep_range(initial_delay_us, >> initial_delay_us + delta) before calling read_poll_timeout(). >> >> I imagine you prefer the second solution ? > > Yep, you might want to use udelay() when the delay is small and > usleep_range() otherwise. > >> >> By adding polling_rate_us and initial_delay_us parameters to >> spi_mem_poll_status(), it implies to update all spinand_wait() calls for >> different operations (reset, read page, write page, erase) with respective >> initial_delay_us/polling_rate_us values for spi_mem_poll_status()'s parameters. >> >> Can you provide adequate initial_delay_us and polling rate_us for each operation type ?. > > If I refer to the datasheets I have, > > tBERS (erase) 1ms to 4ms > tPROG 300us to 400us > tREAD 25us to 100us > > Let's assume we want to minimize the latency, I'd recommend dividing > the min value by 4 for the initial delay, and dividing it by 20 for the > poll delay, which gives: > > ERASE -> initial_delay = 250us, poll_delay = 50us > PROG -> initial_delay = 100us, poll_delay = 20us > READ -> initial_delay = 6us, poll_delay = 5us What about RESET ? we also need an initial and poll delay too (see spinand_reset_op() ) > > Of course, that'd be even better if we were able to extract this > information from the NAND ID (or ONFI table), but I guess we can live > with those optimistic values in the meantime. > Thanks Patrice _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel