From: heiko@sntech.de (Heiko Stuebner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] arm64: dts: rockchip: Add basic support for orion-r68
Date: Fri, 15 Jan 2016 15:03:52 +0100 [thread overview]
Message-ID: <2174023.jkjdoEECkq@phil> (raw)
In-Reply-To: <CABxcv=m+hK3xS8_fYNns-xE5DaLHD0D_Yj8McjM72Y_5V=YmSw@mail.gmail.com>
Hi Javier,
Am Freitag, 15. Januar 2016, 10:28:44 schrieb Javier Martinez Canillas:
> This is not a complete review but I just wanted to comment on two
> things that I noticed:
same for me for now :-)
> On Fri, Jan 15, 2016 at 10:06 AM, Matthias Brugger
> <matthias.bgg@gmail.com> wrote:
>
> [snip]
>
> > + };
> > +
> > + vcc_18: vcc18-regulator {
> > + compatible = "regulator-fixed";
> > + regulator-name = "vcc_18";
> > + regulator-min-microvolt = <1800000>;
> > + regulator-max-microvolt = <1800000>;
> > + regulator-always-on;
> > + regulator-boot-on;
> > + vin-supply = <&vcc_sys>;
> > + };
> > +
> > + /* supplies both host and otg */
> > + vcc_host: vcc-host-regulator {
> > + compatible = "regulator-fixed";
> > + gpio = <&gpio0 4 GPIO_ACTIVE_LOW>;
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&host_vbus_drv>;
> > + regulator-name = "vcc_host";
> > + regulator-always-on;
> > + regulator-boot-on;
> > + vin-supply = <&vcc_sys>;
> > + };
> > +
> > + vccio_sd: vcc-io-sd-regulator {
> > + regulator-name= "vccio_sd";
> > + gpio = <&gpio0 9 GPIO_ACTIVE_LOW>;
> > + regulator-min-microvolt = <3300000>;
> > + regulator-max-microvolt = <3300000>;
> > + };
> > +
> > + vcc_sd: vcc-sd-regulator {
> > + compatible = "regulator-fixed";
> > + regulator-name = "vcc_sd";
> > + gpio = <&gpio3 11 GPIO_ACTIVE_LOW>;
> > + regulator-min-microvolt = <3300000>;
> > + regulator-max-microvolt = <3300000>;
> > + regulator-always-on;
> > + regulator-boot-on;
> > + vin-supply = <&vcc_io>;
> > + };
> > +
> > + vcc_io: vcc-io-regulator {
> > + compatible = "regulator-fixed";
> > + regulator-name = "vcc_io";
> > + regulator-min-microvolt = <3300000>;
> > + regulator-max-microvolt = <3300000>;
> > + regulator-always-on;
> > + regulator-boot-on;
> > + vin-supply = <&vcc_sys>;
> > + };
> > +
> > + vcc_lan: vcc-lan-regulator {
> > + compatible = "regulator-fixed";
> > + regulator-name = "vcc_lan";
> > + regulator-min-microvolt = <3300000>;
> > + regulator-max-microvolt = <3300000>;
> > + regulator-always-on;
> > + regulator-boot-on;
> > + vin-supply = <&vcc_io>;
> > + };
> > +
> > + vcc_sys: vcc-sys-regulator {
> > + compatible = "regulator-fixed";
> > + regulator-name = "vcc_sys";
> > + regulator-min-microvolt = <5000000>;
> > + regulator-max-microvolt = <5000000>;
> > + regulator-always-on;
> > + regulator-boot-on;
> > + };
> > +
> > + vccio_wl: vccio-wl-regulator {
> > + compatible = "regulator-fixed";
> > + regulator-name = "vccio_wl";
> > + regulator-min-microvolt = <3300000>;
> > + regulator-max-microvolt = <3300000>;
> > + regulator-always-on;
> > + regulator-boot-on;
> > + vin-supply = <&vcc_io>;
> > + };
> > +
> > + vdd_10: vdd-10-regulator {
> > + compatible = "regulator-fixed";
> > + regulator-name = "vdd_10";
> > + regulator-min-microvolt = <1000000>;
> > + regulator-max-microvolt = <1000000>;
> > + regulator-always-on;
> > + regulator-boot-on;
> > + vin-supply = <&vcc_sys>;
> > + };
> > +};
>
> There is only one regulator that is not marked as always-on. This will
> prevent the regulator subsystem to disable unused regulators. Do you
> really need all of them to be always-on?
I do believe the regulators should be more or less correct. Sadly there are
no real schematics for that specific device available, but the reference
design for rk3368-based tv-boxes uses a hirarchy of hard-wired individual
regulators without any ability to control for most of them [aka always on].
And due to the r68 not sporting any different real pmic, I'd believe the
Orion will most likely also follow that scheme.
Heiko
next prev parent reply other threads:[~2016-01-15 14:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-15 13:06 [PATCH 1/2] devicetree: bindings: Add vendor prefix for Tronsmart Matthias Brugger
2016-01-15 13:06 ` [PATCH 2/2] arm64: dts: rockchip: Add basic support for orion-r68 Matthias Brugger
2016-01-15 13:28 ` Javier Martinez Canillas
2016-01-15 14:03 ` Heiko Stuebner [this message]
2016-01-15 14:22 ` Javier Martinez Canillas
2016-01-15 14:26 ` Heiko Stuebner
2016-01-15 15:31 ` Javier Martinez Canillas
2016-01-15 14:21 ` Mark Rutland
2016-01-16 1:22 ` Naoki FUKAUMI
2016-01-17 0:17 ` [PATCH 1/2] devicetree: bindings: Add vendor prefix for Tronsmart Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2174023.jkjdoEECkq@phil \
--to=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).