From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87B19C433F5 for ; Thu, 21 Oct 2021 12:32:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 377CF60241 for ; Thu, 21 Oct 2021 12:32:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 377CF60241 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=WJGpaBBvqU4OLeA2f77DiqZya9tA+FwCOIZH5qNLLCk=; b=uJJYs5dK2qx3liQDW5dJ4SRcXY 4ZiQi1WWKVKRlFuXwiqq2RHP1yjMDf/5cux4z+IYG15/3BoFfweyUiY/ft6rXWdRgrxS6+CpiJoh5 LxaOH73DXcRUWXS3ulWEbBcNSQGpqoQiOegPAFcVhigFPKQmk+WuobE8LAxbtQdgTSFet1km+3SB0 PPDqQNsH3+6oE9m+m+ydinbcserk4a3BLV1MpfQNVOFKXKBID8DA1Tm5lR5cauT0CzwfrW64GtVoQ uwXpWffJsE4cjRFH2qZo1VJENNMBHwCVIqfvHKLKzK8rCGdlqutXixQRLJ5tT9nxOGo8vgMiDvOph CWcqlPrQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mdXDO-007UpS-Iq; Thu, 21 Oct 2021 12:30:34 +0000 Received: from linux.microsoft.com ([13.77.154.182]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mdXDK-007UoA-Ik for linux-arm-kernel@lists.infradead.org; Thu, 21 Oct 2021 12:30:32 +0000 Received: from [192.168.254.32] (unknown [47.187.212.181]) by linux.microsoft.com (Postfix) with ESMTPSA id 8107020B7179; Thu, 21 Oct 2021 05:30:29 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 8107020B7179 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1634819430; bh=wRzipucQUyVGORKzBSV+cC6ghm4C4V7AbKJUpxlcZEU=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=NukQe+XcjzleY5DL6QhasbvKGYNgtpTDRM7oU48W0bR3dmTAyotVkE/6XObRyY73t gbYaTv6zx3BE/2nR4YIOG4KUE7cmvAWxuQ6U54fzMMbRDQDOowkqqWOiBwMvtXsSZV CDREQxgUirptxKHYe/0SxEJwCSi1gUq+o6fTU4AM= Subject: Re: [PATCH v10 03/11] arm64: Make get_wchan() use arch_stack_walk() To: Mark Brown Cc: mark.rutland@arm.com, jpoimboe@redhat.com, ardb@kernel.org, nobuta.keiya@fujitsu.com, sjitindarsingh@gmail.com, catalin.marinas@arm.com, will@kernel.org, jmorris@namei.org, linux-arm-kernel@lists.infradead.org, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org References: <20211015025847.17694-1-madvenka@linux.microsoft.com> <20211015025847.17694-4-madvenka@linux.microsoft.com> From: "Madhavan T. Venkataraman" Message-ID: <217ce31e-222b-cc10-f5e1-027e00a49cd4@linux.microsoft.com> Date: Thu, 21 Oct 2021 07:30:28 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211021_053030_700437_BEDDFBB2 X-CRM114-Status: GOOD ( 15.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org I will take a look at what Peter has done and will coordinate with him. Thanks. Madhavan On 10/20/21 11:10 AM, Mark Brown wrote: > On Thu, Oct 14, 2021 at 09:58:39PM -0500, madvenka@linux.microsoft.com wrote: >> From: "Madhavan T. Venkataraman" >> >> Currently, get_wchan() in ARM64 code walks the stack using start_backtrace() >> and unwind_frame(). Make it use arch_stack_walk() instead. This makes >> maintenance easier. > > This overlaps with some very similar updates that Peter Zijlstra is > working on which addresses some existing problems with wchan: > > https://lore.kernel.org/all/20211008111527.438276127@infradead.org/ > > It probably makes sense for you to coordinate with Peter here, some of > that series is already merged up to his patch 6 which looks very > similar to what you've got here. In that thread you'll see that Mark > Rutland spotted an issue with the handling of __switch_to() on arm64 > which probably also applies to your change. > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel