From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81945C43445 for ; Tue, 14 Jul 2020 19:05:58 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 545F422518 for ; Tue, 14 Jul 2020 19:05:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jZuBTEJu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 545F422518 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6/dciyPNXrXZ9sDZF9TyZUXtOWLSZpV5LEWQTC4SX2I=; b=jZuBTEJuzRGavRSGBJ19Nw5Gl 9WA3lBQj+EK2G4U5VVA5FXJgET/D0C8Ykt93v3LGdPcvLkutv1vxaq/u/DOAugqaWOBcGixZ6C8jE my519NeyfV1MwxI2wxAMmwZf93uPEy0BBlKtKHSYmENrGgpS8Jix+P2hQvZL00/0i2TkpvgqTMdsN BLyRvPyJA6n5CLyaygy95K4Lfb9uNxig9VtPMUTRGEZiEuYgWlZtmPIBdJ5H7Yy6LqCo64OLwn8GO 4V2vU1xhInI6gGwtPG7ZmxWmwyp1VBeK2uPCXobt4x+CKPsJ6sYN9j7Bz3KovkTymdGEZFKcwL82K u3Wk2+V9Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvQEL-0000Gn-B9; Tue, 14 Jul 2020 19:04:41 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvQEJ-0000GH-KN; Tue, 14 Jul 2020 19:04:40 +0000 Received: from x2f7fa33.dyn.telefonica.de ([2.247.250.51] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jvQEI-0000LX-HB; Tue, 14 Jul 2020 21:04:38 +0200 From: Heiko Stuebner To: Jagan Teki Subject: Re: [PATCH v5 1/4] arm64: dts: rockchip: Trivial cleanups for RockPI N10 Date: Tue, 14 Jul 2020 21:04:37 +0200 Message-ID: <21801049.BKhHgEE1TG@phil> In-Reply-To: <20200709100756.42384-2-jagan@amarulasolutions.com> References: <20200709100756.42384-1-jagan@amarulasolutions.com> <20200709100756.42384-2-jagan@amarulasolutions.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200714_150439_679707_80D5B34B X-CRM114-Status: GOOD ( 13.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Rob Herring , Suniel Mahesh , Michael Trimarchi , linux-amarula , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Donnerstag, 9. Juli 2020, 12:07:53 CEST schrieb Jagan Teki: > Radxa dalang carrier boards are used to mount vmarc SoM's > of rk3399pro and rk3288 to make complete SBC. > > So, this patch adds trivial changes to properties. > - move common properties into radxa dalang carrier dtsi. > - maintain ascending order for nodes, properties. > - change the order of dtsi include so-that common properties > will reflect in main dts. > - drop unnecessary header includes. can you please split this patch into bits at these marks? (1) moving common (2) sorting ... It's hard to follow and especially verify. > diff --git a/arch/arm64/boot/dts/rockchip/rk3399pro-vmarc-som.dtsi b/arch/arm64/boot/dts/rockchip/rk3399pro-vmarc-som.dtsi > index 0a516334f15f..9ed5b27d715c 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399pro-vmarc-som.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3399pro-vmarc-som.dtsi > @@ -7,35 +7,12 @@ > > #include > #include > -#include > > / { > compatible = "vamrs,rk3399pro-vmarc-som", "rockchip,rk3399pro"; > > - clkin_gmac: external-gmac-clock { > - compatible = "fixed-clock"; > - clock-frequency = <125000000>; > - clock-output-names = "clkin_gmac"; > - #clock-cells = <0>; > - }; > - > - vcc12v_dcin: vcc12v-dcin-regulator { > - compatible = "regulator-fixed"; > - regulator-name = "vcc12v_dcin"; > - regulator-always-on; > - regulator-boot-on; > - regulator-min-microvolt = <12000000>; > - regulator-max-microvolt = <12000000>; > - }; > - > - vcc5v0_sys: vcc5v0-sys-regulator { > - compatible = "regulator-fixed"; > - regulator-name = "vcc5v0_sys"; > - regulator-always-on; > - regulator-boot-on; > - regulator-min-microvolt = <5000000>; > - regulator-max-microvolt = <5000000>; > - vin-supply = <&vcc12v_dcin>; > + chosen { > + stdout-path = "serial2:1500000n8"; isn't chosen more a property of the individual board combination? So to me this should live in the rk3399pro-rock-pi-n10.dts . As other board even using the rk3399pro variant may want to use a different uart for serial output. Heiko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel