* [PATCH -next] mailbox: rockchip: fix a typo in module autoloading
@ 2024-08-14 2:51 Liao Chen
2024-08-14 6:13 ` Heiko Stübner
2024-08-22 8:35 ` liaochen (A)
0 siblings, 2 replies; 3+ messages in thread
From: Liao Chen @ 2024-08-14 2:51 UTC (permalink / raw)
To: linux-rockchip, linux-arm-kernel; +Cc: linux-kernel, jassisinghbrar, heiko, wxt
MODULE_DEVICE_TABLE(of, rockchip_mbox_of_match) could let the module
properly autoloaded based on the alias from of_device_id table. It
should be 'rockchip_mbox_of_match' instead of 'rockchp_mbox_of_match',
just fix it.
Fixes: f70ed3b5dc8b ("mailbox: rockchip: Add Rockchip mailbox driver")
Signed-off-by: Liao Chen <liaochen4@huawei.com>
---
drivers/mailbox/rockchip-mailbox.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mailbox/rockchip-mailbox.c b/drivers/mailbox/rockchip-mailbox.c
index 8ffad059e898..4d966cb2ed03 100644
--- a/drivers/mailbox/rockchip-mailbox.c
+++ b/drivers/mailbox/rockchip-mailbox.c
@@ -159,7 +159,7 @@ static const struct of_device_id rockchip_mbox_of_match[] = {
{ .compatible = "rockchip,rk3368-mailbox", .data = &rk3368_drv_data},
{ },
};
-MODULE_DEVICE_TABLE(of, rockchp_mbox_of_match);
+MODULE_DEVICE_TABLE(of, rockchip_mbox_of_match);
static int rockchip_mbox_probe(struct platform_device *pdev)
{
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH -next] mailbox: rockchip: fix a typo in module autoloading
2024-08-14 2:51 [PATCH -next] mailbox: rockchip: fix a typo in module autoloading Liao Chen
@ 2024-08-14 6:13 ` Heiko Stübner
2024-08-22 8:35 ` liaochen (A)
1 sibling, 0 replies; 3+ messages in thread
From: Heiko Stübner @ 2024-08-14 6:13 UTC (permalink / raw)
To: linux-rockchip, linux-arm-kernel, Liao Chen
Cc: linux-kernel, jassisinghbrar, wxt
Am Mittwoch, 14. August 2024, 04:51:47 CEST schrieb Liao Chen:
> MODULE_DEVICE_TABLE(of, rockchip_mbox_of_match) could let the module
> properly autoloaded based on the alias from of_device_id table. It
> should be 'rockchip_mbox_of_match' instead of 'rockchp_mbox_of_match',
> just fix it.
>
> Fixes: f70ed3b5dc8b ("mailbox: rockchip: Add Rockchip mailbox driver")
> Signed-off-by: Liao Chen <liaochen4@huawei.com>
nice catch :-)
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] mailbox: rockchip: fix a typo in module autoloading
2024-08-14 2:51 [PATCH -next] mailbox: rockchip: fix a typo in module autoloading Liao Chen
2024-08-14 6:13 ` Heiko Stübner
@ 2024-08-22 8:35 ` liaochen (A)
1 sibling, 0 replies; 3+ messages in thread
From: liaochen (A) @ 2024-08-22 8:35 UTC (permalink / raw)
To: linux-rockchip, linux-arm-kernel
On 2024/8/14 10:51, Liao Chen wrote:
> MODULE_DEVICE_TABLE(of, rockchip_mbox_of_match) could let the module
> properly autoloaded based on the alias from of_device_id table. It
> should be 'rockchip_mbox_of_match' instead of 'rockchp_mbox_of_match',
> just fix it.
>
> Fixes: f70ed3b5dc8b ("mailbox: rockchip: Add Rockchip mailbox driver")
> Signed-off-by: Liao Chen <liaochen4@huawei.com>
> ---
> drivers/mailbox/rockchip-mailbox.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mailbox/rockchip-mailbox.c b/drivers/mailbox/rockchip-mailbox.c
> index 8ffad059e898..4d966cb2ed03 100644
> --- a/drivers/mailbox/rockchip-mailbox.c
> +++ b/drivers/mailbox/rockchip-mailbox.c
> @@ -159,7 +159,7 @@ static const struct of_device_id rockchip_mbox_of_match[] = {
> { .compatible = "rockchip,rk3368-mailbox", .data = &rk3368_drv_data},
> { },
> };
> -MODULE_DEVICE_TABLE(of, rockchp_mbox_of_match);
> +MODULE_DEVICE_TABLE(of, rockchip_mbox_of_match);
>
> static int rockchip_mbox_probe(struct platform_device *pdev)
> {
Gentle ping
Thanks,
Chen
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-08-22 8:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-14 2:51 [PATCH -next] mailbox: rockchip: fix a typo in module autoloading Liao Chen
2024-08-14 6:13 ` Heiko Stübner
2024-08-22 8:35 ` liaochen (A)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox