From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 48F5FEB64D8 for ; Thu, 22 Jun 2023 15:21:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aY/ZNp98aZANhPS/StZ+mA2JcXAz9kQaIpqa0O1YSTI=; b=U2GnOCFE4jic3P YwgtvBugo9hU3x3w/zl8TyjLdU21ArthtrDdqkvOSAW6RRLY1mqMXS3eXV7UMAzJ+XiSFdLIzo5Zc IAvC8/8dVOFfb3pWVeRMiIZKmFJUmdCnpjiim3Y+PYFEg8+hH0OCAvjJ82+Y8tfwA/+fcYbr2pcxY eIHliQK14Bp2g7D0zLJPszaXK2XDxQ1r7A93LCPwPL6xXhL0pnm90dqM3O5+fWPfEAlN1r3XuVkhE zKsM+OmYh4ornrCv+bA7R0cTAWd597uzSNsaCAcM2u8tqjSfWU8d3ehl8nh3DXE8S5LHeD/mNBlGd zOxcDPpkJoRLnRHDSgGw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qCM7K-0016yU-2u; Thu, 22 Jun 2023 15:21:02 +0000 Received: from mail-lf1-x12e.google.com ([2a00:1450:4864:20::12e]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qCM7I-0016xu-2P for linux-arm-kernel@lists.infradead.org; Thu, 22 Jun 2023 15:21:02 +0000 Received: by mail-lf1-x12e.google.com with SMTP id 2adb3069b0e04-4f86e1bdce5so7410946e87.3 for ; Thu, 22 Jun 2023 08:20:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687447258; x=1690039258; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=c9Nib1mjQ7HUVslIx9EtURK9z/yS/7mpl1B4Ox7/c/s=; b=g15tA4+CNcniYf/OcLJKZt2ymRKzXESCDfPItGGf4pXM5u5X0DdAweQxDe+YuHymKN HCYHcv4nhoMVPTvohDVk/2XxmWYeXhzfneaiKr082wMmGHZ2GKygtvUPPAEA524UAtxy bmcqY6FuJBxlZe8TchhILJkH1GYMoqDZZEBGqK2JPaVajS3v2KvZYyenL/6VbHYFgEeg VFfCihnzU9iwpvPRInH6mOxO8kkOUvkprS1mAxdvP3NFkz4XNjgeI9L8lqcM7R8ApVzi DdPjtgvLR6ALfJQsKO6aF4PCymSNHzbj+dW7iimcPMQfrmOhBVn6daWWPgAUTd+M+PGG 6g3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687447258; x=1690039258; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=c9Nib1mjQ7HUVslIx9EtURK9z/yS/7mpl1B4Ox7/c/s=; b=QmuO8lpYK/ROD0XP2zkJ33yf+oc7/vkWj5Avl667wRkc650m/ebTpDeP9GaaGi1KII zVTjaR8wEKw3Bo3fBuNrTb1goZ0Ojnfn5fwgZVEAghj05m/HM/lVZfQTJ/mp3403bMOa gXn5DChD+lfM3Aj2qU2aGVhascWqNdYLB1BASj8kVgVa4yyap8bfmxR3U6IPqLPnDlOm ocNzgJSh6VocaqpN+5ZA2t9T6EfFsvOeEDZDFkJyMaHHkZgxfpoJflXWnWYX8YPuFGCX GVoA/X1zAVV8FH8D6PrvTsuTkGEgzQgLVtMs9gS8AkwcYPDbN0p8i5UJOEe6yyBlhZZw S5rQ== X-Gm-Message-State: AC+VfDzKD1X52Bv90wfsOCu1oPcHGGiKsQ9QCO2/1OwQn9DJFaBQzRV0 RiRGN6bSyFZSGe8YoP5IQ+ynxw== X-Google-Smtp-Source: ACHHUZ65em47HxJ5uP2ScMq4wC1WUQ8IS3y4pSQ5ePJuf0EI86kFZ1IXZW0p0liht+sUtKhW1HKrpA== X-Received: by 2002:a19:6446:0:b0:4e9:bafc:88d0 with SMTP id b6-20020a196446000000b004e9bafc88d0mr11095123lfj.23.1687447257858; Thu, 22 Jun 2023 08:20:57 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id d7-20020a056402516700b00514bcbfd9e0sm4134273ede.46.2023.06.22.08.20.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Jun 2023 08:20:57 -0700 (PDT) Message-ID: <218a76d9-d00b-3856-80b1-7d2f11b4ff1f@linaro.org> Date: Thu, 22 Jun 2023 17:20:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 7/7] arm64: dts: qcom: msm8916-samsung-fortuna: Add NFC Content-Language: en-US To: "Lin, Meng-Bo" , linux-kernel@vger.kernel.org Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Arnd Bergmann , Olof Johansson , Stephan Gerhold , Nikita Travkin , soc@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, ~postmarketos/upstreaming@lists.sr.ht, Joe Mason References: <20230622000007.48219-1-linmengbo0689@protonmail.com> <20230622000437.48367-1-linmengbo0689@protonmail.com> From: Krzysztof Kozlowski In-Reply-To: <20230622000437.48367-1-linmengbo0689@protonmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230622_082100_788591_0D46E970 X-CRM114-Status: GOOD ( 22.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 22/06/2023 02:05, Lin, Meng-Bo wrote: > From: Joe Mason > > The Samsung Galaxy Ace 4, Core Prime and some Grand Prime have a > Samsung S3FWRN5 NFC chip that works quite well with the s3fwrn5 driver > in the Linux NFC subsystem. > > The clock setup for the NFC chip is a bit special (although this > seems to be a common approach used for Qualcomm devices with NFC): > > The NFC chip has an output GPIO that is asserted whenever the clock > is needed to function properly. On the A3/A5 this is wired up to > PM8916 GPIO2, which is then configured with a special function > (NFC_CLK_REQ or BB_CLK2_REQ). > > Enabling the rpmcc RPM_SMD_BB_CLK2_PIN clock will then instruct > PM8916 to automatically enable the clock whenever the NFC chip > requests it. The advantage is that the clock is only enabled when > needed and we don't need to manage it ourselves from the NFC driver. > > Grand Prime SM-G530Y (fortunaltezt) has a NXP PN547, which is supported > by the nxp-nci-i2c driver in mainline. > > It seems to detect NFC tags using "nfctool" just fine, although more > testing is difficult given there seem to be very few useful applications > making use of the Linux NFC subsystem. > > Signed-off-by: Joe Mason > [Put i2c-nfc and NFC pinctrl into fortuna.dtsi to share it with other variants] > Signed-off-by: Stephan Gerhold This and other SoB chains look like missing Co-developed-by. > [Add pn547_nfc] > Signed-off-by: Lin, Meng-Bo > --- > + /* Available NFC chip varies depending on model variant */ > + pn547_nfc: nfc@2b { > + compatible = "nxp,pn547", "nxp,nxp-nci-i2c"; > + reg = <0x2b>; > + > + interrupt-parent = <&tlmm>; > + interrupts = <21 IRQ_TYPE_EDGE_RISING>; > + > + enable-gpios = <&tlmm 20 GPIO_ACTIVE_HIGH>; > + firmware-gpios = <&tlmm 49 GPIO_ACTIVE_HIGH>; > + > + pinctrl-0 = <&nfc_default>; > + pinctrl-names = "default"; > + > + status = "disabled"; > + }; > + > + s3fwrn5_nfc: nfc@27 { > + compatible = "samsung,s3fwrn5-i2c"; > + reg = <0x27>; > + > + interrupt-parent = <&tlmm>; > + interrupts = <21 IRQ_TYPE_EDGE_RISING>; > + > + en-gpios = <&tlmm 20 GPIO_ACTIVE_HIGH>; > + wake-gpios = <&tlmm 49 GPIO_ACTIVE_HIGH>; > + > + clocks = <&rpmcc RPM_SMD_BB_CLK2_PIN>; > + > + pinctrl-0 = <&nfc_default>, <&nfc_clk_req>; > + pinctrl-names = "default"; > + > + status = "disabled"; Common part does not have two NFCs. It seems common part has zero NFCs... or should be put into different file. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel