From: "Jernej Škrabec" <jernej.skrabec@gmail.com>
To: Chen-Yu Tsai <wens@csie.org>,
Samuel Holland <samuel@sholland.org>,
Yangtao Li <frank.li@vivo.com>
Cc: Yangtao Li <frank.li@vivo.com>,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/7] bus: sunxi-rsb: Convert to devm_platform_ioremap_resource()
Date: Tue, 11 Jul 2023 20:25:55 +0200 [thread overview]
Message-ID: <21938707.EfDdHjke4D@jernej-laptop> (raw)
In-Reply-To: <20230706072042.31296-1-frank.li@vivo.com>
Dne četrtek, 06. julij 2023 ob 09:20:36 CEST je Yangtao Li napisal(a):
> Use devm_platform_ioremap_resource() to simplify code.
>
> Signed-off-by: Yangtao Li <frank.li@vivo.com>
Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Best regards,
Jernej
> ---
> drivers/bus/sunxi-rsb.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/bus/sunxi-rsb.c b/drivers/bus/sunxi-rsb.c
> index 696c0aefb0ca..2aefd5dde3c9 100644
> --- a/drivers/bus/sunxi-rsb.c
> +++ b/drivers/bus/sunxi-rsb.c
> @@ -746,7 +746,6 @@ static int sunxi_rsb_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> struct device_node *np = dev->of_node;
> - struct resource *r;
> struct sunxi_rsb *rsb;
> u32 clk_freq = 3000000;
> int irq, ret;
> @@ -766,8 +765,7 @@ static int sunxi_rsb_probe(struct platform_device *pdev)
> rsb->dev = dev;
> rsb->clk_freq = clk_freq;
> platform_set_drvdata(pdev, rsb);
> - r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - rsb->regs = devm_ioremap_resource(dev, r);
> + rsb->regs = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(rsb->regs))
> return PTR_ERR(rsb->regs);
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-07-11 18:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-06 7:20 [PATCH 1/7] bus: sunxi-rsb: Convert to devm_platform_ioremap_resource() Yangtao Li
2023-07-06 7:20 ` [PATCH 6/7] bus: vexpress-config: " Yangtao Li
2023-07-19 10:06 ` [PATCH 6/7] " Sudeep Holla
2023-07-11 18:25 ` Jernej Škrabec [this message]
2023-07-21 15:28 ` (subset) [PATCH 1/7] bus: sunxi-rsb: " Thierry Reding
2023-07-30 22:50 ` Jernej Škrabec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21938707.EfDdHjke4D@jernej-laptop \
--to=jernej.skrabec@gmail.com \
--cc=frank.li@vivo.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox