From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EF63C43381 for ; Fri, 1 Mar 2019 10:07:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EE97E2085A for ; Fri, 1 Mar 2019 10:07:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="N1g/5nq2"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=microchiptechnology.onmicrosoft.com header.i=@microchiptechnology.onmicrosoft.com header.b="PHX9uykn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EE97E2085A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=microchip.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4Xj2BSjdVsBS5vyv6GYo9kA1kHl0V090R1BZ1qQ+FWs=; b=N1g/5nq22ODkR2 NVeFH8rIpo0nejSSFseEtO8EBBnWRIeyWzKrUoytdsGpJDCBV2v86yL7yXWHTywfO1/VaUMHfj6FZ XtU2lLm0IenKyKbxB/jB1Pbi0Pbl2fW0uMXyqKHa4pj1ZagXf6fKFf6ACgKp5P7efQJwaST19UDrp FhtecS8dIzysC5vTHVP8BJ3k2malgIgliQOJmxP6FNuGqqL5x43DuHrfTu3ZRwsj1I+PbKFM6b14A I6W226Rr4HlhS6DiRfaruLmfq2oMA8jlMp3WAgc/u2BqoLeuY0xQ8OpDPYBMEzut7eb8MypX2s5aT AHyd2gNjQt6ppSjshstw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gzf4S-0003kQ-QW; Fri, 01 Mar 2019 10:07:12 +0000 Received: from esa5.microchip.iphmx.com ([216.71.150.166]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gzf4M-0003a6-S0 for linux-arm-kernel@lists.infradead.org; Fri, 01 Mar 2019 10:07:09 +0000 X-IronPort-AV: E=Sophos;i="5.58,427,1544511600"; d="scan'208";a="25445159" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa5.microchip.iphmx.com with ESMTP/TLS/AES128-SHA; 01 Mar 2019 03:07:06 -0700 Received: from NAM01-BY2-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.76.37) with Microsoft SMTP Server (TLS) id 14.3.352.0; Fri, 1 Mar 2019 03:07:05 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector1-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=10VxLXXQTeXnUfUpgemuxC5j/O+ASjjCErbMaD7TZz0=; b=PHX9uyknxpESxa/WwNstSh/vkqARrhYz0GzqEoB3HGk8hW1STFwl2sqgJaG+K156rv+iNLpGPkPijdkm35z1bOqeHOGKGBksb7B2Tz8xr5O2HLNqfVpZbOrfPrDGGBTwJWsmE1h7fvxscBu2AYGoUoDFH6OcaIFIisK6Hid1ZJE= Received: from MWHPR11MB1549.namprd11.prod.outlook.com (10.172.54.17) by MWHPR11MB1309.namprd11.prod.outlook.com (10.169.237.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1665.15; Fri, 1 Mar 2019 10:07:02 +0000 Received: from MWHPR11MB1549.namprd11.prod.outlook.com ([fe80::54fe:95ed:b0cf:55a6]) by MWHPR11MB1549.namprd11.prod.outlook.com ([fe80::54fe:95ed:b0cf:55a6%8]) with mapi id 15.20.1643.022; Fri, 1 Mar 2019 10:07:02 +0000 From: To: Subject: Re: [PATCH 1/7] drm: atmel-hlcdc: add config option for clock selection Thread-Topic: [PATCH 1/7] drm: atmel-hlcdc: add config option for clock selection Thread-Index: AQHUzrjibzNyakqaO0avPILToqBAJKX1uvIAgADUjgA= Date: Fri, 1 Mar 2019 10:07:02 +0000 Message-ID: <21942343-5e76-2fa3-b394-c1cef4abd9e1@microchip.com> References: <1551284609-14594-1-git-send-email-claudiu.beznea@microchip.com> <1551284609-14594-2-git-send-email-claudiu.beznea@microchip.com> <20190228212558.GB30188@ravnborg.org> In-Reply-To: <20190228212558.GB30188@ravnborg.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: VI1PR08CA0196.eurprd08.prod.outlook.com (2603:10a6:800:d2::26) To MWHPR11MB1549.namprd11.prod.outlook.com (2603:10b6:301:c::17) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Claudiu.Beznea@microchip.com; x-ms-exchange-messagesentrepresentingtype: 1 x-tagtoolbar-keys: D20190301120644299 x-originating-ip: [94.177.32.154] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4a161952-4ae2-406e-2c5f-08d69e2da68c x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(2017052603328)(7153060)(7193020); SRVR:MWHPR11MB1309; x-ms-traffictypediagnostic: MWHPR11MB1309: x-microsoft-exchange-diagnostics: =?utf-8?B?MTtNV0hQUjExTUIxMzA5OzIzOlByM1daWnJhT21XQ2txRWI0dk5PdWNGcXN6?= =?utf-8?B?NTV4Unh1QmZ0SXQzUXI1UHBVNjFFKzhzRGNDaGJmbXlxWVF1V0p2Z1NjbytO?= =?utf-8?B?eG9ZWkdJSUk2Z2h4R3J2WEwrZFlqa3NtUXJ6dit6eCtqL1NtSjdhaFU1TW5t?= =?utf-8?B?Ny9sRE1EcHVTWE9ORHBtK3BWbk1DT0JZYjFwNlpoVjgzeE0rNFVYZmxpYTAx?= =?utf-8?B?VzFVdnBrS1FqS3RwVlhNcGpOaFdYZkNvSGNnY1o0Q1ZsdlBnT0FQR2xWSEVt?= =?utf-8?B?enNUYWpUSXhUNjhhdnUzWlhsNFZrK3l4VUw1WnpkcXN5RUFockJwaXovUnhY?= =?utf-8?B?NTlNcVV6Z0NpY3ZaOWFneWRRUGkreUdpYUxCa20wVGVMblBoRkdYK2hVUm1M?= =?utf-8?B?YnVTTVRybUV1V3lwOVBJNW4yVWFpMXZCdDVhZmZMS0VHV0ZSbk01QlIwU09l?= =?utf-8?B?QkdYTlByNmRPZUdPbWNLR3ZJZk5ITk1Pem9WcnJEWWRoeE51RCt1U2JuRDBt?= =?utf-8?B?YTM5Z2cwdnpNMmlpN3BwY2FIdEVOZG5hb3FmR056TlFkdUw4TW8ySkVFQlpX?= =?utf-8?B?bllwQXoydk1DdXc4aXZaY011YjRubFkvUFdEVnZjY09VQzh5M0pJVmI3ckw2?= =?utf-8?B?T0RLRjdwUHlsazFYY2p6ckgvUVNaS1lpTmU2cERYSDlEUEJDU21sTEQ1MjJj?= =?utf-8?B?WWZ5WkFKQThHOVc1UC9GbGM5UE0wcldRck44U2t0RHcxOFdkclBTTFMxMmhP?= =?utf-8?B?bE5TMG9Pd1BYMlR0YnpkQkMraXhuVXpkaUZ4WkRUckQ0cWhyQmIrTURvMzdx?= =?utf-8?B?K1gyR2lpY1BHRzFzdjYxZVUwMVpjd0N4S0lZbElrZWoxbHd6MTh6K3VpZGVj?= =?utf-8?B?UkptVmloN0FUck9KV1NGbkorYkpFeXIyZENZc3F6M3FXR1pEenkrMGNDN0xo?= =?utf-8?B?aHJPQmxRTnJuWW1Xd3JiZlZIUVhRUG5WRjVORXpEZk5mNFFIck5FZG1CYito?= =?utf-8?B?Yyt6aGcwOXpmZWdpM3J5a1lna2NRaWpsRXJkKzZCdk5QYzJ0MnBYdTNHK1Rm?= =?utf-8?B?VnFSUTYyVUFpRnk2NEFwSk5tSVBkWDRZc08zQmJZazhkQ0J1L3pYRXRuMEsz?= =?utf-8?B?QmcwaEpwdVNVSEJrbnV2Uk1rOXlUa1ZTVmZIM2Vhdll5eGw4elE4ejNzOXVs?= =?utf-8?B?aERNQnFnT2kvYVNWYUlLME0yRDluL2F4WkRuRm1qajNzM0VaY3RuVlZFYlRN?= =?utf-8?B?Z21ZMEs5c3hSUHZMaUxJbkZTanFsMzVQTzIwc1oxOE12dUE4SjFVTmVFeFYz?= =?utf-8?B?bjlxb3Z1Z2c0VUZMOGVodFRITVlzcVBWTjZuMmJCcDFnb0xiZnNNczhBUldu?= =?utf-8?B?aWR4WUFydC9lSlpoenkyREdPanBKMnRmUTFOWXIwTy9CM3pncEFqUkZyRHNp?= =?utf-8?B?aFBmU2REMk5vb0h1Q2M1UW5WdmR2aXNsQ3JZVTROcWFrMWtRRDB2QnFNTDVr?= =?utf-8?B?T0ppYWpsd1pzRW5ETHRENXVuTmcwOC8wRG5UZ0M4SWtzTmRmZGY1SWFpWDlW?= =?utf-8?B?VmhKa3kvS3ZWdFhCTlZKZ3hrdXQvUVRGZkNJZnViNEdIWmZFeStUVXZuR2lk?= =?utf-8?B?ZmlLVzN6RHNYTmxPdWZoaTNXeWtjQklMbExWNWFwZGQvRlMxQlZjMHBIaDVF?= =?utf-8?B?MEhNTVpqZ0Mra1QralVJTUhneW1RKzFSbndhSEdmNStIMjVvVU5tNENVdlhD?= =?utf-8?Q?FxleuoEZFonnZZuqyRCM2zroMCrLRNciKeTz4=3D?= x-microsoft-antispam-prvs: x-forefront-prvs: 09634B1196 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(376002)(346002)(136003)(366004)(39860400002)(199004)(189003)(11346002)(6116002)(2616005)(14454004)(6916009)(229853002)(54906003)(8936002)(305945005)(478600001)(66066001)(316002)(446003)(7736002)(68736007)(6486002)(105586002)(106356001)(81166006)(81156014)(6436002)(8676002)(99286004)(72206003)(76176011)(52116002)(3846002)(476003)(2906002)(31686004)(36756003)(486006)(53546011)(6506007)(25786009)(386003)(26005)(31696002)(86362001)(6512007)(186003)(71190400001)(71200400001)(53936002)(256004)(7416002)(102836004)(5660300002)(6246003)(97736004)(4326008); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR11MB1309; H:MWHPR11MB1549.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: microchip.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: S5wfbPlEN9X+xKwtOaRQvQOSXtYO6k7nxU20KIOoWUB3BE5LabrDGNl/uhgrD0wLZ7dfgJIrTQv1jItoA09Y5LoKWP8DkN3it/5URE2Lz04Fjgd+/Yw3FeivU5Kz2XIo+j2SwkN1RzZCBR2s5zT+Bqyxuq9a2JvnBSK169zFqqZ/W7RM4A9e/UuynUQlEV/qhICyhhlwqnE4dQ2nu+t0kWQDX0kgyyFCLk354VXZ7b9g4p4hqxoYGJpslxcSSSWW8q/eUjSKyviwwBLH3fKPT91vXKRLYN3rm9Qb53C4uDCR9EvJE4gJ89/bmbd07UQRYXeZXnCsubNueOsowmEfb/eSX5G+6dGBMitkUnWms5cRusWTvy5+XywSThkmm/C18G6huc8Pv78E2AZZOCQBid7JvY83zc8OZVmCrvCVRPI= Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 4a161952-4ae2-406e-2c5f-08d69e2da68c X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Mar 2019 10:06:57.9746 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1309 X-OriginatorOrg: microchip.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190301_020707_216871_282CDA1C X-CRM114-Status: GOOD ( 18.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, alexandre.belloni@bootlin.com, bbrezillon@kernel.org, airlied@linux.ie, linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org, Ludovic.Desroches@microchip.com, robh+dt@kernel.org, thierry.reding@gmail.com, dri-devel@lists.freedesktop.org, daniel@ffwll.ch, lee.jones@linaro.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 28.02.2019 23:25, Sam Ravnborg wrote: > Hi Claudiu > > On Wed, Feb 27, 2019 at 04:24:16PM +0000, Claudiu.Beznea@microchip.com wrote: >> From: Claudiu Beznea >> >> SAM9x60 LCD Controller has no option to select clock source as previous >> controllers have. To be able to use the same driver even for this LCD >> controller add a config option to know if controller supports this. >> >> Signed-off-by: Claudiu Beznea >> --- >> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 12 +++++++----- >> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h | 2 ++ >> 2 files changed, 9 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c >> index 8070a558d7b1..17a7a18f6a07 100644 >> --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c >> +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c >> @@ -78,7 +78,8 @@ static void atmel_hlcdc_crtc_mode_set_nofb(struct drm_crtc *c) >> unsigned long mode_rate; >> struct videomode vm; >> unsigned long prate; >> - unsigned int cfg; >> + unsigned int mask = ATMEL_HLCDC_CLKDIV_MASK | ATMEL_HLCDC_CLKPOL; >> + unsigned int cfg = 0; >> int div; > Here cfg and mask has initial values. > >> >> vm.vfront_porch = adj->crtc_vsync_start - adj->crtc_vdisplay; >> @@ -101,7 +102,10 @@ static void atmel_hlcdc_crtc_mode_set_nofb(struct drm_crtc *c) >> (adj->crtc_hdisplay - 1) | >> ((adj->crtc_vdisplay - 1) << 16)); >> >> - cfg = ATMEL_HLCDC_CLKSEL; >> + if (!crtc->dc->desc->fixed_clksrc) { >> + cfg = ATMEL_HLCDC_CLKSEL; >> + mask |= ATMEL_HLCDC_CLKSEL; >> + } > And here mask is bitwise or with ATMEL_HLCDC_CLKSEL - fine. > But cfg is directly assigned. I directly assigned it here because it was the first time it was used. I will use a "|" operation as you suggest in next version. > If cfg was bitwise or the ATMEL_HLCDC_CLKSEL value then the code was prepared > to have extra flags added above these lines. > > Only a small change and no functional difference. > > With or without this change: > Reviewed-by: Sam Ravnborg > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel