From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 560D3C6FA82 for ; Tue, 13 Sep 2022 10:14:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sfsZDgRkI1Ma3TXthC42mlqSHSa96qJPqtQnd37ttqQ=; b=2APvDBVN8VDl+7 tZqSQUKI+eiU1XVsbSTQDsgSL46C702hvEt4t+OHHQ9TUmAmZc5UsUEBkFT8IIKZyii+hizKUCqn9 qumhOB/O1Rc4pF8KCtt3uLryD+aGvDGQiJXfqWvymmgD+UgF4ctkIjd6u05L/AsLXhynGmyXDk6sY TRzrF1/0QCahW4q/Wh2spM7PWNuT50I2FoKgz3oh/3swHZ/rp5gtFEiUDzl6ysAqH/akV2weq0aEP Ff1x60XJvZhmxxkkrx5otIMSMBgh1omc9LEdQHYdb6Z4hCdlkmr8vogYA1qwwWJlAJYAqqdY86xVy KkktI7ZzyHLacrlZZx9A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oY2um-006JFJ-94; Tue, 13 Sep 2022 10:13:12 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oY2ug-006J3C-4c; Tue, 13 Sep 2022 10:13:08 +0000 Received: from [185.122.133.20] (helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oY2ue-00042A-QF; Tue, 13 Sep 2022 12:13:04 +0200 From: Heiko Stuebner To: Rob Herring , Krzysztof Kozlowski , Kever Yang , Jagan Teki Cc: linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, Jagan Teki , linux-clk@vger.kernel.org, Michael Turquette , Stephen Boyd , Finley Xiao Subject: Re: [PATCH v4 05/13] clk: rockchip: Add clock controller support for RV1126 SoC. Date: Tue, 13 Sep 2022 12:13:03 +0200 Message-ID: <2196383.iZASKD2KPV@phil> In-Reply-To: <20220907160207.3845791-6-jagan@edgeble.ai> References: <20220907160207.3845791-1-jagan@edgeble.ai> <20220907160207.3845791-6-jagan@edgeble.ai> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220913_031307_246132_BC6E6888 X-CRM114-Status: GOOD ( 16.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Jagan, Am Mittwoch, 7. September 2022, 18:01:59 CEST schrieb Jagan Teki: > Clock & Reset Unit (CRU) in RV1126 support clocks for CRU > and CRU_PMU blocks. > > This patch is trying to add minimal Clock-Architecture Diagram's > inferred from [1] authored by Finley Xiao. > > [1] https://github.com/rockchip-linux/kernel/blob/develop-4.19/drivers/clk/rockchip/clk-rv1126.c > > Cc: linux-clk@vger.kernel.org > Cc: Michael Turquette > Cc: Stephen Boyd > Signed-off-by: Finley Xiao > Signed-off-by: Jagan Teki > --- [...] > +static void __init rv1126_pmu_clk_init(struct device_node *np) > +{ > + struct rockchip_clk_provider *ctx; > + void __iomem *reg_base; > + > + reg_base = of_iomap(np, 0); > + if (!reg_base) { > + pr_err("%s: could not map cru pmu region\n", __func__); > + return; > + } > + > + ctx = rockchip_clk_init(np, reg_base, CLKPMU_NR_CLKS); > + if (IS_ERR(ctx)) { > + pr_err("%s: rockchip pmu clk init failed\n", __func__); > + return; > + } > + > + rockchip_clk_register_plls(ctx, rv1126_pmu_pll_clks, > + ARRAY_SIZE(rv1126_pmu_pll_clks), > + RV1126_GRF_SOC_STATUS0); > + > + rockchip_clk_register_branches(ctx, rv1126_clk_pmu_branches, > + ARRAY_SIZE(rv1126_clk_pmu_branches)); > + > + rockchip_register_softrst(np, 2, reg_base + RV1126_PMU_SOFTRST_CON(0), > + ROCKCHIP_SOFTRST_HIWORD_MASK); > + > + rockchip_clk_of_add_provider(np, ctx); > +} > + > +CLK_OF_DECLARE(rv1126_cru_pmu, "rockchip,rv1126-pmucru", rv1126_pmu_clk_init); both of these want to be platform-drivers nowadays. Take a look at rk3399 and rk3568 for reference. Thanks Heiko > + > +static void __init rv1126_clk_init(struct device_node *np) > +{ > + struct rockchip_clk_provider *ctx; > + void __iomem *reg_base; > + > + reg_base = of_iomap(np, 0); > + if (!reg_base) { > + pr_err("%s: could not map cru region\n", __func__); > + return; > + } > + > + ctx = rockchip_clk_init(np, reg_base, CLK_NR_CLKS); > + if (IS_ERR(ctx)) { > + pr_err("%s: rockchip clk init failed\n", __func__); > + iounmap(reg_base); > + return; > + } > + > + rockchip_clk_register_plls(ctx, rv1126_pll_clks, > + ARRAY_SIZE(rv1126_pll_clks), > + RV1126_GRF_SOC_STATUS0); > + > + rockchip_clk_register_armclk(ctx, ARMCLK, "armclk", > + mux_armclk_p, ARRAY_SIZE(mux_armclk_p), > + &rv1126_cpuclk_data, rv1126_cpuclk_rates, > + ARRAY_SIZE(rv1126_cpuclk_rates)); > + > + rockchip_clk_register_branches(ctx, rv1126_clk_branches, > + ARRAY_SIZE(rv1126_clk_branches)); > + > + rockchip_register_softrst(np, 15, reg_base + RV1126_SOFTRST_CON(0), > + ROCKCHIP_SOFTRST_HIWORD_MASK); > + > + rockchip_register_restart_notifier(ctx, RV1126_GLB_SRST_FST, NULL); > + > + rockchip_clk_protect_critical(rv1126_cru_critical_clocks, > + ARRAY_SIZE(rv1126_cru_critical_clocks)); > + > + rockchip_clk_of_add_provider(np, ctx); > +} > + > +CLK_OF_DECLARE(rv1126_cru, "rockchip,rv1126-cru", rv1126_clk_init); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel