From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AFC3AC5320E for ; Mon, 19 Aug 2024 11:36:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=N15B/fpX6Wf+7yRZPzvZUR8uMg/qc8/OqC4E1tAFR00=; b=S5xvymahq5nru5xX93IrmMXUC/ rnIFuVRGRMMF9Mb7f/wJk5wsTxGZXwkXhRUYMYRQYNpZ4LLcoJL84ytyNJF0A3yfbMOZaoYjULSB/ Hwsf2eZu/KrTX6rztE38lOJrrTYm6xPnddGcMo1XKjpE7I86TBtdQHX1hCXd/hUe6p0OW3RgPZuAY u3S5rdSI5g/CuQcCggkPJchYyZ9rHYGjockhPejOIKyvSqcibSsXfdwsgGIk/o1JyP1vFyRI3dONn r1jWwfuSj0TU4bSUsSGlI9KoBG8eZIhVEfCGDsW9D7g4PjpEl6siE4QX4SgJRAx8KV16Kd/hnEd3T lWwtShkA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sg0fu-00000001F1Z-14jA; Mon, 19 Aug 2024 11:35:50 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sg0fC-00000001EvT-2dgl for linux-arm-kernel@lists.infradead.org; Mon, 19 Aug 2024 11:35:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1724067306; x=1755603306; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=N15B/fpX6Wf+7yRZPzvZUR8uMg/qc8/OqC4E1tAFR00=; b=jH3evXTkh6XeTT73g/uR7bBUExFSeNNJADgSF+yXjZFTPxvNHl/od6is X68wZEgzrmrnVKQljIPGWOZ88FIMhmEWAOoD1K6pfuoJNe+bbw4GWD2UL b0bt5ytEmBzV2rMkVAVOK7qYL+jVF6akeHpgeruy/tbqYFaQniUKV1xui ZsdZ2gxD1437xbHVyWT+1OuSTjvfMOngI/+X71T4jfe8HZgP9rrTo/sow hh9pqOT4msQ1AI0DGQ+dq8SrKqAczXmZGp/qlmBoTJI9NjgVpG3nOrsFU /w7h2SP6Yy7+jkycr8y7IRTCirXH6nVCZ/dc9uy0lJ1j/gZnVAmbc0JhA w==; X-CSE-ConnectionGUID: faJc6t2ST8evPLTvnb7ZnA== X-CSE-MsgGUID: 8BZy0lFMQPuHx7v62NpeGA== X-IronPort-AV: E=Sophos;i="6.10,159,1719871200"; d="scan'208";a="38466299" Received: from vmailcow01.tq-net.de ([10.150.86.48]) by mx1.tq-group.com with ESMTP; 19 Aug 2024 13:35:04 +0200 X-CheckPoint: {66C32DE8-B-E9ED6009-C4B0BEC8} X-MAIL-CPID: 436127ADD3E6AA614B224FC9CA86742D_3 X-Control-Analysis: str=0001.0A782F26.66C32DE8.00EC,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 7F37216141D; Mon, 19 Aug 2024 13:34:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ew.tq-group.com; s=dkim; t=1724067299; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=N15B/fpX6Wf+7yRZPzvZUR8uMg/qc8/OqC4E1tAFR00=; b=DhE9D1D86sGzuRlnxoWc/CkbXtKJg/quYOSybQDXoNb+1ImLjY3dRftM/jvjKQf/sDbPDn upnezyp4nwym3XJqZ+Wz1N+cm+1jGSJDUffMG1ZcO3csVno9mWsNc0nK3VO731x8IZSJ3r Ehw6juC4OqHuurHQHzx5/ZCgGpE2/aGKpLX0TNyuzMjhA6Hk+IYCt8mTNXlFOF6IJijX/4 JbUkZ122zTgx/v4oaSpoEi1kh0MdyfcDIPFSFydoaESNvigoSbZKdjE3KYjd6lK/RY/xip uTbJUMrFDYZrb05ssp14HWlXuPvefUi8AefGAeiXM4TCjfqVTl40VFirND5Qcw== From: Alexander Stein To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Peng Fan Cc: Markus Niebel , "linux@ew.tq-group.com" , "devicetree@vger.kernel.org" , "imx@lists.linux.dev" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 06/14] arm64: dts: freescale: imx93-tqma9352-mba93xxla: improve pad configuration Date: Mon, 19 Aug 2024 13:34:58 +0200 Message-ID: <2197430.irdbgypaU6@steina-w> Organization: TQ-Systems GmbH In-Reply-To: References: <20240724125901.1391698-1-alexander.stein@ew.tq-group.com> <20240724125901.1391698-7-alexander.stein@ew.tq-group.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-Last-TLS-Session-Version: TLSv1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240819_043507_196156_66FC3D7E X-CRM114-Status: GOOD ( 20.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Peng, thanks for the review. Am Donnerstag, 1. August 2024, 05:04:49 CEST schrieb Peng Fan: > > Subject: [PATCH 06/14] arm64: dts: freescale: imx93-tqma9352- > > mba93xxla: improve pad configuration > >=20 > > From: Markus Niebel > >=20 > > - disable PU/PD if already done with external resistors > > - do not configure Schmitt Trigger for outputs > > - do not configure DSE / FSEL for inputs > > - add missing pad groups > > - assign muxed GPIO pads for X1 to gpio2 node > >=20 > > Signed-off-by: Markus Niebel > > Signed-off-by: Alexander Stein > > --- > > .../freescale/imx93-tqma9352-mba93xxla.dts | 237 ++++++++++++---- > > -- > > 1 file changed, 164 insertions(+), 73 deletions(-) > >=20 > > diff --git a/arch/arm64/boot/dts/freescale/imx93-tqma9352- > > mba93xxla.dts b/arch/arm64/boot/dts/freescale/imx93-tqma9352- > > mba93xxla.dts > > index e2ee9f5a042c..c663b6585c3a 100644 > > --- a/arch/arm64/boot/dts/freescale/imx93-tqma9352-mba93xxla.dts > > +++ b/arch/arm64/boot/dts/freescale/imx93-tqma9352-mba93xxla.dts > > @@ -222,6 +222,11 @@ rtc-irq-hog { > > }; > > }; > >=20 > > +&gpio2 { > > + pinctrl-names =3D "default"; > > + pinctrl-0 =3D <&pinctrl_gpio2>; >=20 > I am not sure this is correct, what are this used for? This is for general GPIOs usable from userspace. I'll add a new patch for adding gpio-line-names, so it should be clear. > And this is new, not pad improvement. Okay, I'll separate the changes from adding new/missing ones. > I would prefer the other improvement part merged > with patch 2.=20 Patch 2 already got merged, but despite that this patch is for the mainboard while patch is addressing the module only. > > +}; > > + > > &gpio3 { > > ethphy-eqos-irq-hog { > > gpio-hog; > > @@ -509,25 +514,39 @@ &usdhc2 { > > }; > >=20 > > &iomuxc { > > + pinctrl_afe: afegrp { >=20 > no users? There is no driver yet, but the pinctrl settings can still be created meanwhile. Thanks and best regards, Alexander =2D-=20 TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht M=FCnchen, HRB 105018 Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider http://www.tq-group.com/