From: Pierre Gondois <pierre.gondois@arm.com>
To: Levi Yun <ppbuk5246@gmail.com>, james.morse@arm.com
Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] firmware/arm_sdei: Fix invalid argument to unregister private events.
Date: Mon, 15 Jan 2024 14:01:50 +0100 [thread overview]
Message-ID: <21e77238-4884-40ca-bc01-b7e4774b9239@arm.com> (raw)
In-Reply-To: <20240110090107.26323-1-ppbuk5246@gmail.com>
Hello Levi,
On 1/10/24 10:01, Levi Yun wrote:
> To unregister private events in device freeze, it should call
> cpuhp_remove_state with sdei_hp_state not sdei_entry_point.
> otherwise, it seems to fail on cpuhp_cb_check.
>
I think you can also add:
Fixes: d2c48b2387eb ("firmware: arm_sdei: Fix sleep from invalid context BUG")
> Signed-off-by: Levi Yun <ppbuk5246@gmail.com>
> ---
> drivers/firmware/arm_sdei.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/arm_sdei.c b/drivers/firmware/arm_sdei.c
> index 285fe7ad490d..3e8051fe8296 100644
> --- a/drivers/firmware/arm_sdei.c
> +++ b/drivers/firmware/arm_sdei.c
> @@ -763,7 +763,7 @@ static int sdei_device_freeze(struct device *dev)
> int err;
>
> /* unregister private events */
> - cpuhp_remove_state(sdei_entry_point);
> + cpuhp_remove_state(sdei_hp_state);
Maybe it would also be worth resetting 'sdei_hp_state':
sdei_hp_state = 0;
>
> err = sdei_unregister_shared();
> if (err)
Regards,
Pierre
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-01-15 13:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-10 9:01 [PATCH] firmware/arm_sdei: Fix invalid argument to unregister private events Levi Yun
2024-01-15 13:01 ` Pierre Gondois [this message]
2024-01-15 17:24 ` James Morse
2024-01-17 12:34 ` Yun Levi
2024-01-18 14:14 ` Yun Levi
2024-01-18 20:15 ` [PATCH v2] " Levi Yun
2024-01-18 20:20 ` [PATCH v3] " Levi Yun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21e77238-4884-40ca-bc01-b7e4774b9239@arm.com \
--to=pierre.gondois@arm.com \
--cc=james.morse@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ppbuk5246@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).