From: Supreeth Venkatesh <supvenka@amd.com>
To: Paul Menzel <pmenzel@molgen.mpg.de>,
Supreeth Venkatesh <supreeth.venkatesh@amd.com>
Cc: Andrew Jeffery <andrew@codeconstruct.com.au>,
joel@jms.id.au, andrew@aj.id.au, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
openbmc@lists.ozlabs.org, robh+dt@kernel.org
Subject: Re: [PATCH 1/1] ARM:dts:aspeed: Initial device tree for AMD Onyx Platform
Date: Fri, 1 Mar 2024 14:54:26 -0600 [thread overview]
Message-ID: <21ee5e7e-bddc-48ae-82f8-c8fb611d0a12@amd.com> (raw)
In-Reply-To: <74cd8a61-3d9f-437e-8e3a-22139e23bda5@molgen.mpg.de>
On 2/26/24 01:10, Paul Menzel wrote:
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
>
>
> Dear Supreeth,
>
>
> Thank you for your patch. Should you resent three more nits.
>
> Am 26.02.24 um 07:55 schrieb Andrew Jeffery:
>> On Tue, 2024-01-09 at 21:35 -0600, Supreeth Venkatesh wrote:
>>> This patch adds initial device tree and makefile updates for
>>> AMD Onyx platform.
>>>
>>> AMD Onyx platform is an AMD customer reference board with an Aspeed
>>> ast2600 BMC manufactured by AMD.
>>> It describes I2c devices, Fans, Kcs devices, Uarts, Mac, LEDs, etc.
>>> present on AMD Onyx platform.
>
> I’d capitalize I2Cs, UARTs, and MAC, but would write fans.
Thank you. will incorporate in v2.
>
> Also, could you please make the summary a statement by adding a verb in
> imperative mood. Maybe:
>
> Add initial device tree for AMD Onyx Platform
Thank you. will incorporate in v2.
>
> I’d also add spaces after the colons in the commit message summary.
>
> […]
>
>
> Kind regards,
>
> Paul
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-03-01 20:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-10 3:35 [PATCH 1/1] ARM:dts:aspeed: Initial device tree for AMD Onyx Platform Supreeth Venkatesh
2024-02-08 14:57 ` Supreeth Venkatesh
2024-02-08 21:48 ` Andrew Jeffery
2024-02-09 12:38 ` Krzysztof Kozlowski
2024-03-01 21:02 ` Supreeth Venkatesh
2024-03-02 16:25 ` Krzysztof Kozlowski
2024-02-26 6:55 ` Andrew Jeffery
2024-02-26 7:10 ` Paul Menzel
2024-03-01 20:54 ` Supreeth Venkatesh [this message]
2024-03-01 20:57 ` Supreeth Venkatesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21ee5e7e-bddc-48ae-82f8-c8fb611d0a12@amd.com \
--to=supvenka@amd.com \
--cc=andrew@aj.id.au \
--cc=andrew@codeconstruct.com.au \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=pmenzel@molgen.mpg.de \
--cc=robh+dt@kernel.org \
--cc=supreeth.venkatesh@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox