From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72345C432C0 for ; Tue, 26 Nov 2019 10:25:01 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3CCEF2073F for ; Tue, 26 Nov 2019 10:25:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ToWxztrW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3CCEF2073F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=th+B7RkvOTA8iBLh5Tb1PVtCgnZyePfk2LwU3aFcfTU=; b=ToWxztrWNpbBP4V21uQAIFm0+ osVvs8tbCrivPzPvKXjj0Q3UIiYNkiTyvgU4tn8ItFxiIfOGxv5OVDhFqsal8zFK/yP8WAGCHguGP 62VAkGFCAHXZ1/J2j32K89sH+xw0fHhzmWozZ/FIwZRlwJZawi2TmInNM3TTsmM6QSYyHzrTQjbkP lShpt5WccVa0BVLj/3rL/rBR9EpUq/Q2PmC54x3vOBSRpaL9TW+WpDgsgiXVjcPwqb/H81+if68JJ Lq+VZFarpbPHxn8B76Wh4LcCdVDzMaYLDF1Un04zEUl2dkQpScZWgsMUgG+FFbWa8p4hrLn17iOAM boYxCZrYw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iZY1g-0005sf-Rj; Tue, 26 Nov 2019 10:24:56 +0000 Received: from out30-133.freemail.mail.aliyun.com ([115.124.30.133]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iZY1d-00057l-5M for linux-arm-kernel@lists.infradead.org; Tue, 26 Nov 2019 10:24:54 +0000 X-Alimail-AntiSpam: AC=PASS; BC=-1|-1; BR=01201311R131e4; CH=green; DM=||false|; DS=||; FP=0|-1|-1|-1|0|-1|-1|-1; HT=e01e01422; MF=wenyang@linux.alibaba.com; NM=1; PH=DS; RN=4; SR=0; TI=SMTPD_---0Tj8hI5Z_1574763887; Received: from IT-C02W23QPG8WN.local(mailfrom:wenyang@linux.alibaba.com fp:SMTPD_---0Tj8hI5Z_1574763887) by smtp.aliyun-inc.com(127.0.0.1); Tue, 26 Nov 2019 18:24:48 +0800 Subject: Re: [PATCH] firmware: arm_scmi: avoid double free in error flow To: Sudeep Holla References: <20191125155409.9948-1-wenyang@linux.alibaba.com> <20191125161313.GA1157@bogus> From: Wen Yang Message-ID: <21f4f7d6-9085-382d-42d3-a63484aca8a2@linux.alibaba.com> Date: Tue, 26 Nov 2019 18:24:47 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <20191125161313.GA1157@bogus> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191126_022453_374988_540ABC6F X-CRM114-Status: GOOD ( 15.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, Arnd Bergmann , linux-kernel@vger.kernel.org Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org CgpPbiAyMDE5LzExLzI2IDEyOjEzIOS4iuWNiCwgU3VkZWVwIEhvbGxhIHdyb3RlOgo+IE9uIE1v biwgTm92IDI1LCAyMDE5IGF0IDExOjU0OjA5UE0gKzA4MDAsIFdlbiBZYW5nIHdyb3RlOgo+PiBJ ZiBkZXZpY2VfcmVnaXN0ZXIoKSBmYWlscywgYm90aCBwdXRfZGV2aWNlKCkgYW5kIGtmcmVlKCkK Pj4gYXJlIGNhbGxlZCwgZW5kaW5nIHdpdGggYSBkb3VibGUgZnJlZSBvZiB0aGUgc2NtaV9kZXYu Cj4+Cj4gCj4gQ29ycmVjdC4KPiAKPj4gQ2FsbGluZyBrZnJlZSgpIGlzIG5lZWRlZCBvbmx5IHdo ZW4gYSBmYWlsdXJlIGhhcHBlbnMgYmV0d2VlbiB0aGUKPj4gYWxsb2NhdGlvbiBvZiB0aGUgc2Nt aV9kZXYgYW5kIGl0cyByZWdpc3RyYXRpb24sIHNvIG1vdmUgaXQgdG8KPj4gdGhlcmUgYW5kIHJl bW92ZSBpdCBmcm9tIHRoZSBlcnJvciBmbG93Lgo+Pgo+IAo+IGtzdHJkdXBfY29uc3QgY2FuIGZh aWwgYW5kIGluIHRoYXQgY2FzZSBkZXZpY2UgaXMgbm90IHlldCByZWdpc3RlcmVkLAo+IHNvIHdl IG5lZWQgdG8gZnJlZS4gU2luY2UgZGV2aWNlX3JlZ2lzdGVyKCkgY2FsbHMgcHV0X2RldmljZSgp IG9uIGZhaWx1cmUKPiB0b28sIEkgd291bGQganVzdCBkcm9wIGl0IGFzIGl0J3MgdW5uZWNlc3Nh cnksIG5vdCBzdXJlIHdoeSBJIGhhdmUgYWRkZWQKPiBpdCBpbiB0aGUgZmlyc3QgcGxhY2UuIENh biB5b3UgcmUtc3BpbiB0aGUgcGF0Y2ggZHJvcHBpbmcgcHV0X2RldmljZQo+IGFuZCByZW5hbWlu ZyBwdXRfZGV2IGxhYmVsIHRvIHNvbWV0aGluZyBsaWtlIGZyZWVfY29uc3QuCj4gCj4gLS0KPiBS ZWdhcmRzLAo+IFN1ZGVlcAo+IAoKSGkgU3VkZWVwLApUaGFua3MgZm9yIHlvdXIgY29tbWVudHMu CkxldCdzIGNoZWNrIHRoZSBjb2RlIGxpa2UgdGhpczoKCmludCBkZXZpY2VfcmVnaXN0ZXIoc3Ry dWN0IGRldmljZSAqZGV2KQp7CiAgICAgICAgIGRldmljZV9pbml0aWFsaXplKGRldik7ICAgLS0+ IEluaXRpYWxpemUga29iai0+IGtyZWYgdG8gMQogICAgICAgICByZXR1cm4gZGV2aWNlX2FkZChk ZXYpOwp9CgppbnQgZGV2aWNlX2FkZChzdHJ1Y3QgZGV2aWNlICpkZXYpCnsKLi4uCiAgICAgICAg IGRldiA9IGdldF9kZXZpY2UoZGV2KTsgIC0tPiBrb2JqLT4ga3JlZiBpbmNyZWFzZXMgYnkgMQou Li4KZG9uZToKICAgICAgICAgcHV0X2RldmljZShkZXYpOyAgLS0+IGtvYmotPiBrcmVmIGRlY3Jl YXNlcyBieSAxIGFuZCBpcyBub3cgMQogICAgICAgICByZXR1cm4gZXJyb3I7Ci4uLgp9CgpTbyB3 ZSBhbHNvIG5lZWQgdG8gY2FsbCBwdXRfZGV2aWNlICgpLAphbmQgdGhlIG9yaWdpbmFsIHBhdGNo IHNob3VsZCBiZSBmaW5lLgpQbGVhc2Uga2luZGx5IGhlbHAgdG8gY2hlY2sgYWdhaW4sIHRoYW5r IHlvdS4KCi0tClJlZ2FyZHMsCldlbgoKCgoKCgoKCgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51 eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5v cmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==