public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1] ARM: Exynos: Add generic compatible string
Date: Fri, 21 Feb 2014 15:48:04 +0100	[thread overview]
Message-ID: <2200834.G3JJLYQl5i@wuerfel> (raw)
In-Reply-To: <53075239.4010603@samsung.com>

On Friday 21 February 2014 14:18:49 Tomasz Figa wrote:
> 
> > Now that we have a broader agreement on this, I think we can go ahead with the
> > following steps as an initial approach:
> > 1. Have a common machine file for both exynos4 and 5 files, mach-exynos-dt.c.
> > 2. Introduce a generic compatible string "samsung,exynos".
> > 3. Append this to the compatible property list for existing boards.
> >
> > If this plan looks OK, I can send across patches doing this.
> >
> 
> Looks good. I would also merge common.c with this resulting 
> mach-exynos-dt.c, as it would be the only user of the code there.

Sounds good. While the naming is not important, I would just call the
file 'exynos.c', in line with some of the other platforms we have.
Both the 'mach-' and the '-dt' part of the file name are redundant.

Alternatively, you could merge it all into common.c.

	Arnd

  reply	other threads:[~2014-02-21 14:48 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1392809645-631-1-git-send-email-sachin.kamat@linaro.org>
2014-02-19 12:45 ` [PATCH 1/1] ARM: Exynos: Add generic compatible string Tomasz Figa
2014-02-20  4:14   ` Sachin Kamat
2014-02-20 14:51     ` Tomasz Figa
2014-02-20 17:00       ` Arnd Bergmann
2014-02-20 17:34         ` Tomasz Figa
2014-02-20 17:48           ` Arnd Bergmann
2014-02-21  6:08             ` Sachin Kamat
2014-02-21 13:18               ` Tomasz Figa
2014-02-21 14:48                 ` Arnd Bergmann [this message]
2014-02-21 15:21                   ` Tomasz Figa
2014-02-21 15:31                     ` Tomasz Figa
2014-02-24 12:03                       ` Sachin Kamat
2014-02-25  0:35                         ` Kukjin Kim
2014-02-25  0:52                           ` Tomasz Figa
2014-02-25  1:00                             ` Kukjin Kim
2014-02-25  3:03                             ` Sachin Kamat
2014-02-25  4:42                               ` Olof Johansson
2014-02-25 11:42                                 ` Arnd Bergmann
2014-03-05  8:25                                   ` Sachin Kamat
2014-03-05 12:12                                     ` Tomasz Figa
2014-03-05 15:30                                       ` Sachin Kamat
2014-02-24 12:02                     ` Sachin Kamat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2200834.G3JJLYQl5i@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox