From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1A640C04AAA for ; Wed, 20 Sep 2023 16:07:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qrGWzF3sUMqvjWg6+BhEBrXqAL4Ke92QbFT8l5W//mU=; b=aUHeQy1ext+4rk 6Zht6N6is8xrIW6ZABYleAl8SjlSC5E8qiOPgdu9Qyra3OqcPoUPHn32tuSULgq4Sn0sLIncO+6sa FwPCUtaxubnTzkQ0OZxabb9e3lGSmv5GM0vDt7hPPw/7pENSz6Ekdhw2eKweZVokazR9X4i20GfKg XD7MtfS+wl9uMDOExPfsHOQqr9JoZrqwOJYIIGHqvDywf5GOOrW0arTiSiFAR1kiEncxDUVTtSLIk k/kPn7kPx7pET/heu7Z1CV7NanIfuASYwmIUhfdd4ifd+GUVew/uhBiIPPZp5YbqLrhtUeWPSR9Ud 5tNbOEUsisP49QPLjshQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qizjd-003anK-09; Wed, 20 Sep 2023 16:07:29 +0000 Received: from mail-ed1-x52b.google.com ([2a00:1450:4864:20::52b]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qizja-003alf-1h for linux-arm-kernel@lists.infradead.org; Wed, 20 Sep 2023 16:07:27 +0000 Received: by mail-ed1-x52b.google.com with SMTP id 4fb4d7f45d1cf-52a49a42353so8771193a12.2 for ; Wed, 20 Sep 2023 09:07:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695226042; x=1695830842; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ekSqycYp4RwH4ZHstWy56AGx1vKb/jqJ8VujViJUQjQ=; b=ieIF+wwtCy48PS+wGmPszVLg0AJBBuoW2bNgVYxUpi+cWwAD0E+89GmaK4IIEY0uzc 5Qp/OPs1a7WXAXgH18Brt10hxAXwx4T4eQb7AeS56Hl4zkbN4SxMbSYlDs7fXcPpsgkt vKj9n+KzEpShrDOFGAZjfKoL32AdnKp/0gYJy5oJltLYf47OYKAd+GIWOYmqT0PcCqlp MltQe71zGiG/ljbjCxpe+LMZIXZLus/VmLvkFL/R3pkKigGmtFF2IJNJ9zdi6hr21oCW 1Og2RIFmIS7f/6WAhiYJpiDUrImhCEz4lLtH0UA6eDOQppg9ndldRDhPI8UNC/OMNCZ3 ojiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695226042; x=1695830842; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ekSqycYp4RwH4ZHstWy56AGx1vKb/jqJ8VujViJUQjQ=; b=JvtlxkXyuz60qnMXG5HdC/8KbXhghC3JuJrR/yrAxwSzY3lREJEtnAR10GrpAYCIxm u/bo6D32wTLKpSXcCwQD0yLs1xrwqGUwhZ7EHgj7g9X16OsICRo9gpEnKnrYNGWDBnxe 2+knbO6/8+5oeJKyfL+BC+LaWyyNUaJRasrQUo3eNmnZzotSpmJubuWJjtJwyz6AdwLf 5OacOglSq0oylTfLyErxeqn8aqHONurXcu3h6YinRLKuEFvc6yz26p76xk4qBNLaGXRZ QXb9WclogWPuT8PHOe57M4eYGh42I3AeKmuFZKrJLxq2n5b8gDXTuy9B9JjKmNo3REIs 3wWw== X-Gm-Message-State: AOJu0YzY0B0PeVIcfF+KjaTrSxSM7FFZuOH/lGGQ4R92IBQOhtlOGlFv FuMQLFevxAuR50/zaWErlWg= X-Google-Smtp-Source: AGHT+IGMv0ZtJsEgJtZM/5dYCyyx1ISAg5ccS+2o7Y0ZtAsAUjUiusDZNZo4TvmOYcyMmJW10Tts6A== X-Received: by 2002:aa7:c7d6:0:b0:523:3754:a4e1 with SMTP id o22-20020aa7c7d6000000b005233754a4e1mr2372527eds.22.1695226041144; Wed, 20 Sep 2023 09:07:21 -0700 (PDT) Received: from jernej-laptop.localnet (82-149-12-148.dynamic.telemach.net. [82.149.12.148]) by smtp.gmail.com with ESMTPSA id dn22-20020a05640222f600b00532c1dfe8ecsm2415478edb.66.2023.09.20.09.07.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Sep 2023 09:07:20 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Dmitry Torokhov , Uwe =?ISO-8859-1?Q?Kleine=2DK=F6nig?= Cc: Chen-Yu Tsai , Samuel Holland , "Rafael J. Wysocki" , Krzysztof Kozlowski , Daniel Lezcano , Jonathan Corbet , linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, kernel@pengutronix.de Subject: Re: [PATCH 49/52] input: sun4i-ts - Convert to platform remove callback returning void Date: Wed, 20 Sep 2023 18:07:18 +0200 Message-ID: <22023189.EfDdHjke4D@jernej-laptop> In-Reply-To: <20230920125829.1478827-50-u.kleine-koenig@pengutronix.de> References: <20230920125829.1478827-1-u.kleine-koenig@pengutronix.de> <20230920125829.1478827-50-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230920_090726_571590_0F1692A7 X-CRM114-Status: GOOD ( 22.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne sreda, 20. september 2023 ob 14:58:26 CEST je Uwe Kleine-K=F6nig napisa= l(a): > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is ignored (apart > from emitting a warning) and this typically results in resource leaks. > To improve here there is a quest to make the remove callback return > void. In the first step of this quest all drivers are converted to > .remove_new() which already returns void. Eventually after all drivers > are converted, .remove_new() will be renamed to .remove(). > = > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > = > Signed-off-by: Uwe Kleine-K=F6nig Acked-by: Jernej Skrabec Best regards, Jernej > --- > drivers/input/touchscreen/sun4i-ts.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > = > diff --git a/drivers/input/touchscreen/sun4i-ts.c > b/drivers/input/touchscreen/sun4i-ts.c index bb3c6072fc82..92b2b840b4b7 > 100644 > --- a/drivers/input/touchscreen/sun4i-ts.c > +++ b/drivers/input/touchscreen/sun4i-ts.c > @@ -375,7 +375,7 @@ static int sun4i_ts_probe(struct platform_device *pde= v) > return 0; > } > = > -static int sun4i_ts_remove(struct platform_device *pdev) > +static void sun4i_ts_remove(struct platform_device *pdev) > { > struct sun4i_ts_data *ts =3D platform_get_drvdata(pdev); > = > @@ -385,8 +385,6 @@ static int sun4i_ts_remove(struct platform_device *pd= ev) > = > /* Deactivate all IRQs */ > writel(0, ts->base + TP_INT_FIFOC); > - > - return 0; > } > = > static const struct of_device_id sun4i_ts_of_match[] =3D { > @@ -403,7 +401,7 @@ static struct platform_driver sun4i_ts_driver =3D { > .of_match_table =3D sun4i_ts_of_match, > }, > .probe =3D sun4i_ts_probe, > - .remove =3D sun4i_ts_remove, > + .remove_new =3D sun4i_ts_remove, > }; > = > module_platform_driver(sun4i_ts_driver); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel