public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] cpufreq: exynos: allow modular build
Date: Sat, 31 Jan 2015 23:37:01 +0100	[thread overview]
Message-ID: <2204000.ofqAym34Rh@wuerfel> (raw)
In-Reply-To: <20150130215118.GA14374@developer.amazonguestwifi.org>

On Friday 30 January 2015 17:51:24 Eduardo Valentin wrote:
> > > @@ -90,6 +84,20 @@ config ARM_EXYNOS_CPU_FREQ_BOOST_SW
> > >  
> > >       If in doubt, say N.
> > >  
> > > +config ARM_EXYNOS5440_CPUFREQ
> > > +   bool "SAMSUNG EXYNOS5440"
> > > +   depends on SOC_EXYNOS5440
> > > +   depends on HAVE_CLK && OF
> > > +   select PM_OPP
> > > +   default y
> > > +   help
> > > +     This adds the CPUFreq driver for Samsung EXYNOS5440
> > > +     SoC. The nature of exynos5440 clock controller is
> > > +     different than previous exynos controllers so not using
> > > +     the common exynos framework.
> > > +
> > > +     If in doubt, say N.
> > 
> > I believe this one also has to be tristate, for the same reason.
> > 
> 
> I agree with you that it is better if we make it tristate. So, on my
> side, I have no concerns changing it to tristate.
> 
> However, the exynos5440 cpufreq driver does not depend on of thermal as
> of today, and therefore, I did not touch this driver for this matter.
> Meaning, if it is not causing troubles, no need to mess with it.
> 
> But I can add this change. No issues, on my side.

Sorry, my mistake. I remembered incorrectly that the problem was
in both modules, but you are right that it does not exist in the exynos5440
one. It is not a mistake to turn this into tristate, but there is no
immediate neeed, so either version is fine.

	Arnd

  reply	other threads:[~2015-01-31 22:37 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-28 13:16 [PATCH 0/3] cpufreq: build fixes Arnd Bergmann
2015-01-28 13:16 ` [PATCH 1/3] cpufreq: s3c: remove incorrect __init annotations Arnd Bergmann
2015-01-29  3:23   ` Viresh Kumar
2015-01-28 13:16 ` [PATCH 2/3] cpufreq: s3c: remove last use of resume_clocks callback Arnd Bergmann
2015-01-29  3:23   ` Viresh Kumar
2015-01-28 13:16 ` [PATCH 3/3] cpufreq: exynos: allow modular build Arnd Bergmann
2015-01-28 17:22   ` Eduardo Valentin
2015-01-28 20:01     ` Arnd Bergmann
2015-01-29  3:39       ` Viresh Kumar
2015-01-29 10:01         ` Arnd Bergmann
2015-01-29 10:10           ` Viresh Kumar
2015-01-29 12:42             ` Arnd Bergmann
2015-01-29 22:21               ` Eduardo Valentin
2015-01-30 21:24                 ` Arnd Bergmann
2015-01-30 21:51                   ` Eduardo Valentin
2015-01-31 22:37                     ` Arnd Bergmann [this message]
2015-01-30  0:58 ` [PATCH 0/3] cpufreq: build fixes Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2204000.ofqAym34Rh@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox