* Build error: OMAP randconfig / mvebu
@ 2013-02-08 10:08 Russell King - ARM Linux
2013-02-08 10:45 ` Arnd Bergmann
0 siblings, 1 reply; 16+ messages in thread
From: Russell King - ARM Linux @ 2013-02-08 10:08 UTC (permalink / raw)
To: linux-arm-kernel
Last night's OMAP4430SDP randconfig build failed with:
arch/arm/mach-mvebu/built-in.o: In function `armada_xp_smp_init_cpus':
hotplug.c:(.init.text+0x70): undefined reference to `coherency_get_cpu_count'
hotplug.c:(.init.text+0xb4): undefined reference to `armada_mpic_send_doorbell'
arch/arm/mach-mvebu/built-in.o: In function `armada_xp_smp_prepare_cpus':
hotplug.c:(.init.text+0x254): undefined reference to `set_cpu_coherent'
arch/arm/mach-mvebu/built-in.o: In function `armada_xp_boot_secondary':
hotplug.c:(.cpuinit.text+0x10): undefined reference to `armada_xp_boot_cpu'
arch/arm/mach-mvebu/built-in.o: In function `armada_xp_secondary_init':
hotplug.c:(.cpuinit.text+0x2c): undefined reference to `armada_xp_mpic_smp_cpu_init'
arch/arm/mach-mvebu/built-in.o: In function `armada_xp_secondary_startup':
hotplug.c:(.cpuinit.text+0x40): undefined reference to `ll_set_cpu_coherent'
This seems to be because we ended up with CONFIG_ARCH_MVEBU=y but without
CONFIG_MACH_ARMADA_370_XP being set - and because of OMAP, we have SMP
and hotplug CPU enabled.
Usual configs/logs available via the website.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Build error: OMAP randconfig / mvebu
2013-02-08 10:08 Build error: OMAP randconfig / mvebu Russell King - ARM Linux
@ 2013-02-08 10:45 ` Arnd Bergmann
2013-02-08 11:06 ` Gregory CLEMENT
0 siblings, 1 reply; 16+ messages in thread
From: Arnd Bergmann @ 2013-02-08 10:45 UTC (permalink / raw)
To: linux-arm-kernel
On Friday 08 February 2013 10:08:13 Russell King - ARM Linux wrote:
> Last night's OMAP4430SDP randconfig build failed with:
>
> arch/arm/mach-mvebu/built-in.o: In function `armada_xp_smp_init_cpus':
> hotplug.c:(.init.text+0x70): undefined reference to `coherency_get_cpu_count'
> hotplug.c:(.init.text+0xb4): undefined reference to `armada_mpic_send_doorbell'
> arch/arm/mach-mvebu/built-in.o: In function `armada_xp_smp_prepare_cpus':
> hotplug.c:(.init.text+0x254): undefined reference to `set_cpu_coherent'
> arch/arm/mach-mvebu/built-in.o: In function `armada_xp_boot_secondary':
> hotplug.c:(.cpuinit.text+0x10): undefined reference to `armada_xp_boot_cpu'
> arch/arm/mach-mvebu/built-in.o: In function `armada_xp_secondary_init':
> hotplug.c:(.cpuinit.text+0x2c): undefined reference to `armada_xp_mpic_smp_cpu_init'
> arch/arm/mach-mvebu/built-in.o: In function `armada_xp_secondary_startup':
> hotplug.c:(.cpuinit.text+0x40): undefined reference to `ll_set_cpu_coherent'
>
> This seems to be because we ended up with CONFIG_ARCH_MVEBU=y but without
> CONFIG_MACH_ARMADA_370_XP being set - and because of OMAP, we have SMP
> and hotplug CPU enabled.
>
> Usual configs/logs available via the website.
Ok, I see. I suspect we are going to see a lot more randconfig failures
now with all the platforms that are becoming part of multiplatform.
mvebu maintainers: this one should be easy enough to fix. Anyone
submitting a patch?
Arnd
^ permalink raw reply [flat|nested] 16+ messages in thread
* Build error: OMAP randconfig / mvebu
2013-02-08 10:45 ` Arnd Bergmann
@ 2013-02-08 11:06 ` Gregory CLEMENT
2013-02-08 13:33 ` Arnd Bergmann
0 siblings, 1 reply; 16+ messages in thread
From: Gregory CLEMENT @ 2013-02-08 11:06 UTC (permalink / raw)
To: linux-arm-kernel
On 02/08/2013 11:45 AM, Arnd Bergmann wrote:
> On Friday 08 February 2013 10:08:13 Russell King - ARM Linux wrote:
>> Last night's OMAP4430SDP randconfig build failed with:
>>
>> arch/arm/mach-mvebu/built-in.o: In function `armada_xp_smp_init_cpus':
>> hotplug.c:(.init.text+0x70): undefined reference to `coherency_get_cpu_count'
>> hotplug.c:(.init.text+0xb4): undefined reference to `armada_mpic_send_doorbell'
>> arch/arm/mach-mvebu/built-in.o: In function `armada_xp_smp_prepare_cpus':
>> hotplug.c:(.init.text+0x254): undefined reference to `set_cpu_coherent'
>> arch/arm/mach-mvebu/built-in.o: In function `armada_xp_boot_secondary':
>> hotplug.c:(.cpuinit.text+0x10): undefined reference to `armada_xp_boot_cpu'
>> arch/arm/mach-mvebu/built-in.o: In function `armada_xp_secondary_init':
>> hotplug.c:(.cpuinit.text+0x2c): undefined reference to `armada_xp_mpic_smp_cpu_init'
>> arch/arm/mach-mvebu/built-in.o: In function `armada_xp_secondary_startup':
>> hotplug.c:(.cpuinit.text+0x40): undefined reference to `ll_set_cpu_coherent'
>>
>> This seems to be because we ended up with CONFIG_ARCH_MVEBU=y but without
>> CONFIG_MACH_ARMADA_370_XP being set - and because of OMAP, we have SMP
>> and hotplug CPU enabled.
>>
>> Usual configs/logs available via the website.
>
> Ok, I see. I suspect we are going to see a lot more randconfig failures
> now with all the platforms that are becoming part of multiplatform.
>
> mvebu maintainers: this one should be easy enough to fix. Anyone
> submitting a patch?
I don't know what to do here, there is no point to build any of the files
in mach-mvebu if no SoCs are selected. So either we force to have at least
one SoCS selected if ARCH_MVEBU is selected, or we unselect ARCH_MVEB if
no SoCs are selected.
Gregory
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 16+ messages in thread
* Build error: OMAP randconfig / mvebu
2013-02-08 11:06 ` Gregory CLEMENT
@ 2013-02-08 13:33 ` Arnd Bergmann
2013-02-14 10:09 ` Russell King - ARM Linux
2013-02-14 12:21 ` Gregory CLEMENT
0 siblings, 2 replies; 16+ messages in thread
From: Arnd Bergmann @ 2013-02-08 13:33 UTC (permalink / raw)
To: linux-arm-kernel
On Friday 08 February 2013 12:06:44 Gregory CLEMENT wrote:
>
> I don't know what to do here, there is no point to build any of the files
> in mach-mvebu if no SoCs are selected. So either we force to have at least
> one SoCS selected if ARCH_MVEBU is selected, or we unselect ARCH_MVEB if
> no SoCs are selected.
The latter does not work, because that would introduce a circular
dependency in Kconfig.
I suppose rearranging the mvebu Makefile like this would do.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
diff --git a/arch/arm/mach-mvebu/Makefile b/arch/arm/mach-mvebu/Makefile
index 99df4df..c0434dc 100644
--- a/arch/arm/mach-mvebu/Makefile
+++ b/arch/arm/mach-mvebu/Makefile
@@ -1,9 +1,15 @@
ccflags-$(CONFIG_ARCH_MULTIPLATFORM) := -I$(srctree)/$(src)/include \
-I$(srctree)/arch/arm/plat-orion/include
-AFLAGS_coherency_ll.o := -Wa,-march=armv7-a
+AFLAGS_coherency_ll.o := -Wa,-march=armv7-a
-obj-y += system-controller.o
-obj-$(CONFIG_MACH_ARMADA_370_XP) += armada-370-xp.o irq-armada-370-xp.o addr-map.o coherency.o coherency_ll.o pmsu.o
-obj-$(CONFIG_SMP) += platsmp.o headsmp.o
-obj-$(CONFIG_HOTPLUG_CPU) += hotplug.o
+obj-$(CONFIG_MACH_ARMADA_370_XP) += $(armada-y)
+armada-y += system-controller.o
+armada-y += armada-370-xp.o
+armada-y += irq-armada-370-xp.o
+armada-y += addr-map.o
+armada-y += coherency.o
+armada-y += coherency_ll.o
+armada-y += pmsu.o
+armada-$(CONFIG_SMP) += platsmp.o headsmp.o
+armada-$(CONFIG_HOTPLUG_CPU) += hotplug.o
^ permalink raw reply related [flat|nested] 16+ messages in thread
* Build error: OMAP randconfig / mvebu
2013-02-08 13:33 ` Arnd Bergmann
@ 2013-02-14 10:09 ` Russell King - ARM Linux
2013-02-14 11:03 ` Ezequiel Garcia
2013-02-14 12:21 ` Gregory CLEMENT
1 sibling, 1 reply; 16+ messages in thread
From: Russell King - ARM Linux @ 2013-02-14 10:09 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Feb 08, 2013 at 02:33:29PM +0100, Arnd Bergmann wrote:
> On Friday 08 February 2013 12:06:44 Gregory CLEMENT wrote:
> >
> > I don't know what to do here, there is no point to build any of the files
> > in mach-mvebu if no SoCs are selected. So either we force to have at least
> > one SoCS selected if ARCH_MVEBU is selected, or we unselect ARCH_MVEB if
> > no SoCs are selected.
>
> The latter does not work, because that would introduce a circular
> dependency in Kconfig.
>
> I suppose rearranging the mvebu Makefile like this would do.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
This error is still present in arm-soc. We're getting close to the next
merge window, so either something needs to be dropped from arm-soc, or
this needs to get fixed.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Build error: OMAP randconfig / mvebu
2013-02-14 10:09 ` Russell King - ARM Linux
@ 2013-02-14 11:03 ` Ezequiel Garcia
2013-02-14 11:08 ` Russell King - ARM Linux
2013-02-14 11:12 ` Arnd Bergmann
0 siblings, 2 replies; 16+ messages in thread
From: Ezequiel Garcia @ 2013-02-14 11:03 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Feb 14, 2013 at 10:09:26AM +0000, Russell King - ARM Linux wrote:
> On Fri, Feb 08, 2013 at 02:33:29PM +0100, Arnd Bergmann wrote:
> > On Friday 08 February 2013 12:06:44 Gregory CLEMENT wrote:
> > >
> > > I don't know what to do here, there is no point to build any of the files
> > > in mach-mvebu if no SoCs are selected. So either we force to have at least
> > > one SoCS selected if ARCH_MVEBU is selected, or we unselect ARCH_MVEB if
> > > no SoCs are selected.
> >
> > The latter does not work, because that would introduce a circular
> > dependency in Kconfig.
> >
> > I suppose rearranging the mvebu Makefile like this would do.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> This error is still present in arm-soc. We're getting close to the next
> merge window, so either something needs to be dropped from arm-soc, or
> this needs to get fixed.
>
Can you point me to where can I get the config your building with?
Thanks,
--
Ezequiel Garc?a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 16+ messages in thread
* Build error: OMAP randconfig / mvebu
2013-02-14 11:03 ` Ezequiel Garcia
@ 2013-02-14 11:08 ` Russell King - ARM Linux
2013-02-14 11:12 ` Ezequiel Garcia
2013-02-14 11:12 ` Arnd Bergmann
1 sibling, 1 reply; 16+ messages in thread
From: Russell King - ARM Linux @ 2013-02-14 11:08 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Feb 14, 2013 at 08:03:08AM -0300, Ezequiel Garcia wrote:
> On Thu, Feb 14, 2013 at 10:09:26AM +0000, Russell King - ARM Linux wrote:
> > On Fri, Feb 08, 2013 at 02:33:29PM +0100, Arnd Bergmann wrote:
> > > On Friday 08 February 2013 12:06:44 Gregory CLEMENT wrote:
> > > >
> > > > I don't know what to do here, there is no point to build any of the files
> > > > in mach-mvebu if no SoCs are selected. So either we force to have at least
> > > > one SoCS selected if ARCH_MVEBU is selected, or we unselect ARCH_MVEB if
> > > > no SoCs are selected.
> > >
> > > The latter does not work, because that would introduce a circular
> > > dependency in Kconfig.
> > >
> > > I suppose rearranging the mvebu Makefile like this would do.
> > >
> > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> >
> > This error is still present in arm-soc. We're getting close to the next
> > merge window, so either something needs to be dropped from arm-soc, or
> > this needs to get fixed.
> >
>
> Can you point me to where can I get the config your building with?
It's all publically available via my website.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Build error: OMAP randconfig / mvebu
2013-02-14 11:03 ` Ezequiel Garcia
2013-02-14 11:08 ` Russell King - ARM Linux
@ 2013-02-14 11:12 ` Arnd Bergmann
1 sibling, 0 replies; 16+ messages in thread
From: Arnd Bergmann @ 2013-02-14 11:12 UTC (permalink / raw)
To: linux-arm-kernel
On Thursday 14 February 2013, Ezequiel Garcia wrote:
> On Thu, Feb 14, 2013 at 10:09:26AM +0000, Russell King - ARM Linux wrote:
> > On Fri, Feb 08, 2013 at 02:33:29PM +0100, Arnd Bergmann wrote:
> > > On Friday 08 February 2013 12:06:44 Gregory CLEMENT wrote:
> > > >
> > > > I don't know what to do here, there is no point to build any of the files
> > > > in mach-mvebu if no SoCs are selected. So either we force to have at least
> > > > one SoCS selected if ARCH_MVEBU is selected, or we unselect ARCH_MVEB if
> > > > no SoCs are selected.
> > >
> > > The latter does not work, because that would introduce a circular
> > > dependency in Kconfig.
> > >
> > > I suppose rearranging the mvebu Makefile like this would do.
> > >
> > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> >
> > This error is still present in arm-soc. We're getting close to the next
> > merge window, so either something needs to be dropped from arm-soc, or
> > this needs to get fixed.
> >
>
> Can you point me to where can I get the config your building with?
It is essentially any configuration that turns on ARCH_MVEBU but not
MACH_ARMADA_370 or MACH_ARMADA_XP.
Arnd
^ permalink raw reply [flat|nested] 16+ messages in thread
* Build error: OMAP randconfig / mvebu
2013-02-14 11:08 ` Russell King - ARM Linux
@ 2013-02-14 11:12 ` Ezequiel Garcia
2013-02-14 11:27 ` Arnd Bergmann
0 siblings, 1 reply; 16+ messages in thread
From: Ezequiel Garcia @ 2013-02-14 11:12 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Feb 14, 2013 at 11:08:03AM +0000, Russell King - ARM Linux wrote:
> On Thu, Feb 14, 2013 at 08:03:08AM -0300, Ezequiel Garcia wrote:
> > On Thu, Feb 14, 2013 at 10:09:26AM +0000, Russell King - ARM Linux wrote:
> > > On Fri, Feb 08, 2013 at 02:33:29PM +0100, Arnd Bergmann wrote:
> > > > On Friday 08 February 2013 12:06:44 Gregory CLEMENT wrote:
> > > > >
> > > > > I don't know what to do here, there is no point to build any of the files
> > > > > in mach-mvebu if no SoCs are selected. So either we force to have at least
> > > > > one SoCS selected if ARCH_MVEBU is selected, or we unselect ARCH_MVEB if
> > > > > no SoCs are selected.
> > > >
> > > > The latter does not work, because that would introduce a circular
> > > > dependency in Kconfig.
> > > >
> > > > I suppose rearranging the mvebu Makefile like this would do.
> > > >
> > > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > >
> > > This error is still present in arm-soc. We're getting close to the next
> > > merge window, so either something needs to be dropped from arm-soc, or
> > > this needs to get fixed.
> > >
> >
> > Can you point me to where can I get the config your building with?
>
> It's all publically available via my website.
I'm kind of new around here, and I have no clue where that may be.
I hope you don't mind helping me this time.
Thanks,
--
Ezequiel Garc?a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 16+ messages in thread
* Build error: OMAP randconfig / mvebu
2013-02-14 11:12 ` Ezequiel Garcia
@ 2013-02-14 11:27 ` Arnd Bergmann
2013-02-14 12:06 ` Ezequiel Garcia
0 siblings, 1 reply; 16+ messages in thread
From: Arnd Bergmann @ 2013-02-14 11:27 UTC (permalink / raw)
To: linux-arm-kernel
On Thursday 14 February 2013, Ezequiel Garcia wrote:
> On Thu, Feb 14, 2013 at 11:08:03AM +0000, Russell King - ARM Linux wrote:
> >
> > It's all publically available via my website.
>
> I'm kind of new around here, and I have no clue where that may be.
>
> I hope you don't mind helping me this time.
Please have a look at http://www.arm.linux.org.uk/developer/build/
Arnd
^ permalink raw reply [flat|nested] 16+ messages in thread
* Build error: OMAP randconfig / mvebu
2013-02-14 11:27 ` Arnd Bergmann
@ 2013-02-14 12:06 ` Ezequiel Garcia
2013-02-14 12:21 ` Arnd Bergmann
0 siblings, 1 reply; 16+ messages in thread
From: Ezequiel Garcia @ 2013-02-14 12:06 UTC (permalink / raw)
To: linux-arm-kernel
Hi Arnd,
On Thu, Feb 14, 2013 at 11:27:07AM +0000, Arnd Bergmann wrote:
> On Thursday 14 February 2013, Ezequiel Garcia wrote:
> > On Thu, Feb 14, 2013 at 11:08:03AM +0000, Russell King - ARM Linux wrote:
> > >
> > > It's all publically available via my website.
> >
> > I'm kind of new around here, and I have no clue where that may be.
> >
> > I hope you don't mind helping me this time.
>
>
> Please have a look at http://www.arm.linux.org.uk/developer/build/
Okey.
FYI, using the random config file for OMAP4430 and also with a manual
config that chooses ARCH_MVEBU but doesn't choose MACH_ARMADA_XP or
MACH_ARMADA_370, this make error is *gone* after applying your patch:
arch/arm/mach-mvebu/built-in.o: In function `armada_xp_smp_init_cpus':
:(.init.text+0x74): undefined reference to `coherency_get_cpu_count'
:(.init.text+0xb8): undefined reference to `armada_mpic_send_doorbell'
arch/arm/mach-mvebu/built-in.o: In function `armada_xp_smp_prepare_cpus':
:(.init.text+0x250): undefined reference to `set_cpu_coherent'
arch/arm/mach-mvebu/built-in.o: In function `armada_xp_boot_secondary':
:(.cpuinit.text+0x10): undefined reference to `armada_xp_boot_cpu'
arch/arm/mach-mvebu/built-in.o: In function `armada_xp_secondary_init':
:(.cpuinit.text+0x2c): undefined reference to `armada_xp_mpic_smp_cpu_init'
arch/arm/mach-mvebu/built-in.o: In function `armada_xp_secondary_startup':
:(.cpuinit.text+0x40): undefined reference to `ll_set_cpu_coherent'
Now, using the random config there's a new error, unrelated to the
previous one:
ERROR: "twl6030_interrupt_unmask" [drivers/usb/otg/twl6030-usb.ko] undefined!
ERROR: "twl_i2c_read_u8" [drivers/usb/otg/twl6030-usb.ko] undefined!
ERROR: "twl_i2c_write_u8" [drivers/usb/otg/twl6030-usb.ko] undefined!
ERROR: "twl6030_interrupt_mask" [drivers/usb/otg/twl6030-usb.ko] undefined!
Regards,
--
Ezequiel Garc?a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 16+ messages in thread
* Build error: OMAP randconfig / mvebu
2013-02-14 12:06 ` Ezequiel Garcia
@ 2013-02-14 12:21 ` Arnd Bergmann
2013-02-14 12:35 ` Gregory CLEMENT
` (2 more replies)
0 siblings, 3 replies; 16+ messages in thread
From: Arnd Bergmann @ 2013-02-14 12:21 UTC (permalink / raw)
To: linux-arm-kernel
On Thursday 14 February 2013, Ezequiel Garcia wrote:
> Now, using the random config there's a new error, unrelated to the
> previous one:
>
> ERROR: "twl6030_interrupt_unmask" [drivers/usb/otg/twl6030-usb.ko] undefined!
> ERROR: "twl_i2c_read_u8" [drivers/usb/otg/twl6030-usb.ko] undefined!
> ERROR: "twl_i2c_write_u8" [drivers/usb/otg/twl6030-usb.ko] undefined!
> ERROR: "twl6030_interrupt_mask" [drivers/usb/otg/twl6030-usb.ko] undefined!
Yes, I guess that is an unrelated error. However, my patch also wasn't
correct because it is not allowed to have an empty list of objects.
There is an updated patch below, I could add that straight to the branch
that caused the problem if it looks ok to you.
Arnd
----
>From 0860b5b4558ad777068826bc9a735b82f3cf0d88 Mon Sep 17 00:00:00 2001
From: Arnd Bergmann <arnd@arndb.de>
Date: Thu, 14 Feb 2013 13:14:53 +0100
Subject: [PATCH] ARM: mvebu: allow selecting mvebu without Armada XP
Selecting only CONFIG_ARCH_MVEBU but not the respective
options for Armada 370 or Armada XP results in these
link errors:
arch/arm/mach-mvebu/built-in.o: In function `armada_xp_smp_init_cpus':
arch/arm/mach-mvebu/platsmp.c:91: undefined reference to `coherency_get_cpu_count'
arch/arm/mach-mvebu/platsmp.c:104: undefined reference to `armada_mpic_send_doorbell'
arch/arm/mach-mvebu/built-in.o: In function `armada_xp_smp_prepare_cpus':
arch/arm/mach-mvebu/platsmp.c:111: undefined reference to `set_cpu_coherent'
arch/arm/mach-mvebu/built-in.o: In function `armada_xp_boot_secondary':
arch/arm/mach-mvebu/platsmp.c:83: undefined reference to `armada_xp_boot_cpu'
arch/arm/mach-mvebu/built-in.o: In function `armada_xp_secondary_init':
arch/arm/mach-mvebu/platsmp.c:75: undefined reference to `armada_xp_mpic_smp_cpu_init'
arch/arm/mach-mvebu/built-in.o: In function `armada_xp_secondary_startup':
arch/arm/mach-mvebu/headsmp.S:46: undefined reference to `ll_set_cpu_coherent'
We can solve this by enabling all common MVEBU files that are
referenced by the SMP files. This means we enable code that
is not going to be used without a machine descriptor referencing
it, but only if the kernel is configured specifically for this
case.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Gregory Clement <gregory.clement@free-electrons.com>
Cc: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
diff --git a/arch/arm/mach-mvebu/Makefile b/arch/arm/mach-mvebu/Makefile
index 99df4df..da93bcb 100644
--- a/arch/arm/mach-mvebu/Makefile
+++ b/arch/arm/mach-mvebu/Makefile
@@ -3,7 +3,8 @@ ccflags-$(CONFIG_ARCH_MULTIPLATFORM) := -I$(srctree)/$(src)/include \
AFLAGS_coherency_ll.o := -Wa,-march=armv7-a
-obj-y += system-controller.o
-obj-$(CONFIG_MACH_ARMADA_370_XP) += armada-370-xp.o irq-armada-370-xp.o addr-map.o coherency.o coherency_ll.o pmsu.o
+obj-y += system-controller.o
+obj-$(CONFIG_MACH_ARMADA_370_XP) += armada-370-xp.o
+obj-$(CONFIG_ARCH_MVEBU) += addr-map.o coherency.o coherency_ll.o pmsu.o irq-armada-370-xp.o
obj-$(CONFIG_SMP) += platsmp.o headsmp.o
obj-$(CONFIG_HOTPLUG_CPU) += hotplug.o
^ permalink raw reply related [flat|nested] 16+ messages in thread
* Build error: OMAP randconfig / mvebu
2013-02-08 13:33 ` Arnd Bergmann
2013-02-14 10:09 ` Russell King - ARM Linux
@ 2013-02-14 12:21 ` Gregory CLEMENT
1 sibling, 0 replies; 16+ messages in thread
From: Gregory CLEMENT @ 2013-02-14 12:21 UTC (permalink / raw)
To: linux-arm-kernel
On 02/08/2013 02:33 PM, Arnd Bergmann wrote:
> On Friday 08 February 2013 12:06:44 Gregory CLEMENT wrote:
>>
>> I don't know what to do here, there is no point to build any of the files
>> in mach-mvebu if no SoCs are selected. So either we force to have at least
>> one SoCS selected if ARCH_MVEBU is selected, or we unselect ARCH_MVEB if
>> no SoCs are selected.
>
> The latter does not work, because that would introduce a circular
> dependency in Kconfig.
>
> I suppose rearranging the mvebu Makefile like this would do.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> diff --git a/arch/arm/mach-mvebu/Makefile b/arch/arm/mach-mvebu/Makefile
> index 99df4df..c0434dc 100644
> --- a/arch/arm/mach-mvebu/Makefile
> +++ b/arch/arm/mach-mvebu/Makefile
> @@ -1,9 +1,15 @@
> ccflags-$(CONFIG_ARCH_MULTIPLATFORM) := -I$(srctree)/$(src)/include \
> -I$(srctree)/arch/arm/plat-orion/include
>
> -AFLAGS_coherency_ll.o := -Wa,-march=armv7-a
> +AFLAGS_coherency_ll.o := -Wa,-march=armv7-a
>
> -obj-y += system-controller.o
> -obj-$(CONFIG_MACH_ARMADA_370_XP) += armada-370-xp.o irq-armada-370-xp.o addr-map.o coherency.o coherency_ll.o pmsu.o
> -obj-$(CONFIG_SMP) += platsmp.o headsmp.o
> -obj-$(CONFIG_HOTPLUG_CPU) += hotplug.o
> +obj-$(CONFIG_MACH_ARMADA_370_XP) += $(armada-y)
> +armada-y += system-controller.o
> +armada-y += armada-370-xp.o
> +armada-y += irq-armada-370-xp.o
> +armada-y += addr-map.o
> +armada-y += coherency.o
> +armada-y += coherency_ll.o
> +armada-y += pmsu.o
> +armada-$(CONFIG_SMP) += platsmp.o headsmp.o
> +armada-$(CONFIG_HOTPLUG_CPU) += hotplug.o
>
I have also tested your patch with a config with SMP, MVEBU, SMP and
not MACH_ARMADA_370_XP.
It fixes the build error.
You can add my
Tested-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
How do you want to proceed?
As this patch come from you you should have it somewhere in your git
tree, but I can take care of submitting a proper patch (ie with a
commit log) if you want.
Regards,
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 16+ messages in thread
* Build error: OMAP randconfig / mvebu
2013-02-14 12:21 ` Arnd Bergmann
@ 2013-02-14 12:35 ` Gregory CLEMENT
2013-02-14 12:49 ` Ezequiel Garcia
2013-02-14 19:36 ` Jason Cooper
2 siblings, 0 replies; 16+ messages in thread
From: Gregory CLEMENT @ 2013-02-14 12:35 UTC (permalink / raw)
To: linux-arm-kernel
On 02/14/2013 01:21 PM, Arnd Bergmann wrote:
> On Thursday 14 February 2013, Ezequiel Garcia wrote:
>> Now, using the random config there's a new error, unrelated to the
>> previous one:
>>
>> ERROR: "twl6030_interrupt_unmask" [drivers/usb/otg/twl6030-usb.ko] undefined!
>> ERROR: "twl_i2c_read_u8" [drivers/usb/otg/twl6030-usb.ko] undefined!
>> ERROR: "twl_i2c_write_u8" [drivers/usb/otg/twl6030-usb.ko] undefined!
>> ERROR: "twl6030_interrupt_mask" [drivers/usb/otg/twl6030-usb.ko] undefined!
>
> Yes, I guess that is an unrelated error. However, my patch also wasn't
> correct because it is not allowed to have an empty list of objects.
>
> There is an updated patch below, I could add that straight to the branch
> that caused the problem if it looks ok to you.
OK for me, this patch still fix the build error and I tested that we
still have a valid kernel for Armada 370 for Armada XP
Tested-by: Gregory Clement <gregory.clement@free-electrons.com> on Armada 370 DB
and Armada XP DB
>
> Arnd
> ----
> From 0860b5b4558ad777068826bc9a735b82f3cf0d88 Mon Sep 17 00:00:00 2001
> From: Arnd Bergmann <arnd@arndb.de>
> Date: Thu, 14 Feb 2013 13:14:53 +0100
> Subject: [PATCH] ARM: mvebu: allow selecting mvebu without Armada XP
>
> Selecting only CONFIG_ARCH_MVEBU but not the respective
> options for Armada 370 or Armada XP results in these
> link errors:
>
> arch/arm/mach-mvebu/built-in.o: In function `armada_xp_smp_init_cpus':
> arch/arm/mach-mvebu/platsmp.c:91: undefined reference to `coherency_get_cpu_count'
> arch/arm/mach-mvebu/platsmp.c:104: undefined reference to `armada_mpic_send_doorbell'
> arch/arm/mach-mvebu/built-in.o: In function `armada_xp_smp_prepare_cpus':
> arch/arm/mach-mvebu/platsmp.c:111: undefined reference to `set_cpu_coherent'
> arch/arm/mach-mvebu/built-in.o: In function `armada_xp_boot_secondary':
> arch/arm/mach-mvebu/platsmp.c:83: undefined reference to `armada_xp_boot_cpu'
> arch/arm/mach-mvebu/built-in.o: In function `armada_xp_secondary_init':
> arch/arm/mach-mvebu/platsmp.c:75: undefined reference to `armada_xp_mpic_smp_cpu_init'
> arch/arm/mach-mvebu/built-in.o: In function `armada_xp_secondary_startup':
> arch/arm/mach-mvebu/headsmp.S:46: undefined reference to `ll_set_cpu_coherent'
>
> We can solve this by enabling all common MVEBU files that are
> referenced by the SMP files. This means we enable code that
> is not going to be used without a machine descriptor referencing
> it, but only if the kernel is configured specifically for this
> case.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Cc: Gregory Clement <gregory.clement@free-electrons.com>
> Cc: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
>
> diff --git a/arch/arm/mach-mvebu/Makefile b/arch/arm/mach-mvebu/Makefile
> index 99df4df..da93bcb 100644
> --- a/arch/arm/mach-mvebu/Makefile
> +++ b/arch/arm/mach-mvebu/Makefile
> @@ -3,7 +3,8 @@ ccflags-$(CONFIG_ARCH_MULTIPLATFORM) := -I$(srctree)/$(src)/include \
>
> AFLAGS_coherency_ll.o := -Wa,-march=armv7-a
>
> -obj-y += system-controller.o
> -obj-$(CONFIG_MACH_ARMADA_370_XP) += armada-370-xp.o irq-armada-370-xp.o addr-map.o coherency.o coherency_ll.o pmsu.o
> +obj-y += system-controller.o
> +obj-$(CONFIG_MACH_ARMADA_370_XP) += armada-370-xp.o
> +obj-$(CONFIG_ARCH_MVEBU) += addr-map.o coherency.o coherency_ll.o pmsu.o irq-armada-370-xp.o
> obj-$(CONFIG_SMP) += platsmp.o headsmp.o
> obj-$(CONFIG_HOTPLUG_CPU) += hotplug.o
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 16+ messages in thread
* Build error: OMAP randconfig / mvebu
2013-02-14 12:21 ` Arnd Bergmann
2013-02-14 12:35 ` Gregory CLEMENT
@ 2013-02-14 12:49 ` Ezequiel Garcia
2013-02-14 19:36 ` Jason Cooper
2 siblings, 0 replies; 16+ messages in thread
From: Ezequiel Garcia @ 2013-02-14 12:49 UTC (permalink / raw)
To: linux-arm-kernel
Arnd,
On Thu, Feb 14, 2013 at 12:21:16PM +0000, Arnd Bergmann wrote:
> On Thursday 14 February 2013, Ezequiel Garcia wrote:
> > Now, using the random config there's a new error, unrelated to the
> > previous one:
> >
> > ERROR: "twl6030_interrupt_unmask" [drivers/usb/otg/twl6030-usb.ko] undefined!
> > ERROR: "twl_i2c_read_u8" [drivers/usb/otg/twl6030-usb.ko] undefined!
> > ERROR: "twl_i2c_write_u8" [drivers/usb/otg/twl6030-usb.ko] undefined!
> > ERROR: "twl6030_interrupt_mask" [drivers/usb/otg/twl6030-usb.ko] undefined!
>
> Yes, I guess that is an unrelated error. However, my patch also wasn't
> correct because it is not allowed to have an empty list of objects.
>
> There is an updated patch below, I could add that straight to the branch
> that caused the problem if it looks ok to you.
The compile error is fixed here with this patch also.
Thanks,
--
Ezequiel Garc?a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 16+ messages in thread
* Build error: OMAP randconfig / mvebu
2013-02-14 12:21 ` Arnd Bergmann
2013-02-14 12:35 ` Gregory CLEMENT
2013-02-14 12:49 ` Ezequiel Garcia
@ 2013-02-14 19:36 ` Jason Cooper
2 siblings, 0 replies; 16+ messages in thread
From: Jason Cooper @ 2013-02-14 19:36 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Feb 14, 2013 at 12:21:16PM +0000, Arnd Bergmann wrote:
> On Thursday 14 February 2013, Ezequiel Garcia wrote:
> > Now, using the random config there's a new error, unrelated to the
> > previous one:
> >
> > ERROR: "twl6030_interrupt_unmask" [drivers/usb/otg/twl6030-usb.ko] undefined!
> > ERROR: "twl_i2c_read_u8" [drivers/usb/otg/twl6030-usb.ko] undefined!
> > ERROR: "twl_i2c_write_u8" [drivers/usb/otg/twl6030-usb.ko] undefined!
> > ERROR: "twl6030_interrupt_mask" [drivers/usb/otg/twl6030-usb.ko] undefined!
>
> Yes, I guess that is an unrelated error. However, my patch also wasn't
> correct because it is not allowed to have an empty list of objects.
>
> There is an updated patch below, I could add that straight to the branch
> that caused the problem if it looks ok to you.
If Arnd or Olof want to take this straight in:
Acked-by: Jason Cooper <jason@lakedaemon.net>
thx,
Jason.
>
> Arnd
> ----
> From 0860b5b4558ad777068826bc9a735b82f3cf0d88 Mon Sep 17 00:00:00 2001
> From: Arnd Bergmann <arnd@arndb.de>
> Date: Thu, 14 Feb 2013 13:14:53 +0100
> Subject: [PATCH] ARM: mvebu: allow selecting mvebu without Armada XP
>
> Selecting only CONFIG_ARCH_MVEBU but not the respective
> options for Armada 370 or Armada XP results in these
> link errors:
>
> arch/arm/mach-mvebu/built-in.o: In function `armada_xp_smp_init_cpus':
> arch/arm/mach-mvebu/platsmp.c:91: undefined reference to `coherency_get_cpu_count'
> arch/arm/mach-mvebu/platsmp.c:104: undefined reference to `armada_mpic_send_doorbell'
> arch/arm/mach-mvebu/built-in.o: In function `armada_xp_smp_prepare_cpus':
> arch/arm/mach-mvebu/platsmp.c:111: undefined reference to `set_cpu_coherent'
> arch/arm/mach-mvebu/built-in.o: In function `armada_xp_boot_secondary':
> arch/arm/mach-mvebu/platsmp.c:83: undefined reference to `armada_xp_boot_cpu'
> arch/arm/mach-mvebu/built-in.o: In function `armada_xp_secondary_init':
> arch/arm/mach-mvebu/platsmp.c:75: undefined reference to `armada_xp_mpic_smp_cpu_init'
> arch/arm/mach-mvebu/built-in.o: In function `armada_xp_secondary_startup':
> arch/arm/mach-mvebu/headsmp.S:46: undefined reference to `ll_set_cpu_coherent'
>
> We can solve this by enabling all common MVEBU files that are
> referenced by the SMP files. This means we enable code that
> is not going to be used without a machine descriptor referencing
> it, but only if the kernel is configured specifically for this
> case.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Cc: Gregory Clement <gregory.clement@free-electrons.com>
> Cc: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
>
> diff --git a/arch/arm/mach-mvebu/Makefile b/arch/arm/mach-mvebu/Makefile
> index 99df4df..da93bcb 100644
> --- a/arch/arm/mach-mvebu/Makefile
> +++ b/arch/arm/mach-mvebu/Makefile
> @@ -3,7 +3,8 @@ ccflags-$(CONFIG_ARCH_MULTIPLATFORM) := -I$(srctree)/$(src)/include \
>
> AFLAGS_coherency_ll.o := -Wa,-march=armv7-a
>
> -obj-y += system-controller.o
> -obj-$(CONFIG_MACH_ARMADA_370_XP) += armada-370-xp.o irq-armada-370-xp.o addr-map.o coherency.o coherency_ll.o pmsu.o
> +obj-y += system-controller.o
> +obj-$(CONFIG_MACH_ARMADA_370_XP) += armada-370-xp.o
> +obj-$(CONFIG_ARCH_MVEBU) += addr-map.o coherency.o coherency_ll.o pmsu.o irq-armada-370-xp.o
> obj-$(CONFIG_SMP) += platsmp.o headsmp.o
> obj-$(CONFIG_HOTPLUG_CPU) += hotplug.o
^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2013-02-14 19:36 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-08 10:08 Build error: OMAP randconfig / mvebu Russell King - ARM Linux
2013-02-08 10:45 ` Arnd Bergmann
2013-02-08 11:06 ` Gregory CLEMENT
2013-02-08 13:33 ` Arnd Bergmann
2013-02-14 10:09 ` Russell King - ARM Linux
2013-02-14 11:03 ` Ezequiel Garcia
2013-02-14 11:08 ` Russell King - ARM Linux
2013-02-14 11:12 ` Ezequiel Garcia
2013-02-14 11:27 ` Arnd Bergmann
2013-02-14 12:06 ` Ezequiel Garcia
2013-02-14 12:21 ` Arnd Bergmann
2013-02-14 12:35 ` Gregory CLEMENT
2013-02-14 12:49 ` Ezequiel Garcia
2013-02-14 19:36 ` Jason Cooper
2013-02-14 11:12 ` Arnd Bergmann
2013-02-14 12:21 ` Gregory CLEMENT
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).